From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED40C433EF for ; Wed, 27 Oct 2021 06:57:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0334461073 for ; Wed, 27 Oct 2021 06:57:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0334461073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 744B280007; Wed, 27 Oct 2021 02:57:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F511940007; Wed, 27 Oct 2021 02:57:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E3F380007; Wed, 27 Oct 2021 02:57:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 504D6940007 for ; Wed, 27 Oct 2021 02:57:40 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 146AA30165 for ; Wed, 27 Oct 2021 06:57:40 +0000 (UTC) X-FDA: 78741311880.29.3017562 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf23.hostedemail.com (Postfix) with ESMTP id 23F4090000BF for ; Wed, 27 Oct 2021 06:57:30 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id v200so3782011ybe.11 for ; Tue, 26 Oct 2021 23:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=URxl8t8iTYJfz1qegI+ZGga/wMgCd+ssj3joE4QRces=; b=0oqJUyZAYxOn7SkkO2Owy/OKG6jjgVwHfM5DImY2Uqg7NeRkOA1Jlm015B1yt6Lvrq cF23qnQ8XyXHd27bsFp6OjTqyKoeCKyNpgq+gIf76NbiBY4BM28h6Yzp7wg0+Ly4r4bi 7w0hItzVroBLtPgKBfBFtzm8p2gZzJfWGJY3gFSlAbaCFfLp0Tmkos1Ynz+SfD334Pyx N6tULj3ehsU+EOD6SstWh2OtwKSRqShD0oH9DqqPFPY1diVa1yOgwc9l+YYClVUVPfbP X6CKZt9XOMSzoCcGlK1vlfhuTGM+lCe9f7fP5I6hPdmR09DTghvg3lWc0PqMKcAXfS2c SchQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=URxl8t8iTYJfz1qegI+ZGga/wMgCd+ssj3joE4QRces=; b=V9Rrdkb7vP8/PAdQzy9yDRADjIhMD2yIf0tO0gl9Dwo9df3xYVlDW8G8vuud9BkbID xx58XqcG4Xy33GBVH+XZ1nvJk3nuL1W+owmTYON5pbmisHiaFh3iV5b0evpWsAGw2nHl MvoQa2Txr8S5wJ6k1d22Ztek6jXGzhhxkOTlRwpLuS2ZPLGpyAcK6UTxF3M1xe3qlqup nc2A27c+u/YaHq95ToJ/D5R/lWWCHhPJaOix1/cK1JPpFoyobofW9AzO9jnHz1xOs6yv sBIjxYhcaIofpxTEtroioolDU5bh4ImP3aSFNZg6AEZK6Ec/zSdVy1nbm+XvR9Najisw krkg== X-Gm-Message-State: AOAM533pwKxVGRmV0xQ/Cmd1QyL9KYXsYncGGpSQzmHryfQOGX2pYWCh R0BZi6bGrNd6D1Rxva2KPVTuvNdfcQ+vh+tWFk0e2w== X-Google-Smtp-Source: ABdhPJyuUT26bSUSn9qQ/m4WhUOtF8+ZGACnApnN26Yj5Fyg9OMfR9Ge5DudmEflD3rkSm2YkqZkoxzk+bmDsOIe7aA= X-Received: by 2002:a25:c5cb:: with SMTP id v194mr27182906ybe.419.1635317858126; Tue, 26 Oct 2021 23:57:38 -0700 (PDT) MIME-Version: 1.0 References: <20211026220635.35187-1-mike.kravetz@oracle.com> In-Reply-To: <20211026220635.35187-1-mike.kravetz@oracle.com> From: Muchun Song Date: Wed, 27 Oct 2021 14:57:00 +0800 Message-ID: Subject: Re: [PATCH] hugetlb: remove unnecessary set_page_count in prep_compound_gigantic_page To: Mike Kravetz Cc: Linux Memory Management List , LKML , Matthew Wilcox , Andrew Morton , Pasha Tatashin Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: sj99gpudjnu64j6grsekofen6khjh4yj Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=0oqJUyZA; spf=pass (imf23.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 23F4090000BF X-HE-Tag: 1635317850-571539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 27, 2021 at 6:06 AM Mike Kravetz wrote: > > In commit 7118fc2906e29 ("hugetlb: address ref count racing in > prep_compound_gigantic_page"), page_ref_freeze is used to atomically > zero the ref count of tail pages iff they are 1. The unconditional > call to set_page_count(0) was left in the code. This call is after > page_ref_freeze so it is really a noop. > > Remove redundant and unnecessary set_page_count call. > > Fixes: 7118fc2906e29 ("hugetlb: address ref count racing in prep_compound_gigantic_page") > Suggested-by: Pasha Tatashin > Signed-off-by: Mike Kravetz Reviewed-by: Muchun Song Thanks.