From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C5DC64E69 for ; Fri, 20 Nov 2020 10:43:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 55F4722226 for ; Fri, 20 Nov 2020 10:43:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="jiRnb2Vu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55F4722226 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D2B5C6B006C; Fri, 20 Nov 2020 05:43:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDCE86B006E; Fri, 20 Nov 2020 05:43:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA72A6B0070; Fri, 20 Nov 2020 05:43:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 7EF806B006C for ; Fri, 20 Nov 2020 05:43:31 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0D11E33CD for ; Fri, 20 Nov 2020 10:43:31 +0000 (UTC) X-FDA: 77504460222.09.word07_0e052372734a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id EAE66180AD820 for ; Fri, 20 Nov 2020 10:43:30 +0000 (UTC) X-HE-Tag: word07_0e052372734a X-Filterd-Recvd-Size: 4891 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Nov 2020 10:43:30 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id v5so3429183pff.10 for ; Fri, 20 Nov 2020 02:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mQuIBxgF3nInKkS93utHCBrC42W7hV1R/eZWClqzWyY=; b=jiRnb2Vun3WvAKHS2DVxvEth9FjyVS5SogsErgiDU4+Q6Nsl1EGkcY74MuYVE4cdHt 4UkhpyFGRkFL0rkcjKRRhqb2HrxSRT3UyE6BJJ/QTpKI9yRuYogR7MAQQlXKOxcrBILc xWvHgkwZgKZpJOiX0hqQ+dfqZOfNS2i0tGSUzlQ8eYltW413589oOzimfkKRfZRgXZbu ovGqzcvtMNNluYeI3x1gx4YA/2VWUdbmVMGdr3n6B6s7XvGbTV1t+yezpa9kCTest+gj TWKYtrUPbumihdKMfV1amAuikbAsIGwbTvMzjI1aY+Ua669lZKvVfq1+kUqq+xOYAMvx vu+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mQuIBxgF3nInKkS93utHCBrC42W7hV1R/eZWClqzWyY=; b=Mj/dtM7Wqploxj0wbIREXKo83fQCzkJEBj5abqqWMga3bv3us5i5yckdHNC7DsSddS LFc5Q611Mau2ZmHqAKVjDxsh6VeD5PpdCoi622JeCfu1PvfG+QgKw+782kdI+NzDE/Yx VAXvEci7oQgkKgbOl1zvyqHZJWJRvtoXFyso70hC62/wKjSplP3ypGfMGM2K18F6Wb7F jHNZ4yJMG+R7qENs27qE6qhVAmKJbujH6DRr4+OQHlim2JE5mljWPAJ2nnXHgeL+E4/x 95Av6PM6daoHPe7RMPg2mhjR3ocb8U4uhU9pr42jqjuQoNLpsmbq7Mp0g7x0Yjaglvvp fqyw== X-Gm-Message-State: AOAM531kr65IhScRPIppfRmIrswkhk60XV+7l+vu1OossAidE+B+Rt/n TNv8OpvqWZPWtpXkPiQ8/TPjDbXv7Xq7ndmUV1+XNg== X-Google-Smtp-Source: ABdhPJzU2lJHp8cWhl4H5eA0FRp40MwByTZiz8vUxJJfLjqWf4fU0UXLqt245oSkK/Dg28Trz55Pdn020p1OgPAU5sw= X-Received: by 2002:a63:fe0c:: with SMTP id p12mr16046991pgh.31.1605869009142; Fri, 20 Nov 2020 02:43:29 -0800 (PST) MIME-Version: 1.0 References: <20201120064325.34492-1-songmuchun@bytedance.com> <20201120064325.34492-22-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 20 Nov 2020 18:42:46 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v5 21/21] mm/hugetlb: Disable freeing vmemmap if struct page size is not power of two To: David Hildenbrand Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , Michal Hocko , "Song Bao Hua (Barry Song)" , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 20, 2020 at 5:16 PM David Hildenbrand wrote: > > On 20.11.20 07:43, Muchun Song wrote: > > We only can free the unused vmemmap to the buddy system when the > > size of struct page is a power of two. > > > > Signed-off-by: Muchun Song > > --- > > mm/hugetlb_vmemmap.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > > index c3b3fc041903..7bb749a3eea2 100644 > > --- a/mm/hugetlb_vmemmap.c > > +++ b/mm/hugetlb_vmemmap.c > > @@ -671,7 +671,8 @@ void __init hugetlb_vmemmap_init(struct hstate *h) > > unsigned int order = huge_page_order(h); > > unsigned int vmemmap_pages; > > > > - if (hugetlb_free_vmemmap_disabled) { > > + if (hugetlb_free_vmemmap_disabled || > > + !is_power_of_2(sizeof(struct page))) { > > pr_info("disable free vmemmap pages for %s\n", h->name); > > return; > > } > > > > This patch should be merged into the original patch that introduced > vmemmap freeing. Oh, yeah. Will do. > > -- > Thanks, > > David / dhildenb > -- Yours, Muchun