From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7383FC433F5 for ; Thu, 31 Mar 2022 06:16:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FFD46B0072; Thu, 31 Mar 2022 02:16:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AEF56B0073; Thu, 31 Mar 2022 02:16:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 876CF8D0001; Thu, 31 Mar 2022 02:16:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id 787526B0072 for ; Thu, 31 Mar 2022 02:16:57 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 35EE9182E52F3 for ; Thu, 31 Mar 2022 06:16:57 +0000 (UTC) X-FDA: 79303673274.26.B609539 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf31.hostedemail.com (Postfix) with ESMTP id C4A0A20003 for ; Thu, 31 Mar 2022 06:16:55 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id e203so31758337ybc.12 for ; Wed, 30 Mar 2022 23:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ssMyZLw7ncLemsmqGaMfG0ae57UUUk7vXWBlKG+NN1A=; b=2d+K+RWlJqT+nE6mE8PAkmz9MrEs71tfObMPJmDRdCGm3JD1v+UPAtzj8Jbu8Wm4xp DGUIuhDaPABNKSrd7TpB8GX1KjFQCYSjzzSNRUXVqV+dsjagX3PxE6qIxebCX3dgFy7E +DiMGmDJvumnOVNI8EiUPVNdi0JKxbAWKQECPLUf2nlCeQAHkVGhrJ4mrwl+qSlFnImM nkUjv34LYTL+G5hV+b3387hdlExLvTb6w5VbzTFzA6v7Q5/Boa9dexCVNSmmsJBjV9M6 jLWg5eF3fD1zvdDACie3F3Ev7M26DboU34xmln2X9vRqEogOfnZQSYxGxRNscJxxyCFZ ednw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ssMyZLw7ncLemsmqGaMfG0ae57UUUk7vXWBlKG+NN1A=; b=zz688Wf2NfMtTfg7j6C3nKyaHQoQhP/z8KuM9GXTPcI7VKzYOnvspW0jPV6xiTSz08 bqBthHGMzsmgnVmnnGZT4xsEj07Ml0TGCKQJj9nEIMZBRwImsyLXKgiNWT4s1pTquzjU pmbxlRe/uSMOkekZsCmr8RV5MoinjFTifHHoih1+YzRKD/sSuQfStWc2lcTLlnN2nHx9 fFmm91WjLiU12Brou5mlcLJrOIusA7zRPXE/g0u0QjXbUQ5fWaczmsblo44s2fVf0/vl vdfAmYCenUb9gyHolqEjuDly2qmkke0FaUvzPaoAo8DT1JLibqQsR8GrQguizeKvYPZa 4pwg== X-Gm-Message-State: AOAM531fN1Lg1VNzVnRKNnIwffhCLEguwlrwmaScLFESP3PKHjiU11n6 xgfuwANnjvi5gS9G3yCcwEv5UFKdFlc9hkjq7k+kew== X-Google-Smtp-Source: ABdhPJzPL/5GzcZ7y9X+UBkl5p/lmzz0czNU9Xq1SriFM841PFmkRBojaT7/2rmd3IyxJl4N94K7MBAyzyqp28Kt9KE= X-Received: by 2002:a05:6902:70c:b0:634:73ef:e663 with SMTP id k12-20020a056902070c00b0063473efe663mr3181281ybt.246.1648707413283; Wed, 30 Mar 2022 23:16:53 -0700 (PDT) MIME-Version: 1.0 References: <20220228122126.37293-1-songmuchun@bytedance.com> <20220228122126.37293-13-songmuchun@bytedance.com> <164869718565.25542.15818719940772238394@noble.neil.brown.name> <164870069595.25542.17292003658915487357@noble.neil.brown.name> In-Reply-To: <164870069595.25542.17292003658915487357@noble.neil.brown.name> From: Muchun Song Date: Thu, 31 Mar 2022 14:16:17 +0800 Message-ID: Subject: Re: [PATCH v6 12/16] mm: list_lru: replace linear array with xarray To: NeilBrown , Andrew Morton Cc: Matthew Wilcox , Johannes Weiner , Michal Hocko , Vladimir Davydov , Shakeel Butt , Roman Gushchin , Yang Shi , Alex Shi , Wei Yang , Dave Chinner , trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, jaegeuk@kernel.org, chao@kernel.org, Kari Argillander , Vlastimil Babka , linux-fsdevel , LKML , Linux Memory Management List , linux-nfs@vger.kernel.org, Qi Zheng , Xiongchun duan , Fam Zheng , Muchun Song Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 1d7b4qtcqzwpat6hpagw3qijk8qrmoj3 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=2d+K+RWl; spf=pass (imf31.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C4A0A20003 X-HE-Tag: 1648707415-204903 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 31, 2022 at 12:25 PM NeilBrown wrote: > > On Thu, 31 Mar 2022, Muchun Song wrote: > > > > If the above fix cannot fix your issue, would you mind providing > > the .config and stack trace? > > The kernel I'm using is > 74164d284b2909de0ba13518cc063e9ea9334749 > plus one patch in fs/namei.c > So it does include the commit you mentioned. > > Config is below > > I run > ./check -nfs generic/037 > in xfstests, and crash is quick. > > Stack trace is > > [ 121.557601] BUG: kernel NULL pointer dereference, address: 0000000000000008 > [ 121.558003] #PF: supervisor read access in kernel mode > [ 121.558299] #PF: error_code(0x0000) - not-present page > [ 121.558598] PGD 0 P4D 0 > [ 121.558750] Oops: 0000 [#1] PREEMPT SMP > [ 121.558978] CPU: 2 PID: 1116 Comm: setfattr Not tainted 5.17.0-dev #455 > [ 121.559360] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.15.0-0-g2dd4b9b-rebuilt.opensuse.org 04/01/2014 > [ 121.560009] RIP: 0010:list_lru_add+0x58/0xae > [ 121.560267] Code: 00 48 8d 58 48 74 23 48 89 ef e8 93 08 03 00 49 89 c5 48 85 c0 74 13 8b 90 40 0e 00 00 31 f6 4c 89 e7 e8 66 fb ff ff 48 3 > [ 121.561353] RSP: 0018:ffffc900016dfbd0 EFLAGS: 00010246 > [ 121.561668] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000094fd1aeb > [ 121.562076] RDX: ffff888007768be8 RSI: ffffffff826b4914 RDI: ffffffff82745064 > [ 121.562484] RBP: ffff8880097b3888 R08: ffffffffffffffff R09: ffff888007768b40 > [ 121.562890] R10: ffffc900016dfa98 R11: 0000000000008f0c R12: ffffffff8482e7a0 > [ 121.563296] R13: ffff888007766000 R14: ffff888005e72300 R15: 0000000000000000 > [ 121.563702] FS: 00007f558ef08580(0000) GS:ffff88801f200000(0000) knlGS:0000000000000000 > [ 121.564166] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 121.564499] CR2: 0000000000000008 CR3: 00000000084c4000 CR4: 00000000000006e0 > [ 121.564905] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 121.565314] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 121.565719] Call Trace: > [ 121.565860] > [ 121.565985] nfs4_xattr_get_cache+0x131/0x169 > [ 121.566239] nfs4_xattr_cache_add+0x47/0x15a > [ 121.566485] nfs4_xattr_set_nfs4_user+0xcb/0xef > [ 121.566748] __vfs_setxattr+0x66/0x72 > [ 121.566961] __vfs_setxattr_noperm+0x6e/0xf5 > [ 121.567211] vfs_setxattr+0xa7/0x12a > [ 121.567419] setxattr+0x115/0x14d > [ 121.567612] ? check_chain_key+0xde/0x11f > [ 121.567846] path_setxattr+0x78/0xcf > [ 121.568053] __x64_sys_setxattr+0x22/0x25 > [ 121.568287] do_syscall_64+0x6d/0x80 > [ 121.568497] entry_SYSCALL_64_after_hwframe+0x44/0xae > Thanks for your report. I knew the reason. It is because the following patch in this series was missed upstream. Could you help me test if it works properly? [v6,06/16] nfs42: use a specific kmem_cache to allocate nfs4_xattr_entry Hi Andrew, Would you mind picking it up? Thanks.