From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD43C433EF for ; Tue, 8 Feb 2022 08:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67DE96B0080; Tue, 8 Feb 2022 03:05:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 606636B0081; Tue, 8 Feb 2022 03:05:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CE126B0082; Tue, 8 Feb 2022 03:05:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 39EBC6B0080 for ; Tue, 8 Feb 2022 03:05:11 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E7F58181CA767 for ; Tue, 8 Feb 2022 08:05:10 +0000 (UTC) X-FDA: 79118877180.15.FBC0073 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf30.hostedemail.com (Postfix) with ESMTP id CF12980002 for ; Tue, 8 Feb 2022 08:05:09 +0000 (UTC) Received: by mail-yb1-f170.google.com with SMTP id p19so1028702ybc.6 for ; Tue, 08 Feb 2022 00:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8yRMGQ9KM3TfyDZdKb5kunrD+1OIqyaiE8Y0yAPncVg=; b=47+uj9pJhw4O3nZna6z1PwfKJqVM2DCh9TiPOXeo5Cr4cdtp5cJXx1djSCaETmUgBz TH2J1vWVANZcfeH5WXgtqa6dPET1DfdelbbeLe5dthwb+MiQg3poVTxzy2lBN6UTKkwl E0c3GtPHzaGALbrNOrfpxr8osCrKFxqSNmUtWVfLNj/REK2QkzaxqeNPvy9r62Fw9N3J It/KC7K+wfbzp2OcWC7BqFaJ4DdNIDSnidI6O0dT87Y7TtaWm0RtFjGswZjLKjk2HZNZ RKASzmgsam4Dfl3IJ9AZW5Hrb4ki/VTM9VkEf4fqD+1IlDZXADoMFtfbObT1WBkk20H0 ZZKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8yRMGQ9KM3TfyDZdKb5kunrD+1OIqyaiE8Y0yAPncVg=; b=CJShGjwS2v+HRYSYp3syRll+wSSoxyW+KdHoTaNksN8sTJHqTSZXPe8Wa+7NmOzdaz iri4/yICzpyaQb06MmIRaxdCAJmfyfjU77ipTze9YI/nFyfDJcQvxqIBjtvZnDXDNcOk DGS9Ci9l6YnQIU6xJHsFXExqsGny9qHrkGpgEgncHgZTJyNU0trocUxKDQzVME2/5IrO /ykmYAbn/EZrBWHli51gxTXp1O1yVVTkyc/K9v+4Owbrbr2oL/3KSsARkKsvwvDW4GqY DIMF15B/gtkdPwqB8ynapHr/Azn2RHe93YC3iLKRiST4twOlwp4UtKTS7YuULIOe6H6r EDvg== X-Gm-Message-State: AOAM532cCFjVHI1ZUjtUwiiq4f+Dt4GDpj84KzaSN5ZDsKARFyeB2Hgj WN2WGJyaWJY/4wWhnaveGoxB4OvWxWmJafiZi0f7kcb2znv3gUlB X-Google-Smtp-Source: ABdhPJyCJJw2RfwWeW60zTl7b2c25/mdI9yvpW5X/g4ODDxeYzPf5xyW8sV9x99wyI1iS5zojjyUVoD6zpRGFq4AJ+w= X-Received: by 2002:a25:c983:: with SMTP id z125mr3631067ybf.132.1644307508858; Tue, 08 Feb 2022 00:05:08 -0800 (PST) MIME-Version: 1.0 References: <20220203171904.609984-1-willy@infradead.org> In-Reply-To: <20220203171904.609984-1-willy@infradead.org> From: Muchun Song Date: Tue, 8 Feb 2022 16:04:32 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: Add pvmw_set_page() To: "Matthew Wilcox (Oracle)" Cc: Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: guc3xsaak9mdh7y7u3fft6e7cjkjqcw4 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=47+uj9pJ; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf30.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Queue-Id: CF12980002 X-HE-Tag: 1644307509-50364 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 4, 2022 at 1:19 AM Matthew Wilcox (Oracle) wrote: > > Instead of setting the page directly in struct page_vma_mapped_walk, > use this helper to allow us to transition to a PFN approach in the > next patch. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/rmap.h | 6 ++++++ > kernel/events/uprobes.c | 2 +- > mm/damon/paddr.c | 4 ++-- > mm/ksm.c | 2 +- > mm/migrate.c | 2 +- > mm/page_idle.c | 2 +- > mm/rmap.c | 12 ++++++------ > 7 files changed, 18 insertions(+), 12 deletions(-) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index e704b1a4c06c..003bb5775bb1 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -213,6 +213,12 @@ struct page_vma_mapped_walk { > unsigned int flags; > }; > > +static inline void pvmw_set_page(struct page_vma_mapped_walk *pvmw, > + struct page *page) > +{ > + pvmw->page = page; > +} > + Hi Matthew, How about the name pvmw_set_pfn_from_page()? When I looked at your next patch, I'm feeling this helper is used to set up the pfn from a page instead of setting up the page. Thanks.