From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3471EC433EF for ; Sun, 22 May 2022 22:04:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B24738D0002; Sun, 22 May 2022 18:04:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AADFB8D0001; Sun, 22 May 2022 18:04:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94F708D0002; Sun, 22 May 2022 18:04:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8025D8D0001 for ; Sun, 22 May 2022 18:04:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7452C20A9E for ; Sun, 22 May 2022 06:48:22 +0000 (UTC) X-FDA: 79492450044.24.36FC44B Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf25.hostedemail.com (Postfix) with ESMTP id 7F9EBA002A for ; Sun, 22 May 2022 06:47:54 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id q135so20389648ybg.10 for ; Sat, 21 May 2022 23:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v+86wYP36U311zaok342X50l9ECadNdMvxTZhZZ14tg=; b=2UtmFRcCttqhVCYCxkvMGj1oc42Q+TyiCf7Rh2JlB+DFl9as9uUEP04r2Tx9KZzwMw YWV/0SVPIrdAzgtlxIJrFaVbtgMWlklBLxambHEJKDPlReq8UdjzGw9drwD6TMoVRO+V G54/gUVExox3CmE1K3kCF1KpEpk5ioGFI0a7ASDRM35NvxidOzMd4230U4oSfpZ0yP+T 9tbyFvrynWSP5oVmMaPsVvyuiRX5LsOgS1R53xUZvsa7JZo/GbuTq8yT44YuCxf0I8LU nX0KSUO+R0vfTSTblwBGQDCKkvV6ljOTr/wf/pLoT6nYKV5jR0DXNCg9O+TZ7a4MlAQ8 4XAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v+86wYP36U311zaok342X50l9ECadNdMvxTZhZZ14tg=; b=M4rqKSKqewMugMGspCKeEF8Ns+64jTXbglqlg45gEZ5ZR5PzxZi3ipMtdbAr0ZtTdX SYMjFENCwSB1fI51+WGdQJ5PcWUKYIfEURL8H644Hsq57cARkFxMpWD81PoKepcH8Bs7 HWom9egurhKH5YS0qGKLumOD46+xI47VZnN5zEvQJMxkKOE0+IsCo8JxkhUoJjRiruc1 MsUwMtO1UR4NfICkkw2GxMjlfyeTM08Xtf6G9MWnx/bk4NEvSpWMJnwKpP/yOklWEqCq 9T44tTxL3eP0cYokuBT8b6R8iBruDgHc05VuDGcAsMDQhgkzU3LhwsnkDjRjp0c3n+yY qGhg== X-Gm-Message-State: AOAM531LPEiUGXg4WpbrX7D+ZJ72a8xTUciUNA+Om9tbZ5soP7et0/LJ QXgUBD4E/bxvuecetlgz/ur8R+uP1R860vui5KNMuQ== X-Google-Smtp-Source: ABdhPJy/hxbB+HcmNHUq9GLnjBjRRMwDZCFUNbBD4QiZdQ2+dSMuHi6jgHmZszNcElwj/QiJCEFPP6kTaS1hMBJDU9I= X-Received: by 2002:a25:6fd4:0:b0:649:a5f5:c6b2 with SMTP id k203-20020a256fd4000000b00649a5f5c6b2mr16641652ybc.132.1653202098638; Sat, 21 May 2022 23:48:18 -0700 (PDT) MIME-Version: 1.0 References: <9925d0ba-40d7-e3a8-1fef-054968b26ce6@openvz.org> In-Reply-To: <9925d0ba-40d7-e3a8-1fef-054968b26ce6@openvz.org> From: Muchun Song Date: Sun, 22 May 2022 14:47:42 +0800 Message-ID: Subject: Re: [PATCH mm v2 7/9] memcg: enable accounting for large allocations in mem_cgroup_css_alloc To: Vasily Averin Cc: Andrew Morton , kernel@openvz.org, LKML , Linux Memory Management List , Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vlastimil Babka , Michal Hocko , Cgroups Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7F9EBA002A X-Stat-Signature: k66owago5g1jx8smrq18dcdcoa7x6mpk X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=2UtmFRcC; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1653202074-254835 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 22, 2022 at 12:38 AM Vasily Averin wrote: > > Creation of each memory cgroup allocates few huge objects in > mem_cgroup_css_alloc(). Its size exceeds the size of memory > accounted in common part of cgroup creation: > > common part: ~11Kb + 318 bytes percpu > memcg: ~17Kb + 4692 bytes percpu > > memory: > ------ > Allocs Alloc $1*$2 Sum Allocation > number size > -------------------------------------------- > 1 + 8192 8192 8192 (mem_cgroup_css_alloc+0x4a) 14 ~ 352 4928 13120 KERNFS > 1 + 2048 2048 15168 (mem_cgroup_css_alloc+0xdd) 1 1024 1024 16192 (alloc_shrinker_info+0x79) > 1 584 584 16776 (radix_tree_node_alloc.constprop.0+0x89) > 2 64 128 16904 (percpu_ref_init+0x6a) > 1 64 64 16968 (mem_cgroup_css_online+0x32) > > 1 = 3684 3684 3684 call_site=mem_cgroup_css_alloc+0x9e > 1 = 984 984 4668 call_site=mem_cgroup_css_alloc+0xfd > 2 12 24 4692 call_site=percpu_ref_init+0x23 > > '=' -- already accounted, > '+' -- to be accounted, > '~' -- partially accounted > > Accounting for this memory helps to avoid misuse inside memcg-limited > contianers. > > Signed-off-by: Vasily Averin Reviewed-by: Muchun Song