From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A09C433F5 for ; Wed, 9 Feb 2022 03:11:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9000F6B0071; Tue, 8 Feb 2022 22:11:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B06C6B0073; Tue, 8 Feb 2022 22:11:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 777E26B0074; Tue, 8 Feb 2022 22:11:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 651366B0071 for ; Tue, 8 Feb 2022 22:11:53 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1641F181CB2A3 for ; Wed, 9 Feb 2022 03:11:53 +0000 (UTC) X-FDA: 79121766906.27.1F7E30A Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf24.hostedemail.com (Postfix) with ESMTP id 10AD7180002 for ; Wed, 9 Feb 2022 03:11:51 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id y129so2214985ybe.7 for ; Tue, 08 Feb 2022 19:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rcCsadDpXwpknGfPPkPWLIbk/09KzmHWXbNkWCJsevs=; b=HU8zKWlAa7scJizxiEX/ClPazXcbT1Z5FePyLYQzWG+4h87V+SHOAj19aUa31z0i8E l3/TpZqecZOc3EMMoKICAu8V7MsbYoc1fIY4PlRacG4OBRRP7pPOLC6dxZwz/QaOl0Ha fMwtRFgMn+8/eRO+jwwzVcF6zw6UfVzxJER6rtCckT6WGtflc6BLiDaNNfKkhGrLkLNP BnmgwpiKJ+1USgLzjl9diYksT1QMvYd98MOpdlRIFojDYcNwn050UeBIo+Uj4U35tM24 T+Ggcqw+NzmLs7SvJidMXvc2bEGXkgDe/pn/Yy7WrG5gBk4OC9VzxwW49PUhWipwhI9t fEJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rcCsadDpXwpknGfPPkPWLIbk/09KzmHWXbNkWCJsevs=; b=wx01firdbUTITRVpDb5U+r0+5lKF+K9nze2MZVlIYYVZHxfnk+ZxjSgjM/ADlv98pz fUcfEcgj/S+KMijnWLUaIlTked26z4vXHgb2XyRM+UR7K5yNmZCedmvuxRapVuBk0yKO gMVsm5OATVk0SO8+zB380DSUTcJStBCe6hz7VucJQaK8gQ0Qn2U6iqiBAHP3xfZ6PfSC HO75Kl/gJOqe5H0Q2VzSYGyCSXd1nwRdx6s/iFIIelaeh5nozKUv4kufad1kC7vwsogC btQhklUBYKPnaZ/n3hZPjuZhRncO71Lo+fJ3nIK3SoovZdJK1mVLM1ZUjf9hqElMIVQ6 eOIA== X-Gm-Message-State: AOAM530YCu1YAgl9Qr1xD+E4/q+IJPb1+xE1qmL/uoIsPyrpZlhKJOuz v5lItrG5AhdlWeO0hKnKlFOdsNQyWb0rUXosuM0mO4/1cxwdlbY9 X-Google-Smtp-Source: ABdhPJwSE4A79+RXrYbv5onel70MR0QDCjRTgOI+znLH67lP5CIq7lZjA5UEWwHF7zFfTRlQejccjLdMOm5XK6yj4wM= X-Received: by 2002:a25:4d5:: with SMTP id 204mr357860ybe.485.1644376311165; Tue, 08 Feb 2022 19:11:51 -0800 (PST) MIME-Version: 1.0 References: <20220203171904.609984-1-willy@infradead.org> In-Reply-To: From: Muchun Song Date: Wed, 9 Feb 2022 11:11:15 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: Add pvmw_set_page() To: Matthew Wilcox Cc: Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=HU8zKWlA; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf24.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 10AD7180002 X-Stat-Signature: qokcngkqacscqru65y9ehg7jrjg9ewo3 X-HE-Tag: 1644376311-596703 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 8, 2022 at 10:49 PM Matthew Wilcox wrote: > > On Tue, Feb 08, 2022 at 04:04:32PM +0800, Muchun Song wrote: > > How about the name pvmw_set_pfn_from_page()? > > When I looked at your next patch, I'm feeling this helper > > is used to set up the pfn from a page instead of setting up > > the page. > > But it doesn't just set up the pfn, it also sets up the range and > the pgoff. > > I wonder if we wouldn't be better off with this pattern: > > DEFINE_PAGE_VMA_WALK(pvmw, page, vma, address, flags); The approach sounds good to me. How about the following names? DEFINE_PAGE_VMA_WALK_FROM_PAGE(pvmw, page, vma, address, flags); This is used for most users that want to walk the whole page. DEFINE_PAGE_VMA_WALK(pvmw, pfn, nr_pages, pgoff, vma, address, flags); This is used for users that have no struct page or the user like page_mapped_in_vma() which only wants to walk the part of compound page. Thanks. > > ... which wouldn't get used by KSM, but could be used by > most other callers. >