From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27FC7C433EF for ; Fri, 3 Dec 2021 07:44:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8301B6B0072; Fri, 3 Dec 2021 02:44:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DFAF6B0074; Fri, 3 Dec 2021 02:44:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CE596B0075; Fri, 3 Dec 2021 02:44:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 5F4406B0072 for ; Fri, 3 Dec 2021 02:44:28 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1B1E9886C1 for ; Fri, 3 Dec 2021 07:44:18 +0000 (UTC) X-FDA: 78875694996.31.58375B1 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf28.hostedemail.com (Postfix) with ESMTP id 272B7900009A for ; Fri, 3 Dec 2021 07:44:17 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id v64so6832547ybi.5 for ; Thu, 02 Dec 2021 23:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UAVL9gAJ9L8uH+kEA+xjZGKt7HfdI9ctRFtotrW3lBk=; b=ib9GmhM7RHt8aAYLVx/Kgn+4sCphD+hO/mq/WH0eps59vJyGA040zGmkt/I2f5wNQO q/7qoqL35jF7fImXFJzFCwzsCNAc2I/2epM3ycQjb1OdNc7cW6+emTFAKT5uXZuSTiiE LJTQR7ejxp7GMzSCTW5frYCpBvLB0VwVMRoEjogXzKQf5hbqpMZxwhYuOqxhHM5/S33k kllBkKI8wNTHL4/PmqMCMNyYqAyg9N8oVxDtKeNUMSpThIIoHhB/yWr5HYgDulgMHCpR UEzBcf7JpUqB73tkeKA+hxjkpNjuv9+FIlvPI9bVjLmrUecmIGuWNKniRrHNF5l0JR6K P+fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UAVL9gAJ9L8uH+kEA+xjZGKt7HfdI9ctRFtotrW3lBk=; b=7DACpIyZBGkqUcdc4sVxqI0fTNlF+TMv3uac8SbWRBGO6jI8Fc7s7Wxh/iYKbURbWP kDpKMiETY9KxFdvxKlD7FUo+ACQCbssDsCmW+UnFf4vhlEtc6CbryZJZE/1AnGS+oyO5 RHKISjB7GVFSJQeYTMwHS2yyB6Xf47kVPj50293+dw37rekdiZvKndzV08VYPWRwFBHM brYBidEuStTVXQ1ANQQ2dqsqScyAU644HYFz0XjfdIaYSWvXty6pD4Gb506GkGtADaqn 7YPoPsqZh4Xrc9YzSQkOH5zSFVA78dtRT1pBFXzIHyArw1SFURfEG8YZfGaBU346omXs qhUw== X-Gm-Message-State: AOAM531GhwSoCiL2lUB/T+Gk+F/z27d4gE7MLsVWwyP2Wv5hj9JhXjBu tUa2FbtLiXhxEjYyPFqsp1JjoGBqtVFlXhuvK7h9nQ== X-Google-Smtp-Source: ABdhPJyU7RtgdFpAiVz5xqahn/qyuv+79mBq3j9EZn5MJCyqHFBNnd+/EJH7t6ORkJIAzd+WWu3ypyX5expzKX/cRug= X-Received: by 2002:a25:d685:: with SMTP id n127mr20888122ybg.523.1638517456254; Thu, 02 Dec 2021 23:44:16 -0800 (PST) MIME-Version: 1.0 References: <20211203065647.2819707-1-keescook@chromium.org> In-Reply-To: <20211203065647.2819707-1-keescook@chromium.org> From: Muchun Song Date: Fri, 3 Dec 2021 15:43:37 +0800 Message-ID: Subject: Re: [PATCH] hugetlb/cgroup: Fix copy/paste array assignment To: Kees Cook Cc: Mina Almasry , Andrew Morton , Shakeel Butt , Mike Kravetz , LKML , Linux Memory Management List , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 272B7900009A X-Stat-Signature: 4d8htkx48f4oe6kdn1cdpra9a9388jmt Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=ib9GmhM7; spf=pass (imf28.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1638517457-890686 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 3, 2021 at 2:56 PM Kees Cook wrote: > > Fix mismatched array assignment, reported by an -Warray-bounds build: > > mm/hugetlb_cgroup.c: In function '__hugetlb_cgroup_file_legacy_init': > mm/hugetlb_cgroup.c:850:35: error: array subscript 8 is above array bounds of 'struct cftype[8]' [-Werror=array-bounds ] > 850 | cft = &h->cgroup_files_dfl[8]; > | ~~~~~~~~~~~~~~~~~~~^~~ > In file included from mm/hugetlb_cgroup.c:23: > ./include/linux/hugetlb.h:625:23: note: while referencing 'cgroup_files_dfl' > 625 | struct cftype cgroup_files_dfl[8]; > | ^~~~~~~~~~~~~~~~ > > Fixes: e45f4726bcad ("hugetlb: add hugetlb.*.numa_stat file") > Signed-off-by: Kees Cook Reviewed-by: Muchun Song Thanks.