From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E2FC55ABD for ; Wed, 11 Nov 2020 03:23:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 06F9F221F9 for ; Wed, 11 Nov 2020 03:23:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="JOosOqkx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06F9F221F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 293806B0036; Tue, 10 Nov 2020 22:23:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2438E6B005D; Tue, 10 Nov 2020 22:23:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E5526B0068; Tue, 10 Nov 2020 22:23:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id D80B86B0036 for ; Tue, 10 Nov 2020 22:23:00 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 85F713628 for ; Wed, 11 Nov 2020 03:23:00 +0000 (UTC) X-FDA: 77470690920.20.snow50_4a0a172272fa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 63D18180C07A3 for ; Wed, 11 Nov 2020 03:23:00 +0000 (UTC) X-HE-Tag: snow50_4a0a172272fa X-Filterd-Recvd-Size: 4692 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 03:22:59 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id r186so570281pgr.0 for ; Tue, 10 Nov 2020 19:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B+INKkjIDZT3D1i6UtnttTDRAE8G2FcYmKLz7U0uR9c=; b=JOosOqkxOcZllws4ecN2id5Fe6UwVCj2cPtfVf0pyLIXCSFSSvTSZeGKT3fq/ezVt5 KgcY8zcYBIplyi9d9oQ/9QTFuB2YDgE6RmMNJ8o7RYYUguheYDhNU3hp0JNlxNdJtqFz Gexrvs9uU78mNQL9gd3oe+jELMbHQBqZNiY9PEkwkL1dzN7fqCNqK4G8WgiA5lOY6M/Q 7GJpfITLytNdp0b1BJUPFd+O23TuN9OryMFMmHWa5BwHsNoWQv9FLDU7JgIUMPZakIW8 VZ+6zTHk1hCMqR6GnLIDAlID9LUFMXPI6okp8bEw3p+mDz8KqluLN7dU6g3oQNY7CmrN /mlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B+INKkjIDZT3D1i6UtnttTDRAE8G2FcYmKLz7U0uR9c=; b=ZDEWhDbU0wYhSZhx9Ew2BUNEOaDV5QwyrfBWAKoAJHfw9+HmJYHlG5NzeuDJKukuYJ RnrMpiKnttYa1fVVPxbLLC+lURw77/L1BkWmsCNN9gbEBg/3ciXwD84PA2wyoEC3fthR 7uguRvT8M8+BMQTj4sEbXwE8I0QdHJWQ6y96EjlJzVYbHBLf5x04viviAUINM23VX9yC quvXt3ytX5USU68km+h1gn99105PdEwSZ3zQ39G9BhR7UiMDPlUG0Gpgg3UV95BUhZa5 bhWw9SevdnVYIBVnjMCRh52viK9pYgeCQDgYmjqp0+41OsAE1RA7zrwa18dGzEJX8f1c JCZQ== X-Gm-Message-State: AOAM530Fqah+56Ujah8HZL/cgZRu/XrlT7cK3w1zfRNY70YTwEYOlL+r oyjLN9s14NkN/tM3tWDnfNf5x2GePfuSr69P3pEw1w== X-Google-Smtp-Source: ABdhPJzGT8N4NW+RVlPTeogdZpkCaeOCNCxDbSreds3iADW9boMPn78RQuijNHX62TFpNpPq2MucJDiBiXFCUcLBotI= X-Received: by 2002:aa7:9095:0:b029:164:75c4:5d15 with SMTP id i21-20020aa790950000b029016475c45d15mr21053662pfa.49.1605064978215; Tue, 10 Nov 2020 19:22:58 -0800 (PST) MIME-Version: 1.0 References: <20201108141113.65450-1-songmuchun@bytedance.com> <20201108141113.65450-5-songmuchun@bytedance.com> <20201109164825.GA17356@linux> <877a4620-fa5c-c5b5-8a42-fdd67a869a38@oracle.com> In-Reply-To: <877a4620-fa5c-c5b5-8a42-fdd67a869a38@oracle.com> From: Muchun Song Date: Wed, 11 Nov 2020 11:22:22 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v3 04/21] mm/hugetlb: Introduce nr_free_vmemmap_pages in the struct hstate To: Mike Kravetz Cc: Oscar Salvador , Jonathan Corbet , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 3:40 AM Mike Kravetz wrote: > > On 11/9/20 6:42 PM, Muchun Song wrote: > > On Tue, Nov 10, 2020 at 12:48 AM Oscar Salvador wrote: > >> > >> On Sun, Nov 08, 2020 at 10:10:56PM +0800, Muchun Song wrote: > >> > >> Unrelated to this patch but related in general, I am not sure about Mike but > >> would it be cleaner to move all the vmemmap functions to hugetlb_vmemmap.c? > >> hugetlb code is quite tricky, so I am not sure about stuffing more code > >> in there. > >> > > > > I also think that you are right, moving all the vmemmap functions to > > hugetlb_vmemmap.c may make the code cleaner. > > > > Hi Mike, what's your opinion? > > I would be happy to see this in a separate file. As Oscar mentions, the > hugetlb.c file/code is already somethat difficult to read and understand. Got it. I will do this. Thanks. > -- > Mike Kravetz -- Yours, Muchun