From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BE4C433DB for ; Sat, 16 Jan 2021 04:37:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B505F221ED for ; Sat, 16 Jan 2021 04:37:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B505F221ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC6A38D01FF; Fri, 15 Jan 2021 23:37:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D76AF6B009C; Fri, 15 Jan 2021 23:37:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C66338D01FF; Fri, 15 Jan 2021 23:37:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id AE0B56B009A for ; Fri, 15 Jan 2021 23:37:39 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5B61A180AD807 for ; Sat, 16 Jan 2021 04:37:39 +0000 (UTC) X-FDA: 77710379838.05.angle43_120643e27535 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 3BD2A18041630 for ; Sat, 16 Jan 2021 04:37:39 +0000 (UTC) X-HE-Tag: angle43_120643e27535 X-Filterd-Recvd-Size: 6957 Received: from smtprelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Jan 2021 04:37:37 +0000 (UTC) Received: from forelay.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 450F1837F24C for ; Sat, 16 Jan 2021 04:37:37 +0000 (UTC) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 306E012D1 for ; Sat, 16 Jan 2021 04:37:37 +0000 (UTC) X-FDA: 77710379754.09.train93_4c0d75127535 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 17ABC180AD807 for ; Sat, 16 Jan 2021 04:37:37 +0000 (UTC) X-HE-Tag: train93_4c0d75127535 X-Filterd-Recvd-Size: 5077 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Jan 2021 04:37:36 +0000 (UTC) Received: by mail-pf1-f174.google.com with SMTP id x126so6786274pfc.7 for ; Fri, 15 Jan 2021 20:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/GEsUv4XPzp2MAebK25e+QPQSWvvym5bBrV9gTaI2uU=; b=PTL44zbSHBr+2NKLTgq1CeR+ITIvn+69xRddTN/3yMQBqqTd2J7ngNdloqZ5X5W4Vf dogd6iuy3sQm5uR7tmmrnHy6yipi2qhuAUFiSjBlVqklxz3CbOMROHJkpEQs0EmITT9f 0zIbIDqDPrzGz46adV8ehn+C++1vk0dKpdtA8fBEuqiobmMsxqPuXv5b/7EHxga5D42C 5itiiaPEs8T4Ed7lgAYHCM9gM0SSp/Qnb5IN+Fak3hEAEKnRoDsDMSrdZzDagVPfP0AD KenkTFc/wkSfwL0KiplKVpH1i0BIDFKVL2gBAhrYARLmxCrbV12syj/38oJTnKbFek+U DTkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/GEsUv4XPzp2MAebK25e+QPQSWvvym5bBrV9gTaI2uU=; b=jsiZkUu9w/H1zx/622Xwc8vqlq3KbM4CE+6Qd3IU+EypQJnhjVJUuw1x/wQD/Dlugc zOdilv5JvfvgE8M1gQVoooKhZ3O/tjhpHME1EZvFrMKj9QVTpkKKusq5gxMHqduRF3lv jza67w12+s+cDA+38KCGOYu4oaS6mbDqctqs4Kh56QcSMaEPBW0qQpT2QW5bgjXEGfxc lw/qlwnj5xlyt9jz1WB2A0caDesCbm3+kkZdR/qlTbAmcuTiiK5CX58evBw7oH2DLNHw ewAqCSxMVl2h/UjEEPSEoVe878Z8+IsMAHxO9PUhnGhSKqUHiL5FWri6FQg4IxSeeaXy 0JnQ== X-Gm-Message-State: AOAM532xqm8C8xuhBkHfQXIpUzozgo8D6/MdMxD/Kx/ejiBnLHPGMpFa 0PI95efR0+D2zHLalu4sgbbHQIJjDfMFAL5acJEE6A== X-Google-Smtp-Source: ABdhPJw6auAbwUc0+HRs4bF+JukQbPjxez5J6xRY1baJNaOgs4+OwLuDT63KPd5jpF5UHKrsdydTkQPbtaqmosUt+0E= X-Received: by 2002:a63:480f:: with SMTP id v15mr15925182pga.341.1610771855128; Fri, 15 Jan 2021 20:37:35 -0800 (PST) MIME-Version: 1.0 References: <20210116003105.182918-1-mike.kravetz@oracle.com> <20210116003105.182918-3-mike.kravetz@oracle.com> <20210116042416.GA2260413@casper.infradead.org> In-Reply-To: <20210116042416.GA2260413@casper.infradead.org> From: Muchun Song Date: Sat, 16 Jan 2021 12:36:55 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 2/5] hugetlb: convert page_huge_active() to HP_Migratable flag To: Matthew Wilcox , Mike Kravetz Cc: LKML , Linux Memory Management List , Michal Hocko , Naoya Horiguchi , David Hildenbrand , Oscar Salvador , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 16, 2021 at 12:26 PM Matthew Wilcox wrote: > > On Fri, Jan 15, 2021 at 04:31:02PM -0800, Mike Kravetz wrote: > > +++ b/fs/hugetlbfs/inode.c > > @@ -735,7 +735,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > > > > mutex_unlock(&hugetlb_fault_mutex_table[hash]); > > > > - set_page_huge_active(page); > > + hugetlb_set_page_flag(page, HP_Migratable); > > I had understood the request to be more like ... > > SetHPageMigratable(page); > > > +++ b/include/linux/hugetlb.h > > @@ -480,9 +480,13 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > > * HP_Restore_Reserve - Set when a hugetlb page consumes a reservation at > > * allocation time. Cleared when page is fully instantiated. Free > > * routine checks flag to restore a reservation on error paths. > > + * HP_Migratable - Set after a newly allocated page is added to the page > > + * cache and/or page tables. Indicates the page is a candidate for > > + * migration. > > */ > > enum hugetlb_page_flags { > > HP_Restore_Reserve = 0, > > + HP_Migratable, > > }; > > and name these HPG_restore_reserve and HPG_migratable > > and generate the calls to hugetlb_set_page_flag etc from macros, eg: > > #define TESTHPAGEFLAG(uname, lname) \ > static __always_inline bool HPage##uname(struct page *page) \ > { return test_bit(HPG_##lname, &page->private); } > ... > #define HPAGEFLAG(uname, lname) \ > TESTHPAGEFLAG(uname, lname) \ > SETHPAGEFLAG(uname, lname) \ > CLEARHPAGEFLAG(uname, lname) > > HPAGEFLAG(RestoreReserve, restore_reserve) > HPAGEFLAG(Migratable, migratable) > > just to mirror page-flags.h more closely. I prefer this suggestion. I also made the same suggestion in the previous RFC version.