From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D87C433DB for ; Mon, 28 Dec 2020 05:41:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F1BA207CC for ; Mon, 28 Dec 2020 05:41:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F1BA207CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 854068D0005; Mon, 28 Dec 2020 00:41:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 805538D0003; Mon, 28 Dec 2020 00:41:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 740F68D0005; Mon, 28 Dec 2020 00:41:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 604698D0003 for ; Mon, 28 Dec 2020 00:41:36 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1CEBD362A for ; Mon, 28 Dec 2020 05:41:36 +0000 (UTC) X-FDA: 77641593792.08.fly44_6006ec527491 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 05EC51819E76C for ; Mon, 28 Dec 2020 05:41:36 +0000 (UTC) X-HE-Tag: fly44_6006ec527491 X-Filterd-Recvd-Size: 4627 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Dec 2020 05:41:34 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id s21so5730547pfu.13 for ; Sun, 27 Dec 2020 21:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KdC1UTvK3n3P54mNUc/2MJ7F1GE6qXAssfNlwctQq5A=; b=VgitC5bh7LY0I34mSYBnKJCn+g46m7lfhWc+52EAtE4Jtpn1zF5sEmiOiHFhniymQu 75MVFKMKs2DbndOSgVA22lLlgtsoO+s8idjhSQU0xCV0oAzbeoMRXt68n0RAtd9hFkFV TKkOVCLHYeXHo3OJaDiiHCJpKpos4gOwZSSh4g0eeAdNHb2wU7CBUTdJfv38wDQqlWo4 b5gpSyPsRZ4xY+KUA4FLZryRruATzIIMSVW6aWoFBnS/G/Bws41pXp3vetiEl78tNJiD +5GyYwHlJPG5buRTpVXncrX6sgDfBBj6k77xNvtNdNfDdAIIFMI8uhol7rByABB7Irvp 7FIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KdC1UTvK3n3P54mNUc/2MJ7F1GE6qXAssfNlwctQq5A=; b=I0k+Rfx7NWBi/p2JCTa67KoOufy5fBkI1r66lnuZ70PQRpTDsleKvlNffC4mcrf5tF LfXdHKVnK8Kjq60aSBuODqQJCjuduzaLLtkpWGKYYH0SPxn5nFqlx7+ICriPK/OiScS2 MGdUwdG1O8Rq1rOOTaUhZU7T6FZHBcUKAMT/TaO1HpXCSsbPNM3j4CazwQX93xdP52hV O9QbhY99wn9rnTycs2Xo5HnHTjTQ+2foLMwZvIgExUt50h73NLSwG1ZkmgjYRk55kQQ/ lX2rZv3Z7Q874nGyXywmIJeMl62KNa5j/lvEU6GFkukULaKJrVliP4tW0aW0acFMV9P0 qQuw== X-Gm-Message-State: AOAM531zcld6Kpm3QrPiVHrw/Xk/UxcPcT9hN2VayJKLSinOx7B+jxIL ujK4zUw8FiomwqRbw67HO2mWuY9LDFlzblJTejbi8A== X-Google-Smtp-Source: ABdhPJwXVa9em2MWeoou1jv+F1kF93xbWKqRqnIRiQYiWDC7Q/2z2DBySCmNGhGBDwiw46Gn2gDqglDyT7Aw6y+4gWs= X-Received: by 2002:a63:480f:: with SMTP id v15mr28753074pga.341.1609134093727; Sun, 27 Dec 2020 21:41:33 -0800 (PST) MIME-Version: 1.0 References: <20201227181310.3235210-1-shakeelb@google.com> In-Reply-To: <20201227181310.3235210-1-shakeelb@google.com> From: Muchun Song Date: Mon, 28 Dec 2020 13:40:54 +0800 Message-ID: Subject: Re: [External] [PATCH 1/2] mm: memcg: fix memcg file_dirty numa stat To: Shakeel Butt Cc: Naoya Horiguchi , Andrew Morton , "Kirill A . Shutemov" , Johannes Weiner , Roman Gushchin , Cgroups , Linux Memory Management List , LKML , linux- stable Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 28, 2020 at 2:13 AM Shakeel Butt wrote: > > The kernel updates the per-node NR_FILE_DIRTY stats on page migration > but not the memcg numa stats. That was not an issue until recently the > commit 5f9a4f4a7096 ("mm: memcontrol: add the missing numa_stat interface > for cgroup v2") exposed numa stats for the memcg. So fixing the > file_dirty per-memcg numa stat. > > Fixes: 5f9a4f4a7096 ("mm: memcontrol: add the missing numa_stat interface for cgroup v2") Thanks for catching this problem. Reviewed-by: Muchun Song > Signed-off-by: Shakeel Butt > Cc: > --- > mm/migrate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index ee5e612b4cd8..613794f6a433 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -500,9 +500,9 @@ int migrate_page_move_mapping(struct address_space *mapping, > __inc_lruvec_state(new_lruvec, NR_SHMEM); > } > if (dirty && mapping_can_writeback(mapping)) { > - __dec_node_state(oldzone->zone_pgdat, NR_FILE_DIRTY); > + __dec_lruvec_state(old_lruvec, NR_FILE_DIRTY); > __dec_zone_state(oldzone, NR_ZONE_WRITE_PENDING); > - __inc_node_state(newzone->zone_pgdat, NR_FILE_DIRTY); > + __inc_lruvec_state(new_lruvec, NR_FILE_DIRTY); > __inc_zone_state(newzone, NR_ZONE_WRITE_PENDING); > } > } > -- > 2.29.2.729.g45daf8777d-goog > -- Yours, Muchun