From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C14C433FE for ; Mon, 28 Mar 2022 15:51:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 286358D0002; Mon, 28 Mar 2022 11:51:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2342C8D0001; Mon, 28 Mar 2022 11:51:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FC978D0002; Mon, 28 Mar 2022 11:51:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 002A48D0001 for ; Mon, 28 Mar 2022 11:51:50 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id A85EE81393 for ; Mon, 28 Mar 2022 15:51:50 +0000 (UTC) X-FDA: 79294235580.13.EBA91A0 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf27.hostedemail.com (Postfix) with ESMTP id 1B04B40043 for ; Mon, 28 Mar 2022 15:51:47 +0000 (UTC) Received: by mail-yb1-f169.google.com with SMTP id j2so26850224ybu.0 for ; Mon, 28 Mar 2022 08:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Tin/HUePoSP0WPbVMV76tjgbiayi43biSRQ1KKujeeI=; b=VNxDfv9rBJgC22+4VxJ3bPmC9grmNM3f51riUtLc6J4fSzEVRfhWmKJJCdhU3HDLC+ Gdf5Whhi6H3kM3ibXjkSniuU7P0XsuE2QGWHwUCBXOUKf6+R2REHdtB4ezUD2VpcgUTx jSFLlHlJSBqlLuCd7PpKt1YUkEsY1wkgJXrN3+dp5YFBliRbebGpRrQMSmgQmONdY9Jw I7wIhW2raJQdAuRFLQfTwFYrek37UVs+1mXAlHCIRHKxXfzS6DLzgpvV2wfByHJcyZ5b T+oOCLVSOMlb8boGl/pqF6PTYSUGgAAYxABlEsp7juBrPqWqXrhj85CPml95zXhbl1TZ G4kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tin/HUePoSP0WPbVMV76tjgbiayi43biSRQ1KKujeeI=; b=1tNddN0uzVpvP6oO1FUyclX7B7qfwFHF1Js1elkzzhgNxDklIrqMpX4xsbk3Cvb+Mj 6XdPxA98jvPwxrrhZYg8bKhttDPEyiJdGmiVKSamU+gzbWmiFSlfVWVq6oGcq0HlC5gR e5tMsPCRN5x+f545R6UAMrspYzmfl7daBHh82ZfbwijADTDOMPnfh0HDGFrM7KiLk5xx ACdJSVvX03NUHR3spRYgg6UBy7Vvi1toK5SCZGbotuwTEIZNDHxS5VHp2N58NN+wuRts o20hFzKbgaS+3bjun+FZo66HHhxYQ7JZ4CQ0UHkz89e2sRZZgBM7OFme03lcSEfxZkOc k3vA== X-Gm-Message-State: AOAM5322MfEvqbZLIlIjcjuXTqKK7l1XWPr78nFhH9uTUkoH94IzWNiE rbO1SVsQ0onS2GH6Ys+lu8Q62UEhtg4H8dvjWPEMRA== X-Google-Smtp-Source: ABdhPJyilVVQ5cCmaPeT9S7msms3MRvaqGlzWNB4u+LOLVUKuZ8HqSE6nFMjwXJcsHGCSnelBrifFpRBN9ozY7Pghww= X-Received: by 2002:a05:6902:120c:b0:639:86b2:76ba with SMTP id s12-20020a056902120c00b0063986b276bamr19563008ybu.254.1648482707142; Mon, 28 Mar 2022 08:51:47 -0700 (PDT) MIME-Version: 1.0 References: <20220328132843.16624-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Mon, 28 Mar 2022 23:51:11 +0800 Message-ID: Subject: Re: [PATCH v2] mm: kfence: fix objcgs vector allocation To: Marco Elver Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev , Linux Memory Management List , LKML , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: bb58xph9jjrq3655dmj5773psawijasa Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=VNxDfv9r; spf=pass (imf27.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1B04B40043 X-HE-Tag: 1648482707-513632 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 28, 2022 at 11:43 PM Marco Elver wrote: > > On Mon, 28 Mar 2022 at 15:28, Muchun Song wrote: > > > > If the kfence object is allocated to be used for objects vector, then > > this slot of the pool eventually being occupied permanently since > > the vector is never freed. The solutions could be 1) freeing vector > > when the kfence object is freed or 2) allocating all vectors statically. > > Since the memory consumption of object vectors is low, it is better to > > chose 2) to fix the issue and it is also can reduce overhead of vectors > > allocating in the future. > > > > Fixes: d3fb45f370d9 ("mm, kfence: insert KFENCE hooks for SLAB") > > Signed-off-by: Muchun Song > > Reviewed-by: Marco Elver Thanks. > > Btw, how did you test this? > Yeah. No problem.