From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626DEC4361B for ; Wed, 16 Dec 2020 13:52:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C92E1233A0 for ; Wed, 16 Dec 2020 13:52:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C92E1233A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E42F96B0036; Wed, 16 Dec 2020 08:52:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF1CA6B005D; Wed, 16 Dec 2020 08:52:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE0816B006C; Wed, 16 Dec 2020 08:52:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id B40B56B0036 for ; Wed, 16 Dec 2020 08:52:21 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7D4228249980 for ; Wed, 16 Dec 2020 13:52:21 +0000 (UTC) X-FDA: 77599284882.04.camp28_5e082762742c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 5E1FC800CDAA for ; Wed, 16 Dec 2020 13:52:21 +0000 (UTC) X-HE-Tag: camp28_5e082762742c X-Filterd-Recvd-Size: 4823 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Dec 2020 13:52:20 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id j13so1644052pjz.3 for ; Wed, 16 Dec 2020 05:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MByjt13D8dTyrL9LXVO8Wl4qrEzL2nVUzZj2LIZjinw=; b=xEkeeDNDwEctBCEW9+sGNx6t6X+u7em43nG+lu0z1gifW1MLYSuSRYohoEK1GimBgo 5ysElzKFdJdmrlfMoN8ewUO4Mbc2vtErLMpfDT2aRJ5HH4ehchKTb570hxvzmaG2tFbB DywlXF+1AZePbf8VAlGJzwcs8HhJoSiXSJQEbUnZlKp23eQqeDeujY3ojoCn0ybg7s9W fzzYP908pt2emtJw6hmoNyAI6I5AAWl8zqcAXweTum3yZgh5QXY51iqO+k8NTADI2Hc5 dJNmh3EeznSKLV1uleZNGocmGHCFSDOofG/skh/EHGrVyRmuqGtje5nrrcR/sZu+CDEl Yj8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MByjt13D8dTyrL9LXVO8Wl4qrEzL2nVUzZj2LIZjinw=; b=lCOO713J0m71B7iSiMy2tu/Fe4gOq6rs/FvpPpNGPYhiJoETp8GFe8p0x4ftBxeZsS uxVaRECooazMUd0BXZl1ycoKj7Uu1QjVaIAciTUYg7RI5DfHFrvgDmkpNyn2jozG5dGL 93FDWjy9oJj2ycRMcQcrl7x4rHyhTkIod/jNDb9i+8qDCxtlZ4uUP2+3bnow025ORnlF jNvcjEBZudvbubKVHTBBJewve35Q+8VGtTFO+3A95aVqwGTES6no8L/6NTezIY2TSuI5 yF3eoZSfHDsaCGX2hy89bksWrWZABdG6glZ/47abhRNiN9I8VxjBOlKenNQTEPVQLNHB HshA== X-Gm-Message-State: AOAM530A9PZZWZq/G5mQvXwAffhoL/41jwQ/wXmIdCiVCOsnHb7wt4gF 35/BXP9K0gC/1ETFuHXegEeCtwY0DNjTg3xdGFsDzw== X-Google-Smtp-Source: ABdhPJxx5e3AsxCiCIXYZp2OHM5MtCHWVOP/WNUpVGJcXgHZNqGgFqJxEOwTYxQekrQT8Wj7ZuvNdf7qNno8pHo21lo= X-Received: by 2002:a17:90a:5405:: with SMTP id z5mr3286702pjh.13.1608126739730; Wed, 16 Dec 2020 05:52:19 -0800 (PST) MIME-Version: 1.0 References: <20201213154534.54826-1-songmuchun@bytedance.com> <20201213154534.54826-7-songmuchun@bytedance.com> <20201216132847.GB29394@linux> In-Reply-To: <20201216132847.GB29394@linux> From: Muchun Song Date: Wed, 16 Dec 2020 21:51:43 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v9 06/11] mm/hugetlb: Set the PageHWPoison to the raw error page To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 16, 2020 at 9:28 PM Oscar Salvador wrote: > > On Sun, Dec 13, 2020 at 11:45:29PM +0800, Muchun Song wrote: > > Because we reuse the first tail vmemmap page frame and remap it > > with read-only, we cannot set the PageHWPosion on a tail page. > > So we can use the head[4].private to record the real error page > > index and set the raw error page PageHWPoison later. > > Maybe the following is better? > > "Since the first page of tail page structs is remapped read-only, > we cannot modify any tail struct page, and so we cannot set > the HWPoison flag on a tail page. > We can make use of head[4].private to record the real hwpoisoned > page index. > Right before freeing the page the real raw page will be retrieved > and marked as HWPoison. > " > > I think it is slighly clearer, but whatever. Thank you. > > > Signed-off-by: Muchun Song > > I do not quite like the name hwpoison_subpage_deliver, but I cannot > come up with a better one myself, so: > > Reviewed-by: Oscar Salvador Thanks for your review. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun