From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C5DC47082 for ; Sat, 5 Jun 2021 12:50:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB641613FA for ; Sat, 5 Jun 2021 12:50:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB641613FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E4C266B0036; Sat, 5 Jun 2021 08:50:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD58E6B006C; Sat, 5 Jun 2021 08:50:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4E626B006E; Sat, 5 Jun 2021 08:50:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 8EC3F6B0036 for ; Sat, 5 Jun 2021 08:50:37 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 16F958249980 for ; Sat, 5 Jun 2021 12:50:37 +0000 (UTC) X-FDA: 78219654114.39.284D651 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 4CA66A0000FA for ; Sat, 5 Jun 2021 12:50:35 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id z3-20020a17090a3983b029016bc232e40bso4018425pjb.4 for ; Sat, 05 Jun 2021 05:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dlZfc7pEeqreOo3MXeMdmrALgm1ljXYzN4kf8mOS59o=; b=yCRfCAR5vsxQG9DA6xdvi+LqB9/VQQ+4FWIH7wCHUEfknWrosW4+N9uGkNu0CiGTxo AXf7/RUX1ajcYDzPKnubtPrwezj5ATVM3s+jBMQAhsEl3bgTxkkSte4xN41q8JA73lJb 37fq4CHkGKfOjMOhiQYarsoNBQtJrgekB9uAv+o2HtG+N5o5uZpp5pjTvVCETG43Nm+k ACBqTIYvsoss84XDeYatEG8kOS8Ljy+EhJjHR67kYW/rBfQRAFHOVMbnwcKYE9+RvCM0 lTRmSbfpA4rDoFeSs49ftv9jlHCLMhQrkxjCjasaMYz4J7MOkiVGQZ3aZ0n9FpOMavMg SBfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dlZfc7pEeqreOo3MXeMdmrALgm1ljXYzN4kf8mOS59o=; b=L/iEUAK5rtkjV241ikm7jRrrxbBktCuxtIKtW24JMDzZRWqF2g0+K2A1f/ILfGy2Ok rAIym29PhW++1hyuC3OS1PlIpgW1iyfM79F4FXHGa81R3OarE/ua0m7dngvp/ESRQnPP 2pm/w3jfNnBSJQlUyaxYsVhJfaWVxtQ93g/NSs/55TudAPqyt52BpJ4tXHycHobe0wuY WU/C3GBKaqhpePT0MQmG04Cu6bGgKDevPHOL65nuotr0cd+WekhLnZytK5IJWVc1cOi1 zTmgas/cGEMigl3l3GqHJB/XNOidJUV9lHubRRS9dk2g1mlk9JUnIBGsYVScOCKc55Z0 8byA== X-Gm-Message-State: AOAM531OFHqdRyJlhmpyhlUgZqA05a4WOWrmJNHrQVj1d34ThTtnb+HW UgRrfI1i0JrDBouMXvaGsy1n6KnTaNLFZtmcT2Y46w== X-Google-Smtp-Source: ABdhPJx849ceFnSkjnMEorauDXxs4AidxZAumfgXjsh+BeciFeCvOxH07RG/QxLx32ifGFn1lMzmJWl43Vweys84ICQ= X-Received: by 2002:a17:90b:4c8c:: with SMTP id my12mr10423837pjb.13.1622897434869; Sat, 05 Jun 2021 05:50:34 -0700 (PDT) MIME-Version: 1.0 References: <1fd32aad-c99d-e89a-cdb1-05843f568f0c@oracle.com> <20210605010626.1459873-1-almasrymina@google.com> In-Reply-To: <20210605010626.1459873-1-almasrymina@google.com> From: Muchun Song Date: Sat, 5 Jun 2021 20:49:58 +0800 Message-ID: Subject: Re: [External] [PATCH] mm, hugetlb: fix allocation error check and copy func name To: Mina Almasry Cc: Linux Memory Management List , Mike Kravetz , Andrew Morton , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4CA66A0000FA X-Stat-Signature: togsmehrzr9qck58fnx9zr9o7jesuz5h Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=yCRfCAR5; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1622897435-266133 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 5, 2021 at 9:07 AM Mina Almasry wrote: > > The alloc_huge_page_vma() doesn't return error pointers, it returns > NULL. > > There is an existing migrate_page_copy() which not only copies the page > contents, but also page state/metadata. People could get confused that > 'migrate_page_copy' and 'migrate_copy_huge_page' do not have the same > functionality. Rename to 'copy_huge_page()' to make it less likely > folks get confused. > > Fixes: 6a0badc266df ("mm, hugetlb: fix racy resv_huge_pages underflow on > UFFDIO_COPY") I think the commit id is not stable. So this really should squash the commit of "mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY". But anyway, Reviewed-by: Muchun Song > > Signed-off-by: Mina Almasry > Cc: linux-mm@kvack.org > Cc: Mike Kravetz > Cc: Andrew Morton > Cc: linux-kernel@vger.kernel.org