From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D5EC433F5 for ; Wed, 22 Dec 2021 05:50:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B99C56B0072; Wed, 22 Dec 2021 00:50:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B49686B0073; Wed, 22 Dec 2021 00:50:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A11906B0074; Wed, 22 Dec 2021 00:50:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 90F856B0072 for ; Wed, 22 Dec 2021 00:50:40 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 41902884B3 for ; Wed, 22 Dec 2021 05:50:40 +0000 (UTC) X-FDA: 78944355840.28.B28255D Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 2C443A0019 for ; Wed, 22 Dec 2021 05:50:30 +0000 (UTC) Received: by mail-yb1-f172.google.com with SMTP id e136so3329517ybc.4 for ; Tue, 21 Dec 2021 21:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LOCm/oJBsq2ZwSQorZrJi2VqFNi1hqeL0TWzmb2Fnv8=; b=mi//nob8VYTI3rBiDGoqlMGRzwjv1GQs5VJn7Uib8o9FXpj1YUXjvRadOWukVUY8RM r2MRnM1l9SlVXFL/+5HWUgAGayqIcsuPif2wNKrd8Fh+gj3X+RaSdEaKW5FJX68FIZ6+ eZRp43PV8byAfFHm5yfi9EXNzPMfNcmkQP0O/VBRAxBqh0H9y+7YhOI6M5GYju3j2KrX CJ1lb050ll9Z+by701E6IB50ZfHb5+ikg1/k/9xo39Xm++hb5SfRODa8cnEyNI4revqT m/pGW0ceW6I9md8QvI828pw+G21xCGvBHE4IqhaKpZTSi2wO/ZVGyMSLk22b4XZJAZkA wHXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LOCm/oJBsq2ZwSQorZrJi2VqFNi1hqeL0TWzmb2Fnv8=; b=ypNmbVCVs9AFAFOYsixrqYfVAf2cIAAcDSKDimYwoMAh2i9Mdamae3SrdnPniEYZzT Dmt43Q7mXEPLWjLp58IWYSosV+gevjliBthkTRJ89NR7Fxp/2gh2dU0V3qlTOrLNxmVj nlGn4QlBnbE/xVYShYAH2ytUkQ2oQgJgbQSppH+KPwoPkSACqLwpf3O4am2E0n2NPKuS pro0EdrXhSkBoTucLAUOaoI3Nzam8F6WX65xJI3ksDsgQiM0UVS1yC4LDwfZLvmabPSY XLEYqEEzxiiNfYCxZB7Lu7AwClVzmRbR08Way3ke1kENC1b+Ymt/7IdmQf/TStHfOk+G w//w== X-Gm-Message-State: AOAM532pddcB7mWjZ3e7vjC5uFPRCGLWCD3pGM+3aShFRDjmERemBDbv +JNTMPrFhcVh+v+Xdsq1bGrAIhHMjjPksRmQf0n5rg== X-Google-Smtp-Source: ABdhPJz5Um4Ayt8ywUbOfrNvufZSGWpaW9Dec3TzjHbSNi4lJFZi/fWE1/rjkRit0FjkuQf5cHWmW0LWkhj016tYOFw= X-Received: by 2002:a25:b04:: with SMTP id 4mr2291276ybl.317.1640152237892; Tue, 21 Dec 2021 21:50:37 -0800 (PST) MIME-Version: 1.0 References: <20211222052457.1960701-1-shakeelb@google.com> In-Reply-To: <20211222052457.1960701-1-shakeelb@google.com> From: Muchun Song Date: Wed, 22 Dec 2021 13:50:01 +0800 Message-ID: Subject: Re: [PATCH v2] memcg: add per-memcg vmalloc stat To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2C443A0019 X-Stat-Signature: spw5zet43ou66a7p89mzyo3gncisr118 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="mi//nob8"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam11 X-HE-Tag: 1640152230-491228 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 22, 2021 at 1:25 PM Shakeel Butt wrote: > [...] > @@ -2626,6 +2627,9 @@ static void __vunmap(const void *addr, int deallocate_pages) > unsigned int page_order = vm_area_page_order(area); > int i; > > + mod_memcg_page_state(area->pages[0], MEMCG_VMALLOC, > + -(int)area->nr_pages); The cast can go away since the type of 3rd parameter of mod_memcg_page_state() is int but not long. I suggest to remove it. Anyway Reviewed-by: Muchun Song Thanks.