From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6E7C433FE for ; Thu, 11 Nov 2021 03:38:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D3126152A for ; Thu, 11 Nov 2021 03:38:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D3126152A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9A5FC6B00BD; Wed, 10 Nov 2021 22:38:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 956166B00BF; Wed, 10 Nov 2021 22:38:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8465E6B00C0; Wed, 10 Nov 2021 22:38:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 73E9D6B00BD for ; Wed, 10 Nov 2021 22:38:16 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1B2A818077353 for ; Thu, 11 Nov 2021 03:38:16 +0000 (UTC) X-FDA: 78795241392.18.E752A4C Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf27.hostedemail.com (Postfix) with ESMTP id 6B76A70000B9 for ; Thu, 11 Nov 2021 03:38:13 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id u60so11677532ybi.9 for ; Wed, 10 Nov 2021 19:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yOsFvx3uBmNrzTbP+yFE5JKWjrB+4rqD5uI1hcAhx6E=; b=QCAinz1h8etTsGUK/7abyyo7bFt7h+bw3B1DdXB6u15ssBnB5HPur4a/hTbQ4ZQtSn PWHhz8bYwu9+3Wg1nrtkaKbwV6u14PGbek5nfjfYdJmcJdimBhR/dZ6dwq8GcCgOXtHc WZMs2I3Ed7202wgRqEwk69c8Dqiqiv6gbOzCkgDpa2zoHOryzo+kjLUtXF0t8rTBPwmy rq5dwKYG1KOXH+IKXQSYdtuqJezL3JBMRoyh8t17jA7uZu6MviIqzUdNE1nRtQWc8tv0 eOMSx3qgKrZqbwOQoVR0yKpkbul+u+MvYPLQkH/Cfduo8gTShi6ArtWbx2ldJOz0oGB/ pT/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yOsFvx3uBmNrzTbP+yFE5JKWjrB+4rqD5uI1hcAhx6E=; b=EVj8XNvOOdo48t/Llutcs4D/YfSogLeZxyjs4Yzi6RwLfxAt1LPMTduD976u6TyZ5q iosj32q2w55mF7xkgZVlioELELmq1SeKeTgmXjLZ2b+1kjs/0rdSpqKrjTQ1o/A4zF3W m8eDdxVZfOz9sywQBvEQcHFOW/NcnqcFeCGWmxW0Tc/yhR2jJxUNF+j0as3zx0pZcWKI B2XSltjI/NIKvnclliEOWdwiu3u0mchtqSBBttvXfJyUc/ISY36kklJKfvoGAfiNeuRX P4KLt0tvJ1EF32+bbm0qV1FPaSKdCVY/RGEY0pv5JRtT+wBmoqnlgqfCrsGMuWhnT47H QEBA== X-Gm-Message-State: AOAM533KtZn8mU18TfV/VMtG+wKbyUQOmxITRPDAOdCmI9KAQtUOrdG4 I7yXGIaz1QBUA88okr1ISKkYBDv5mRmMpgomKaTPuw== X-Google-Smtp-Source: ABdhPJzKSIZk0rZsyKz7G4gja5tr4jOpR2PI3QokR/n2GMSumujMwDmGpqPDgHXcKIfE//WiHJswSo6oYRrtvEJ1Wh0= X-Received: by 2002:a05:6902:1342:: with SMTP id g2mr5020180ybu.419.1636601892568; Wed, 10 Nov 2021 19:38:12 -0800 (PST) MIME-Version: 1.0 References: <20211111032204.3721-1-hanyihao@vivo.com> In-Reply-To: <20211111032204.3721-1-hanyihao@vivo.com> From: Muchun Song Date: Thu, 11 Nov 2021 11:37:36 +0800 Message-ID: Subject: Re: [PATCH] mm/damon/vaddr: remove swap_ranges() and replace it with swap() To: Yihao Han Cc: SeongJae Park , Andrew Morton , Linux Memory Management List , LKML , kernel@vivo.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6B76A70000B9 X-Stat-Signature: z7za4ehsgrhs1461scwxrytrt87ykrfe Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=QCAinz1h; spf=pass (imf27.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1636601893-391748 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 11, 2021 at 11:22 AM Yihao Han wrote: > > Remove 'swap_ranges()' and replace it with the macro 'swap()' > defined in 'include/linux/minmax.h' to simplify code and improve efficiency > > Reviewed-by: SeongJae Park > Reviewed-by: Muchun Song > Signed-off-by: Yihao Han Actually, I and SeongJae didn't provide Reviewed-by in the previous thread. But this patch looks good to me, so Reviewed-by: Muchun Song BTW, the subject missed a "v2" tag (and changes log should include what you have changed since v1). Thanks. > --- > mm/damon/vaddr.c | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 35fe49080ee9..814dc811d7c4 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -97,16 +97,6 @@ static unsigned long sz_range(struct damon_addr_range *r) > return r->end - r->start; > } > > -static void swap_ranges(struct damon_addr_range *r1, > - struct damon_addr_range *r2) > -{ > - struct damon_addr_range tmp; > - > - tmp = *r1; > - *r1 = *r2; > - *r2 = tmp; > -} > - > /* > * Find three regions separated by two biggest unmapped regions > * > @@ -145,9 +135,9 @@ static int __damon_va_three_regions(struct vm_area_struct *vma, > gap.start = last_vma->vm_end; > gap.end = vma->vm_start; > if (sz_range(&gap) > sz_range(&second_gap)) { > - swap_ranges(&gap, &second_gap); > + swap(gap, second_gap); > if (sz_range(&second_gap) > sz_range(&first_gap)) > - swap_ranges(&second_gap, &first_gap); > + swap(second_gap, first_gap); > } > next: > last_vma = vma; > @@ -158,7 +148,7 @@ static int __damon_va_three_regions(struct vm_area_struct *vma, > > /* Sort the two biggest gaps by address */ > if (first_gap.start > second_gap.start) > - swap_ranges(&first_gap, &second_gap); > + swap(first_gap, second_gap); > > /* Store the result */ > regions[0].start = ALIGN(start, DAMON_MIN_REGION); > -- > 2.17.1 >