From: Muchun Song <songmuchun@bytedance.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Zi Yan <ziy@nvidia.com>,
baolin.wang@linux.alibaba.com, Huang Ying <ying.huang@intel.com>,
Alistair Popple <apopple@nvidia.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 11/11] mm/migration: fix possible do_pages_stat_array racing with memory offline
Date: Fri, 18 Mar 2022 14:59:40 +0800 [thread overview]
Message-ID: <CAMZfGtWQO3RAX+86O8=_gbiaWfNvxztfMY4S6zBsaVFDEFJPFQ@mail.gmail.com> (raw)
In-Reply-To: <20220318111709.60311-12-linmiaohe@huawei.com>
On Thu, Mar 17, 2022 at 10:42 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> When follow_page peeks a page, the page could be migrated and then be
> offlined while it's still being used by the do_pages_stat_array().
> Use FOLL_GET to hold the page refcnt to fix this potential race.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
prev parent reply other threads:[~2022-03-18 7:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 11:16 [PATCH v2 00/11] A few cleanup and fixup patches for migration Miaohe Lin
2022-03-18 11:16 ` [PATCH v2 01/11] mm/migration: remove unneeded local variable mapping_locked Miaohe Lin
2022-03-18 11:17 ` [PATCH v2 02/11] mm/migration: remove unneeded out label Miaohe Lin
2022-03-18 11:17 ` [PATCH v2 03/11] mm/migration: remove unneeded local variable page_lru Miaohe Lin
2022-03-18 11:17 ` [PATCH v2 04/11] mm/migration: fix the confusing PageTransHuge check Miaohe Lin
2022-03-18 11:17 ` [PATCH v2 05/11] mm/migration: use helper function vma_lookup() in add_page_for_migration Miaohe Lin
2022-03-18 11:17 ` [PATCH v2 06/11] mm/migration: use helper macro min in do_pages_stat Miaohe Lin
2022-03-18 7:01 ` Muchun Song
2022-03-18 11:17 ` [PATCH v2 07/11] mm/migration: avoid unneeded nodemask_t initialization Miaohe Lin
2022-03-18 11:17 ` [PATCH v2 08/11] mm/migration: remove some duplicated codes in migrate_pages Miaohe Lin
2022-03-18 11:17 ` [PATCH v2 09/11] mm/migration: fix potential page refcounts leak " Miaohe Lin
2022-03-18 8:24 ` Muchun Song
2022-03-18 11:17 ` [PATCH v2 10/11] mm/migration: fix potential invalid node access for reclaim-based migration Miaohe Lin
2022-03-18 11:17 ` [PATCH v2 11/11] mm/migration: fix possible do_pages_stat_array racing with memory offline Miaohe Lin
2022-03-18 6:40 ` Huang, Ying
2022-03-18 6:59 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZfGtWQO3RAX+86O8=_gbiaWfNvxztfMY4S6zBsaVFDEFJPFQ@mail.gmail.com' \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox