From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA5DC433EF for ; Mon, 27 Jun 2022 03:23:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 460278E0001; Sun, 26 Jun 2022 23:23:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40F146B0072; Sun, 26 Jun 2022 23:23:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6778E0001; Sun, 26 Jun 2022 23:23:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1D10F6B0071 for ; Sun, 26 Jun 2022 23:23:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CCC39207C7 for ; Mon, 27 Jun 2022 03:23:45 +0000 (UTC) X-FDA: 79622571210.02.4C7CDC5 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf07.hostedemail.com (Postfix) with ESMTP id CBD4340031 for ; Mon, 27 Jun 2022 03:23:44 +0000 (UTC) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-3178ea840easo72592697b3.13 for ; Sun, 26 Jun 2022 20:23:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eN+xoYA+ksKDeeujf53jiHGUJcOQVzh6cwSiG0r1JZ0=; b=VZASWp/K3Xzse8hHey4MhbH+j2n8icJllf/NFc2ri+vgIMu/2qvY/TvM0CReGMQIhk Q9NnMpdtXy5gdBtd8D/QZD4cNqcJNwU2DaqQBUAw10Gl3yqmRO3Oo4EEICu7bCzJOFis kPApaPYwsunYb2di9uQWNejNAF+g44cfP48iFaSCYQ7LopQiWLOTgTKMl2fJE5Dagibr vF0dfCSEVPbA1ZEOrLKDTn1JlPhyI4mw2F4rdz/MVmvFq+ZsXm3NxqUOUo4+1mUPdnBW D23Q9O3xlZ9IfSdolmXs7aC0lExuB//NN7EkVklnUIYUPwIVpotTJ74mu6HjXw2DKmWj BHVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eN+xoYA+ksKDeeujf53jiHGUJcOQVzh6cwSiG0r1JZ0=; b=a/DzdEDa2VvYqgY6f7vP73PQ95Yo6N4MGT7W7VxiG3xouqY+DHC2lphj+wPdS+ePXX THG7uH1/hANT2MJLVBHLI62I3Vfqp+McvfhGu7V6gxhK7hUMLeNRKDkAk3K2c41gRxyD TxcClt+RKh0T41yRwEyBnDM05Fucxni8ehTKMX9FpdX0NRCMpJbcpvuwliD9l0cLFXwz jlJ7ltn8mo6DZGI33B0gKeNSrhP5W9ngYOA5oEp0zUEkswnOheAjkBT6umzJix0JLSf0 zo6bMlmkAChReur5XGJTyt6p+TSTx8SipgfB9lr5bMH2iQnbYzVGmnJ8vCO+zxCUg8ch RNYw== X-Gm-Message-State: AJIora8Fgmm08EaMRD5yArt6wlHmmEMpd3l99caWQrW3+IWmzTw4muWG rVgvyt41WWVT9+HN0FfAHMs1MW8fPgixSo9BQAKzzw== X-Google-Smtp-Source: AGRyM1ttUQbhNS8g8BPtv9oRKCweJCwEVCohrYTwcAyyKKEjTRNIc1b4sVqgvWwkxo0N0u+0HR5jP3dE8s97Vii9/d0= X-Received: by 2002:a81:5dd5:0:b0:31b:a0f1:254e with SMTP id r204-20020a815dd5000000b0031ba0f1254emr6333166ywb.141.1656300223877; Sun, 26 Jun 2022 20:23:43 -0700 (PDT) MIME-Version: 1.0 References: <97bed1fd-f230-c2ea-1cb6-8230825a9a64@openvz.org> In-Reply-To: <97bed1fd-f230-c2ea-1cb6-8230825a9a64@openvz.org> From: Muchun Song Date: Mon, 27 Jun 2022 11:23:07 +0800 Message-ID: Subject: Re: [PATCH mm v2] memcg: notify about global mem_cgroup_id space depletion To: Vasily Averin Cc: Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Michal Hocko , kernel@openvz.org, LKML , Andrew Morton , Linux Memory Management List , Vlastimil Babka , Cgroups Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656300225; a=rsa-sha256; cv=none; b=FMBho9Ef+MS7h0Drja/wPNwK2ahgvApmy8n2mRwTUhAe4JK2TbNKc81PCjHdooBb/PSmNt RG9+wDswtD+Y+SKNfo8ViC2SzpBFhOeQhzZbn9qBb9N/+IlPJwZrQ+d+5d5URJdbUzvkce VigujHvi+D9dQXHaJPBAppl7FSG/IvE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="VZASWp/K"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656300225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eN+xoYA+ksKDeeujf53jiHGUJcOQVzh6cwSiG0r1JZ0=; b=JZNCf277svno0YujYnVivYSFPi8Ld7yM2dNDOqQetDgIy2PqAjSK/uWcyLnYNEnkOxEADu /j/xeaaEbzF0Doue3G6FQkwHqlm0hYO0Y5pQU5ySvsxLzm3Kxz7U8HvB89LxD7RIcAGuve /kSInMla59Yd0MYKqzYv8JVAHHgFdUU= X-Stat-Signature: gnrqy8kx7sntyi71kwg64pp4435acuon X-Rspamd-Queue-Id: CBD4340031 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="VZASWp/K"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1656300224-579248 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 27, 2022 at 10:11 AM Vasily Averin wrote: > > Currently, the host owner is not informed about the exhaustion of the > global mem_cgroup_id space. When this happens, systemd cannot start a > new service and receives a unique -ENOSPC error code. > However, this can happen inside this container, persist in the log file > of the local container, and may not be noticed by the host owner if he > did not try to start any new services. > > Signed-off-by: Vasily Averin > --- > v2: Roman Gushchin pointed that idr_alloc() should return unique -ENOSPC If the caller can know -ENOSPC is returned by mkdir(), then I think the user (perhaps systemd) is the best place to throw out the error message instead of in the kernel log. Right? Thanks. > if no free IDs could be found, but can also return -ENOMEM. > Therefore error code check was added before message output and > patch descriprion was adopted. > --- > mm/memcontrol.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d4c606a06bcd..ffc6b5d6b95e 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5317,6 +5317,8 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > 1, MEM_CGROUP_ID_MAX + 1, GFP_KERNEL); > if (memcg->id.id < 0) { > error = memcg->id.id; > + if (error == -ENOSPC) > + pr_notice_ratelimited("mem_cgroup_id space is exhausted\n"); > goto fail; > } > > -- > 2.36.1 >