From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F991C433EF for ; Fri, 4 Mar 2022 13:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDBE68D0002; Fri, 4 Mar 2022 08:48:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C64588D0001; Fri, 4 Mar 2022 08:48:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B04948D0002; Fri, 4 Mar 2022 08:48:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 9D5248D0001 for ; Fri, 4 Mar 2022 08:48:54 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 58482180A7F76 for ; Fri, 4 Mar 2022 13:48:54 +0000 (UTC) X-FDA: 79206834588.18.FC31191 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf01.hostedemail.com (Postfix) with ESMTP id 7F3BC40011 for ; Fri, 4 Mar 2022 13:48:53 +0000 (UTC) Received: by mail-yb1-f170.google.com with SMTP id w16so16912352ybi.12 for ; Fri, 04 Mar 2022 05:48:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dxkq6fSmSidI5jxQNF6F1Isey3naDKJl+wbEQVSsuM4=; b=YkmvT2pYJSwLyqzxe7ZiuTgqTHehcij3OgfSQMM1G9wKC+pGj+nepQnxvLkJD3xQbe GwRpzcXG3WQeIjAoaLcRTIw8psD18ZufUgk9tX5LH2aIAQuNR0Cahu4/McJ8wd6gZzvi luZDPBLLHlJnleHkPPudXkxeVQHWd0AC3onqha/ThPA5u8Kkh/J8/GgbbiPu7y/IkQCD SvEngsty4bE46BGPqb3wW85zP0D+WOf83towpFjc7pAVb0Zri9B0Vy50CFtpkwgVhhTi V+J0mQ0Uxj8DwCYfay7aW3eGcsiLKNEuNAKmnBtxXIiBo6RkPNSF3yk9DURTmdy12gIx b8Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dxkq6fSmSidI5jxQNF6F1Isey3naDKJl+wbEQVSsuM4=; b=Ca9YDgldvZ/rLsPRbDUTfsbN1Xb449RirdbgbHUR+iULgOhvhYZZEUGhTvdBBWEjUx KKUflgfGaoDUAc+V77FroDP8Nv+tRIcjPex+ZVFSXTBRA3wmUh9eLJ2/zhnaRkHJ7H+I 6XQOnG9vAd9fLxj0X+QM9mqJWOqLaXVrQroEHTscpEUDtqz7pAuXufjz3kvl5TEKkdhL T6pE/0FgcLv0E3njuBltw+poLaQ0Y+0qC01uy9AOlWPTXCysYshvNmGKwe7OGf1XZbwO a4gyVZ2uB9jmyKQSPo9Au2v1sqJNet/zGTYzZBuUDPehBvgQXXRiyzt8S3X4vkwUwmma 2xPA== X-Gm-Message-State: AOAM532mk3cRZcBWqop0MgC5uqJjDbe9340WLkuYXRhwkKTW3YmRDGkW OxSF5WM76y6Mckpj5i79Q1zZbrH8K0P1IPHG0lsSrA== X-Google-Smtp-Source: ABdhPJxKuAiqNr7UyPfzts+HCa+Uluo7ia6UGSm/CWm+KUhmQlIvDFPwusld7YQhjESeDq8Q2ncG3s8yTNqILxMlLFA= X-Received: by 2002:a25:3d47:0:b0:624:7b42:9f0f with SMTP id k68-20020a253d47000000b006247b429f0fmr38966576yba.254.1646401732585; Fri, 04 Mar 2022 05:48:52 -0800 (PST) MIME-Version: 1.0 References: <20220304093409.25829-1-linmiaohe@huawei.com> <20220304093409.25829-2-linmiaohe@huawei.com> In-Reply-To: <20220304093409.25829-2-linmiaohe@huawei.com> From: Muchun Song Date: Fri, 4 Mar 2022 21:48:05 +0800 Message-ID: Subject: Re: [PATCH 01/16] mm/migration: remove unneeded local variable mapping_locked To: Miaohe Lin Cc: Andrew Morton , Mike Kravetz , Yang Shi , Matthew Wilcox , Huang Ying , Zi Yan , Minchan Kim , Alistair Popple , ave.hansen@linux.intel.com, o451686892@gmail.com, Mina Almasry , John Hubbard , Ralph Campbell , Peter Xu , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Michal Hocko , riel@redhat.com, Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7F3BC40011 X-Stat-Signature: zug7m4ksihyqz9pn99kdek8spzcr1i88 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=YkmvT2pY; spf=pass (imf01.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1646401733-61099 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 4, 2022 at 5:35 PM Miaohe Lin wrote: > > When mapping_locked is true, TTU_RMAP_LOCKED is always set to ttu. We can > check ttu instead so mapping_locked can be removed. And ttu is either 0 > or TTU_RMAP_LOCKED now. Change '|=' to '=' to reflect this. > > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song Thanks.