From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B41C433EF for ; Mon, 24 Jan 2022 09:01:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CE0C6B0081; Mon, 24 Jan 2022 04:01:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57D776B0083; Mon, 24 Jan 2022 04:01:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46C7A6B0085; Mon, 24 Jan 2022 04:01:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 344B96B0081 for ; Mon, 24 Jan 2022 04:01:41 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DEE4F181C65C3 for ; Mon, 24 Jan 2022 09:01:40 +0000 (UTC) X-FDA: 79064587560.31.CE7646B Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 58FE640046 for ; Mon, 24 Jan 2022 09:01:40 +0000 (UTC) Received: by mail-yb1-f172.google.com with SMTP id 23so48919445ybf.7 for ; Mon, 24 Jan 2022 01:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qPuSl5NxTGIIFIMAw/dyMyil9mBbCPqU09NIe0oAokU=; b=6llndIHFqFppJ4Gj2xb3cyh+pp6mM711rLtlQwGBakuS3Q/v/2zuj98cryr+VeHrrL o2nf1CmZkHq3QGBrZz1wVwwc8efKujB3hPJQp8C18rdlsVNUx09LyjgmCG4xxoPWQIrH tXOo/ee/k5v9Ic/JAECmKiaQPChSJqOuzivhyfpTWcq6rXvOTLL8Q47QcHdVdH9eQdL6 9P494f3fHakyK4GIkdVdr/un6XlnRhD8Slk1P+r1/j+V2wqnbtDvV8odCtEhc/ohlZU2 d5OwhJx6507d5A3f02MdKERpXa4k6wccCLoHWkv1h56Sik5coVN96gQjQkpXch7rsJIB Z0vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qPuSl5NxTGIIFIMAw/dyMyil9mBbCPqU09NIe0oAokU=; b=CeLybMJh36VWJsOtdo95wHIn4/lBbqby+7pbTwoKX0ABz/CXIAQNE94ggwSeWf/UN1 nfbR4j6tLIMQCZ7DMQ0lG3GZxkRGw/UkQr3uVALzWHQtHsjnElKaX4PRNd6HXyMipcIR QelHlNycWYPN/2or+IxfOTqo8lms2YB4X/VbAawg5rAalfCqtybHIyiMfkTZ0QNF+302 zvQN7HspNnGlGBguoT3VywQJ7+QXaxOYtk0yILJVzNtv73bVGPzQKnrc964a0tVd+wJF JkxUGXzVMsSC10hhRQ1nngVrAz6YKPZLdw6VYFnI/54OAW06u+ZRN8jDNbWtWNbDmw2w /4FQ== X-Gm-Message-State: AOAM532ys9/L+szUPpBdPxPewLDgpFcpe4/1SjUbsJUhJftC7CgANRLc vZtb03bG5iCuGtWnhqLpDuMjNX16YTwkOqmHkfgb2g== X-Google-Smtp-Source: ABdhPJxCB2+GYystUm4f6yE23AKfFLdR4LWU/ii96fyLJt0DuPLnpNq7DG11ShRdZIfMVzy8ewQT7cV3z2wTwLiVyRY= X-Received: by 2002:a25:6d09:: with SMTP id i9mr20946206ybc.703.1643014899644; Mon, 24 Jan 2022 01:01:39 -0800 (PST) MIME-Version: 1.0 References: <20220121075515.79311-1-songmuchun@bytedance.com> <20220121075515.79311-3-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Mon, 24 Jan 2022 17:01:03 +0800 Message-ID: Subject: Re: [PATCH 3/5] mm: page_vma_mapped: support checking if a pfn is mapped into a vma To: Christoph Hellwig Cc: Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Andrew Morton , apopple@nvidia.com, Yang Shi , rcampbell@nvidia.com, Hugh Dickins , Xiyu Yang , "Kirill A. Shutemov" , zwisler@kernel.org, linux-fsdevel , nvdimm@lists.linux.dev, LKML , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 58FE640046 X-Stat-Signature: c64eddfwpyjk8tda5zar93gpugdxqzup Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=6llndIHF; spf=pass (imf07.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam01 X-HE-Tag: 1643014900-753531 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 3:36 PM Christoph Hellwig wrote: > > On Fri, Jan 21, 2022 at 03:55:13PM +0800, Muchun Song wrote: > > + if (pvmw->pte && ((pvmw->flags & PVMW_PFN_WALK) || !PageHuge(pvmw->page))) > > Please avoid the overly long line here and in a few other places. OK. > > > +/* > > + * Then at what user virtual address will none of the page be found in vma? > > Doesn't parse, what is this trying to say? Well, I am also confused. BTW, this is not introduced by me, it is introduced by: commit 37ffe9f4d7ff ("mm/thp: fix vma_address() if virtual address below file offset") If it is really confusing, I can replace this line with: "Return the end user virtual address of a page within a vma" Thanks.