From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18891C2BA19 for ; Tue, 14 Apr 2020 07:19:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D34C206E9 for ; Tue, 14 Apr 2020 07:19:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="jNALwbuj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D34C206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E2B08E0003; Tue, 14 Apr 2020 03:19:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 193A68E0001; Tue, 14 Apr 2020 03:19:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AA478E0003; Tue, 14 Apr 2020 03:19:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id E39528E0001 for ; Tue, 14 Apr 2020 03:19:54 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A19D5181AEF1F for ; Tue, 14 Apr 2020 07:19:54 +0000 (UTC) X-FDA: 76705611108.18.eggs22_738e8dad87b28 X-HE-Tag: eggs22_738e8dad87b28 X-Filterd-Recvd-Size: 3446 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 07:19:53 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id c17so7265859ilk.6 for ; Tue, 14 Apr 2020 00:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g9r4EcstBBSCdem5nrPjtuIPy/foYH/WRJ4Lrw6qkzE=; b=jNALwbujMFrtEjjDpoR6hxcist0AftqsK2r2N5wdI/fCe4BB7T1oJsgW0/GfxF3pgj otQO55inAwZnkeZN7VSgqSMFpRs9yIS/hC0ZRG1TmaJ2kgq+nZ0kNCkcLjCvEJzgE/pY g60rU0OgrCF5H2sYpqAkkkFK4OxEdXgw2MPT3D6xrNOTjpCpnF0zgmp3mDGvT/X4MYSh uqdWLGZ16CYiUKC2Z7NG1v/ZA++tQX1K4goycN6u/WMbc3w+vvrNdDU+Hk9ONk83+qrR iINNwURxkr4Y2BOckyutoh8aDmgNfnEeJrQCX1zqBQ9ahzGcrFglrv3LyMNHUX+tD0CB 4PPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g9r4EcstBBSCdem5nrPjtuIPy/foYH/WRJ4Lrw6qkzE=; b=qnXbAr+UX+GwqBkIcSY6Rbw+yjKjDLgQjxRWrNT7fW7d8GSgVKlEyAVHfJ6cBYJieG z2ZSqRXs9MlBrz8q2RoTKPKcUc0XSE6SlIZiDZLklK4O7/dm/VFCjRw07WkEt1dSySL/ usMGW3i7ZqdmfAcTWwBXz/DcW35j++GMnx+AhlBp3xmOxFmK1L+Gz9grnP7FPVstOKtd BBAxQYdRsvaK3YqhnzewnLvL6dmdEwcNuV5LyY/K2paGZLJy4GMfutRc9DenyDfpUk4O vaojx2sFBSGuU1BA5BWKSxvogCQ1waRUy7ZVMwzhrVxdLeGQVvsUhtgDEs1P+mcsJu4D 1y4w== X-Gm-Message-State: AGi0PuZfEaS7sEIhiLdKauTQO6GXcbrIpt4w+44WUp/6MNLcnxB3Q7LO KS/jSzRhYiICI2/cVM0ZNGGbr7mKpVwVxQs6NtwroQ== X-Google-Smtp-Source: APiQypJuPkpZJXeDJaPvW5wUMjvf3d+aMXFteAuJ/LWSjGJDWJMYvOfbfdhn86YIOubDytW2NuGvRhCnH24LIAtIahU= X-Received: by 2002:a92:5b56:: with SMTP id p83mr21363706ilb.70.1586848793186; Tue, 14 Apr 2020 00:19:53 -0700 (PDT) MIME-Version: 1.0 References: <740ca6b2-d3c9-02a2-9d81-c212bf9772e2@web.de> In-Reply-To: <740ca6b2-d3c9-02a2-9d81-c212bf9772e2@web.de> From: Muchun Song Date: Tue, 14 Apr 2020 15:19:17 +0800 Message-ID: Subject: Re: [External] Re: [PATCH] mm/ksm: Fix a null pointer dereference To: Markus Elfring Cc: Xiongchun duan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 14, 2020 at 3:14 PM Markus Elfring wrot= e: > > > The find_mergeable_vma can return NULL. In this case, it leads > > to crash when we access vma->vm_mm(which's offset is 0x40) in > > I suggest to improve the commit message. > > * Wording alternative: > to a crash when we access vma->vm_mm (its offset is 0x40) in > > * Can a function name be nicer than the information =E2=80=9Cat 000000000= 0000040=E2=80=9D > in the patch subject? > > * Would you like to add the tag =E2=80=9CFixes=E2=80=9D to the change des= cription? > Thanks for your suggestion. I will send a v2 patch later. --=20 Yours, Muchun