From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96FAFC433DB for ; Tue, 26 Jan 2021 02:46:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 19D9022AAA for ; Tue, 26 Jan 2021 02:46:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19D9022AAA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC1878D0065; Mon, 25 Jan 2021 21:46:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D70DF6B00A0; Mon, 25 Jan 2021 21:46:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85FD8D0065; Mon, 25 Jan 2021 21:46:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id B0DAE6B009F for ; Mon, 25 Jan 2021 21:46:10 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6B4B93623 for ; Tue, 26 Jan 2021 02:46:10 +0000 (UTC) X-FDA: 77746386900.05.pest68_09062312758a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 50BAC1802821C for ; Tue, 26 Jan 2021 02:46:10 +0000 (UTC) X-HE-Tag: pest68_09062312758a X-Filterd-Recvd-Size: 5186 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 02:46:09 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id z21so10515394pgj.4 for ; Mon, 25 Jan 2021 18:46:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hWGZswVflRpHTssK7VvTt7HKTpyszr8rzXo8cgMjsjA=; b=UhhxZJLv7oppd27QQQf7NmOdXXi/dtkkLvnyAZonNWeNR4BFCWJVnaN2I1jqFVdYPu +AKS5xYuMabNbOKh7OtTfUvr3YiOEmUsh8Q8XCwhUrxvwlv8cKnKTiUafwD1IOwrGE9b fSOJUxUVXSlDk8rIPcuKFrDwxsNICU6fuFQFwueejxSwIu48+/VELScVP+lHUGRyTo4C mhpu9rx18gQCr5iN1kZH24PA/xEDgJPNjUh3TmO73YKZjCv4o0NLJFZIrlAFsypF4FlY KFMaDVnD4R3srQhVo7Sujov8VSBcnOBkVc0lCcrKjqB2Q7nNgwX+DOicMk/J2FzHUBJC rTWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hWGZswVflRpHTssK7VvTt7HKTpyszr8rzXo8cgMjsjA=; b=thWSeqabISoxJCt2PxWPxh+3E0NF8oLrSCvVmL27i3RIKtHu79IyVvDfnopOE7aF7n yFk0BS1+4phasj0vYQnZPQp0khtPynGfpbjHU6xDRHh+N/5NjGItw3Dg6MhK9JMikGPX G5V5W3ITcJeWVeHa9LHpu/3TX3P07KfFBFhx4xBSXXFRgRLKzqTYfU+T+EZ6b2ruMCiz MmNRbSpIvUlc8k5Rh2vBc9JO659+NhqFtg/54WZ1yLNXZL0Drzxe2g/N2idcFN+ZxPIl ivDJZeWeCpUM0sn7XK+WgAd8PuLDRfjCFypQ7otR2Xlu408O6B3KsmyDIzN226MevOkR Eeug== X-Gm-Message-State: AOAM530mLwodmx52bdvBwsQQZffha21aGEmg0yUDNT1eIZLsumXtBO90 VP3iOadt6nC6PGL24r1ia/GV9M8lPD9MN7Jahk4i8g== X-Google-Smtp-Source: ABdhPJzJw/g9vq/ezd6LGNCYqQY7xJY3b/k9Wogea+ntQG37KA2GV//3WD/k9+DNv/VVGlGj2BQCiYKLx5n/xWQfUHc= X-Received: by 2002:aa7:8ed2:0:b029:1b9:7c87:8f44 with SMTP id b18-20020aa78ed20000b02901b97c878f44mr3290964pfr.49.1611629166691; Mon, 25 Jan 2021 18:46:06 -0800 (PST) MIME-Version: 1.0 References: <20210117151053.24600-1-songmuchun@bytedance.com> <20210117151053.24600-3-songmuchun@bytedance.com> <472a58b9-12cb-3c3-d132-13dbae5174f0@google.com> <2d9bfd8d-a77f-6470-807c-1a71ffeac3ff@google.com> In-Reply-To: <2d9bfd8d-a77f-6470-807c-1a71ffeac3ff@google.com> From: Muchun Song Date: Tue, 26 Jan 2021 10:45:30 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v13 02/12] mm: hugetlb: introduce a new config HUGETLB_PAGE_FREE_VMEMMAP To: David Rientjes Cc: Randy Dunlap , Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , Matthew Wilcox , Oscar Salvador , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 26, 2021 at 2:47 AM David Rientjes wrote: > > On Mon, 25 Jan 2021, Muchun Song wrote: > > > > >> I'm not sure I understand the rationale for providing this help text if > > > >> this is def_bool depending on CONFIG_HUGETLB_PAGE. Are you intending that > > > >> this is actually configurable and we want to provide guidance to the admin > > > >> on when to disable it (which it currently doesn't)? If not, why have the > > > >> help text? > > > > > > > > This is __not__ configurable. Seems like a comment to help others > > > > understand this option. Like Randy said. > > > > > > Yes, it could be written with '#' (or "comment") comment syntax instead of as help text. > > > > Got it. I will update in the next version. Thanks. > > > > I'm not sure that Kconfig is the right place to document functional > behavior of the kernel, especially for non-configurable options. Seems > like this is already served by existing comments added by this patch > series in the files where the description is helpful. OK. So do you mean just remove the help text here? Thanks.