From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FCCBC07E95 for ; Sat, 10 Jul 2021 11:19:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0337A610EA for ; Sat, 10 Jul 2021 11:19:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0337A610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0202D6B0073; Sat, 10 Jul 2021 07:19:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F12DF6B0078; Sat, 10 Jul 2021 07:19:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB39F6B007B; Sat, 10 Jul 2021 07:19:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id BA0896B0073 for ; Sat, 10 Jul 2021 07:19:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DD797181F2291 for ; Sat, 10 Jul 2021 11:19:39 +0000 (UTC) X-FDA: 78346432878.02.9B4D715 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf21.hostedemail.com (Postfix) with ESMTP id BFF93D006BE1 for ; Sat, 10 Jul 2021 11:19:38 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id t9so12708732pgn.4 for ; Sat, 10 Jul 2021 04:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5Fxzax5cpRXuDAgNVxBd/5Ht8jrK3NBiBX9Z3Z3en2A=; b=Nd2YCVkKoDLy3hEtStCKbIcb6+F7OwCpW5WNUXe41pujO9UWnItUfazYVV0AUIWnx0 V5Qqf8UukAsVyB2gF/oVZghm6cWIM7/NTpp6BdhzmerA1z1YSmFRUoACKPA01k6wkc8K ZzDsu5CNXZIfn5YNrREUIcuet1/Eh3NMpstMmVR/vb5ckoeb0n91CRhjIZRUNl82jK8o z8fXtNc4rn/I2DI5plmBilqgX7EOxK5exQQw/Qyw7jNkKHwRVwm/AzTC54Gq1FHjYihW QJ7SE5HzfbbFCdjB44ohBfXhQAyPRakHcorVvbATqCZvWebbY3zOPwgqS8GJQHOzePx7 7YPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Fxzax5cpRXuDAgNVxBd/5Ht8jrK3NBiBX9Z3Z3en2A=; b=Tmk9dEL9X54vDZ2nTM6/UnSbSn7qjRNVRhoCKFwjt3sYxSTK0s13FnlSJ48RwwBDaI kC4P8xkfjRanb31AsextNgSOpmbSNZyZUDIdzLIJX6owXQlg3mCCaGl31+R7mDIv4r8Z MTYw5lFWWPqWSoOeijQbnSqiwvPFU0E+spkTVWg7uvZNZ6vbsZQUzaCduBS2QJa3BERq 5opv3e7FIbLEZaf4m947JJH6lurPSV9zVQ6Ut26k3b8ie9c65fM92X1rZ+03YK950KdF hSD2zgfMtI/Z81Pat/xK1bWObbyIR2Pe9l9Gb3fiJEnXZJRUuN4QslVw3fFNdeUOFdT7 toIQ== X-Gm-Message-State: AOAM531aVTAE6hXrA1o3VOU60f9OAnvW6HeTWsTxmRoN5X145AEN9dL0 ZvS90afZiCHmkL6fcO/8MHR4BFwvhLXORNefl9lN7Q== X-Google-Smtp-Source: ABdhPJxBKM/bMTrpxWLVfJMl8Ma7Ym0dkHhsHvo5jn8cO7rhfOTIBhgL4kuypJe0wyhc8mEHOfV5RaTljowAneyuwHI= X-Received: by 2002:a05:6a00:23c7:b029:323:3d55:68c0 with SMTP id g7-20020a056a0023c7b02903233d5568c0mr26127249pfc.2.1625915977569; Sat, 10 Jul 2021 04:19:37 -0700 (PDT) MIME-Version: 1.0 References: <20210710003626.3549282-1-surenb@google.com> <20210710003626.3549282-3-surenb@google.com> In-Reply-To: <20210710003626.3549282-3-surenb@google.com> From: Muchun Song Date: Sat, 10 Jul 2021 19:19:01 +0800 Message-ID: Subject: Re: [External] [PATCH v3 3/3] mm, memcg: inline swap-related functions to improve disabled memcg config To: Suren Baghdasaryan Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Yang Shi , Alex Shi , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , Matthew Wilcox , apopple@nvidia.com, Minchan Kim , Miaohe Lin , LKML , Cgroups , Linux Memory Management List , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=Nd2YCVkK; spf=pass (imf21.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: 8hfhpgyi9z4npqy9hafwdg8t6uz5dmq3 X-Rspamd-Queue-Id: BFF93D006BE1 X-Rspamd-Server: rspam01 X-HE-Tag: 1625915978-379455 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 10, 2021 at 8:36 AM Suren Baghdasaryan wrote: > > Inline mem_cgroup_try_charge_swap, mem_cgroup_uncharge_swap and > cgroup_throttle_swaprate functions to perform mem_cgroup_disabled static > key check inline before calling the main body of the function. This > minimizes the memcg overhead in the pagefault and exit_mmap paths when > memcgs are disabled using cgroup_disable=memory command-line option. > This change results in ~1% overhead reduction when running PFT test > comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory} > configuration on an 8-core ARM64 Android device. > > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Shakeel Butt > Acked-by: Johannes Weiner LGTM. Reviewed-by: Muchun Song Thanks.