From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB09C47082 for ; Thu, 27 May 2021 02:51:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0DA1F613CC for ; Thu, 27 May 2021 02:51:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DA1F613CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94DCA6B0036; Wed, 26 May 2021 22:51:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FEAE6B006E; Wed, 26 May 2021 22:51:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 778D06B0070; Wed, 26 May 2021 22:51:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 3CC2A6B0036 for ; Wed, 26 May 2021 22:51:56 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C6DBE8249980 for ; Thu, 27 May 2021 02:51:55 +0000 (UTC) X-FDA: 78185486190.13.9611F55 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf27.hostedemail.com (Postfix) with ESMTP id B027D801912D for ; Thu, 27 May 2021 02:51:47 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id d16so2498425pfn.12 for ; Wed, 26 May 2021 19:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D9m5HFb8leU14rBoJH9HeAj1juzBFPxGY68vNNZoXG4=; b=wZSqNswK/P2AvhAXVxEiPlPd82P/u3CpBa+URRl8gUOd/uTQBUmqez9UTX+WVrmljj NNcEEhmYVqoJhf+zGwYR1/p8U5/ihpeoPlry0a9pVvtgjJsSaotA5vFNn0EngVsxkyOA 8KqAxwpm3tL9+JcDtZEhEloBxAirq1hXuYna8wPjANCNozx+obu5sja3mouDIkPtptmk zP81cJejXTpVQsLWuW3YUEw2I1bH9aJDIQhCOVoLGl6rWjqXHDb97aEwiTwpir4VZ3U0 XW8tPjUjvvZGqOHHJz3ZZqNVOK+bcpBY3UHB+/7sCc+RN2cje+QtINuQJJslx3vKmK+s 1GpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D9m5HFb8leU14rBoJH9HeAj1juzBFPxGY68vNNZoXG4=; b=MJLTFQaLBNzTuQYvtgNG+bTk7h00HezFipNQwwh7pOb8cZ2U5F8qbTPHGT4t7/IebV MOYGEb7jFZCDpxSsyLYRPWMi2toot3Vo6njCwD9Ux52FWd/3M3d/u7TnHCGecy68iSXb GRTkpXt23ecIWypqta1RqmfHuosKE1kcwkZZU9fLxVy6ihOpE4JhCrM+LX2ZcnXUa219 qRosOoBGW7OWkuBtJlrEw54KkZgHmtNhRJl90QHyfZpopoM/EXjPXTHvg6F5mkEbmoeA v8qwVfc7lCCY0j+699/p1ZWzwMioyZWhA3ofvOQL0g/IoDaG8+8yGtWrVuYJE045YLCM mKMg== X-Gm-Message-State: AOAM532EMo6gG5vu8xemCgixNQJUqt0EeYYJQb9fNWN2VAv8+DFG8Cjm Q7A2zMcPRc3kg3GCZpVBcBKgJWzcJDMhT5aYgMwREg== X-Google-Smtp-Source: ABdhPJyxcexXsugE1m+I8Rfx9Y6j9VCWne3erTHCHADhrzsKsFule1A+ScJsVC/GsrhNUUrN2wN4AEHdhEYR6RvpiGE= X-Received: by 2002:a63:6547:: with SMTP id z68mr1591428pgb.341.1622083914474; Wed, 26 May 2021 19:51:54 -0700 (PDT) MIME-Version: 1.0 References: <20210526025625.601023-1-swboyd@chromium.org> <20210526025625.601023-2-swboyd@chromium.org> In-Reply-To: From: Muchun Song Date: Thu, 27 May 2021 10:51:18 +0800 Message-ID: Subject: Re: [External] [PATCH v2 1/4] slub: Restore slub_debug=- behavior To: Stephen Boyd Cc: Vlastimil Babka , Andrew Morton , LKML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux Memory Management List , Petr Mladek , Joe Perches Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=wZSqNswK; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B027D801912D X-Stat-Signature: rcsdfyq874ni3smm1cznt4kxbx6rfq9u X-HE-Tag: 1622083907-810077 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 27, 2021 at 4:20 AM Stephen Boyd wrote: > > Quoting Vlastimil Babka (2021-05-26 03:39:54) > > On 5/26/21 6:04 AM, Muchun Song wrote: > > > On Wed, May 26, 2021 at 10:56 AM Stephen Boyd wrote: > > >> > > >> Passing slub_debug=- on the kernel commandline is supposed to disable > > >> slub debugging. This is especially useful with CONFIG_SLUB_DEBUG_ON > > >> where the default is to have slub debugging enabled in the build. Due to > > >> some code reorganization this behavior was dropped, but the code to make > > >> it work mostly stuck around. Restore the previous behavior by disabling > > >> the static key when we parse the commandline and see that we're trying > > >> to disable slub debugging. > > >> > > >> Cc: Vlastimil Babka > > >> Fixes: e17f1dfba37b ("mm, slub: extend slub_debug syntax for multiple blocks") > > > > Acked-by: Vlastimil Babka > > > > > > > > Is it caused by the commit ca0cab65ea2b ("mm, slub: introduce static > > > key for slub_debug()")? > > > > Yep, looks like a better Fixes: candidate. > > > > Fixed it. Thanks. With that fix. Please feel free to add: Reviewed-by: Muchun Song Thanks.