From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F25AEC432BE for ; Sat, 28 Aug 2021 05:26:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5EE6C60F35 for ; Sat, 28 Aug 2021 05:26:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5EE6C60F35 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 67DE08D0001; Sat, 28 Aug 2021 01:26:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62E5B6B0071; Sat, 28 Aug 2021 01:26:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51E4B8D0001; Sat, 28 Aug 2021 01:26:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 363906B006C for ; Sat, 28 Aug 2021 01:26:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AE380256FB for ; Sat, 28 Aug 2021 05:26:05 +0000 (UTC) X-FDA: 78523353090.01.84941B7 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf17.hostedemail.com (Postfix) with ESMTP id AC921F000136 for ; Sat, 28 Aug 2021 05:26:04 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id m17so5390952plc.6 for ; Fri, 27 Aug 2021 22:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2JfUpe2H37PEi8fU0OKJL2trjpNhW7D/OwMqmglIVHg=; b=wmdEvv2ENIhYYGUB7JTLAaIAv0cY9J3AEXqGcxs1JW+wpuG+n6GX/zaphPuMCLN3xI ns9idB6Sg7OOr03SuAxG8sRfuinLdHFSjEU7Jq3tp6oLpTSXdhzJPqGFq/uZ+786OV8p xd/s6r1r4ESyAYa+7j4DekrjGfL2n2mT9Ovr+H0dMEBLRaDX5FUtiImrzjnlHt2guhE4 SttN5jwQ2wwEd3jfeAACvoIdQHjZHFJkMFIJcbCmI+cJx+9Z5ebldao2y6R7yv1o1Gnl WYYQWav3jQ0a7SPEmpucjj3+iuyqLjSHpDbeiKtEJylvNGStg8w9l95tdLZctBgLKoTg DR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2JfUpe2H37PEi8fU0OKJL2trjpNhW7D/OwMqmglIVHg=; b=W4z+BBCu1JRhVvGzVc7eJ5cIyjwrrYYq9RyPBXZX/+CAk+P5p70NpEs5A/f56Er4z7 nu/E04ZPOz2kzFnF1rC3Ptk64p6RSZfBCNpc+TDNxQx+NzUHUV/bKeFl8mCNjH9prklP 3rGScyDnW9e3Z8kGBhRlUG9t4R9pu0K10Fmz3Acon24C0c5P2RhZif3kyc1RhPgxFNUH /FhUqGAjx37KDgZXteX1NkFhnUVJE8XXnIQPCE3/SlLhp0+06OAY15Ya11zhOXPqG9nr eu+GusDN1RaKtN4Cm5VUjz1fVIWQVLx6ePfYLsU46qbng/jefP+La1vYFVFkXNfF7wnF KCmQ== X-Gm-Message-State: AOAM531/PQtS+B8ZKakZKdhTQ84f9e6BKeq+8szCzsoNQIDwKzfngrlm eaGS9/ex9V+0lEIYkFeAzBE99TmPvQtdOe30Fyv2Ow== X-Google-Smtp-Source: ABdhPJyWIL3bp2Wtvc8QNlN/2pOeczW9cA7a6NJ+Yc79O9glgqWDdhp+1YDeYsbIyXrjH7fSFmW+RMAB1LNFKreobxU= X-Received: by 2002:a17:90a:5405:: with SMTP id z5mr14659897pjh.229.1630128363484; Fri, 27 Aug 2021 22:26:03 -0700 (PDT) MIME-Version: 1.0 References: <20210828042306.42886-1-zhengqi.arch@bytedance.com> <20210828042306.42886-2-zhengqi.arch@bytedance.com> In-Reply-To: <20210828042306.42886-2-zhengqi.arch@bytedance.com> From: Muchun Song Date: Sat, 28 Aug 2021 13:25:27 +0800 Message-ID: Subject: Re: [PATCH v1 1/2] mm: introduce pmd_install() helper To: Qi Zheng Cc: Andrew Morton , Thomas Gleixner , Johannes Weiner , Michal Hocko , Vladimir Davydov , "Kirill A. Shutemov" , mika.penttila@nextfour.com, David Hildenbrand , linux-doc@vger.kernel.org, LKML , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=wmdEvv2E; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf17.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AC921F000136 X-Stat-Signature: 16ibxi7hzmyqq4erqtbiw1gmknxtwot9 X-HE-Tag: 1630128364-15923 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 28, 2021 at 12:23 PM Qi Zheng wrote: > > Currently we have three times the same few lines repeated in the > code. Deduplicate them by newly introduced pmd_install() helper. > > Signed-off-by: Qi Zheng > Reviewed-by: David Hildenbrand Reviewed-by: Muchun Song