From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D3A7C433FE for ; Thu, 10 Dec 2020 15:22:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6189023BAB for ; Thu, 10 Dec 2020 15:22:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6189023BAB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF0D46B005D; Thu, 10 Dec 2020 10:22:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A79D66B0068; Thu, 10 Dec 2020 10:22:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 967D06B006C; Thu, 10 Dec 2020 10:22:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 7C9C06B005D for ; Thu, 10 Dec 2020 10:22:54 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 467B5180AD802 for ; Thu, 10 Dec 2020 15:22:54 +0000 (UTC) X-FDA: 77577740268.15.board97_610e69f273f9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 1AD7E1814B0C1 for ; Thu, 10 Dec 2020 15:22:54 +0000 (UTC) X-HE-Tag: board97_610e69f273f9 X-Filterd-Recvd-Size: 6556 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 15:22:53 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id g20so2098366plo.2 for ; Thu, 10 Dec 2020 07:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YxwaAAILNdApGCqxRJD9MVfeDiL8SXyh6Su+yDRYLEY=; b=QnoSqYI6BQegxydBg15IBI7iVTrqsyX2nwVstbgi36h5JjuBDHy6haihOTgQPZa+o/ 1yxnr4OQ/AALgpYahJAXoZbt4JUutdj+fUCov7bCnyFyUbT7+c/THaDFLaDoTpb1QK61 jWHvckQX5gIYElzlGNzB0vaIB5NkfvvfbZjSeyeCLKHFEZkbo18BBUlj3klO4wNUIS/0 pAxMtBuBQTvqYGVruXyESkrojUQyhsFh8vxlzMqt6nSBw1QW6bZYhzaMPXVdBoIhz5gA ePxLiKuZhjpYpKA2eZ+YpKlZT5tx/gScIM9Y3vrWiUkC6u8iaXwzp/IFfpL1pCaRl8wS VlEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YxwaAAILNdApGCqxRJD9MVfeDiL8SXyh6Su+yDRYLEY=; b=Zaq2elNOqOMbAsF77m9Lg7fXnBXn8ZomGvKAZ5y0Amhs5UD8KxRZ9O1p+ROBActnfZ vz4D1gTeEGTg9WLaIoPu3qMKZZQWF1UDpAPQy5EC0mjsksiQt19CEVYn3cN9iU4CwMSI m4fuiyvdQWaXxpf54WfEugVli4Q/2yMLRYI0k/nxmt3oCGYWxx0eBoBBz7uMthT8CNqK qXzCzZbEoSHh2QcO05JRLoaRpI2iYXdZKVKbXQYvZ3Ml7urZQnJjJsPq3J+FNCVuUUkI epOlrPoxRakG769GIEPeLiDfmgDHl6wBFamKuew2BZB9rInxYB89w5KdXTTZXRmBHYDG uu8A== X-Gm-Message-State: AOAM5308tcwU3mxd+PjqYb6as7QmKtsIjAXv8MPRo7XINUtXW4ab3kH6 OGxAvMqRFeTOneMxiugkcRJ6TNRISjOF3OQAs3YXTA== X-Google-Smtp-Source: ABdhPJzd1hC7caLHiFO1MtPobpcg3nJcwuDHdu6A/DYS21xLZ+5VYCN0bNhx+AKBnGVZ2k4x3VtNhB8mvu9qpHmTREA= X-Received: by 2002:a17:902:ed0d:b029:da:c83b:5f40 with SMTP id b13-20020a170902ed0db02900dac83b5f40mr7004443pld.20.1607613772004; Thu, 10 Dec 2020 07:22:52 -0800 (PST) MIME-Version: 1.0 References: <20201210035526.38938-1-songmuchun@bytedance.com> <20201210035526.38938-4-songmuchun@bytedance.com> <20201210141547.GA8538@localhost.localdomain> In-Reply-To: <20201210141547.GA8538@localhost.localdomain> From: Muchun Song Date: Thu, 10 Dec 2020 23:22:15 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v8 03/12] mm/bootmem_info: Introduce free_bootmem_page helper To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 10, 2020 at 10:16 PM Oscar Salvador wrote: > > On Thu, Dec 10, 2020 at 11:55:17AM +0800, Muchun Song wrote: > > Any memory allocated via the memblock allocator and not via the buddy > > will be makred reserved already in the memmap. For those pages, we can > marked Thanks. > > call free_bootmem_page() to free it to buddy allocator. > > > > Becasue we wan to free some vmemmap pages of the HugeTLB to the buddy > Because want > > allocator, we can use this helper to do that in the later patchs. > patches > Thanks. > To be honest, I think if would be best to introduce this along with > patch#4, so we get to see where it gets used. > > > Signed-off-by: Muchun Song > > --- > > include/linux/bootmem_info.h | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/include/linux/bootmem_info.h b/include/linux/bootmem_info.h > > index 4ed6dee1adc9..20a8b0df0c39 100644 > > --- a/include/linux/bootmem_info.h > > +++ b/include/linux/bootmem_info.h > > @@ -3,6 +3,7 @@ > > #define __LINUX_BOOTMEM_INFO_H > > > > #include > > +#include > > already includes Yeah. Can remove this. > > > +static inline void free_bootmem_page(struct page *page) > > +{ > > + unsigned long magic = (unsigned long)page->freelist; > > + > > + /* bootmem page has reserved flag in the reserve_bootmem_region */ > reserve_bootmem_region sets the reserved flag on bootmem pages? Right. > > > + VM_WARN_ON(!PageReserved(page) || page_ref_count(page) != 2); > > We do check for PageReserved in patch#4 before calling in here. > Do we need yet another check here? IOW, do we need to be this paranoid? Yeah, do not need to check again. We can remove it. > > > + if (magic == SECTION_INFO || magic == MIX_SECTION_INFO) > > + put_page_bootmem(page); > > + else > > + WARN_ON(1); > > Lately, some people have been complaining about using WARN_ON as some > systems come with panic_on_warn set. > > I would say that in this case it does not matter much as if the vmemmap > pages are not either SECTION_INFO or MIX_SECTION_INFO it means that a > larger corruption happened elsewhere. > > But I think I would align the checks here. > It does not make sense to me to only scream under DEBUG_VM if page's > refcount differs from 2, and have a WARN_ON if the page we are trying > to free was not used for the memmap array. > Both things imply a corruption, so I would set the checks under the same > configurations. Do you suggest changing them all to VM_DEBUG_ON? > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun