From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84C9CC4338F for ; Thu, 29 Jul 2021 05:41:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B9A3F6103B for ; Thu, 29 Jul 2021 05:41:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B9A3F6103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 451976B006C; Thu, 29 Jul 2021 01:41:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D9226B0070; Thu, 29 Jul 2021 01:41:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27ADA8D0001; Thu, 29 Jul 2021 01:41:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 0993F6B006C for ; Thu, 29 Jul 2021 01:41:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8EA92211D5 for ; Thu, 29 Jul 2021 05:41:19 +0000 (UTC) X-FDA: 78414527478.28.8B67814 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf10.hostedemail.com (Postfix) with ESMTP id 995416013B5F for ; Thu, 29 Jul 2021 05:41:18 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id e2-20020a17090a4a02b029016f3020d867so7604617pjh.3 for ; Wed, 28 Jul 2021 22:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+HcpLcsh3CNoV+plaqHbpcChysjrZ/XdusYt6GxVw9c=; b=DcIJNfrfd9acLnz+K8zFDe8LrcphOUGZZBq5aI6EbzPV4L6yHCZBeg1Rw7ApJaCO4X HWfwLpABI1tGiw7g3IelNruyBKpK5WgwIrpxo3p/2bTitSDU2ef7Sunmcz2GA21O2me6 SyRYFQFvp62zsqWo9VpE8BWa6sLniiXXzkixlsYKgAxUFUef6lZFVrafwg46MxYI0Yl8 q+ilXoXQ9Fh4HacyntUfd9FEI3LiDg24dusH1D0C8KgT1RjN8+seFzZKXssTZ4wfPP8m VpL3X+NwcDOrO2Bh7OEPL8/dpwbxxXA684mSsmxQKBxPqdJtUNdXLA3gkGGg28hwHao3 fvLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+HcpLcsh3CNoV+plaqHbpcChysjrZ/XdusYt6GxVw9c=; b=Jq/cIBJjKMVGg3bdVv0RDqJeQpIxChiMvYiqDFY7e6aMEoqVqJmYoDzRtauIxMAR9T p+jXe8rUkm33OIAqpzHuEkk0BWUKQYI+8KqGhJgthY52fANyGe9lDjbsoijgU9Fa+yIQ yJkhLh2SVAFg+vonEj9b/kLKL4A7PtxMcMi/5WG44OYjJ14OVUB+Vq5uolBkfI6W1J0x O/Ga39ltN2MLJh57kFMCs85WYrMnUTjzmzvEX3Re+/VbjqO3AmZwjTeWBu/Z/JZGE71W gUbVWPG630j/o/ij3fgsOKrI0SSYdMFgi61PkLFvQf0JdRLgBMfqmN86neQVKMiEperp uXNQ== X-Gm-Message-State: AOAM531+L9T3dP7NPRtUqfY9Dfn41e6PWBxthX+qMr/xZ3WZhIuvuLLx xxSjdIYCG0cfrShN6gpgjpPxqY44EKtABJ0WUADGjQ== X-Google-Smtp-Source: ABdhPJzIH77wtaexeyTdeU5SwfT/arZde8HQawX/NMnry5UO5r2XsSkpJedRgNwR2CgaGzJ4adMaVOdYIsd71kiLb7A= X-Received: by 2002:a17:902:e742:b029:12b:5431:24fe with SMTP id p2-20020a170902e742b029012b543124femr3215224plf.20.1627537277324; Wed, 28 Jul 2021 22:41:17 -0700 (PDT) MIME-Version: 1.0 References: <20210728155354.3440560-1-shakeelb@google.com> In-Reply-To: <20210728155354.3440560-1-shakeelb@google.com> From: Muchun Song Date: Thu, 29 Jul 2021 13:40:37 +0800 Message-ID: Subject: Re: [PATCH] slub: fix unreclaimable slab stat for bulk free To: Shakeel Butt Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , Michal Hocko , Roman Gushchin , Wang Hai , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=DcIJNfrf; spf=pass (imf10.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 995416013B5F X-Stat-Signature: rh85y7apjfhqi8qe18bhpnya1p1iy354 X-HE-Tag: 1627537278-920166 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 28, 2021 at 11:54 PM Shakeel Butt wrote: > > SLUB uses page allocator for higher order allocations and update > unreclaimable slab stat for such allocations. At the moment, the bulk > free for SLUB does not share code with normal free code path for these > type of allocations and have missed the stat update. So, fix the stat > update by common code. The user visible impact of the bug is the > potential of inconsistent unreclaimable slab stat visible through > meminfo and vmstat. > > Fixes: 6a486c0ad4dc ("mm, sl[ou]b: improve memory accounting") > Signed-off-by: Shakeel Butt Reviewed-by: Muchun Song