From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8432C433B4 for ; Mon, 10 May 2021 10:34:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 36ABD61075 for ; Mon, 10 May 2021 10:34:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36ABD61075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B10666B0071; Mon, 10 May 2021 06:34:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC0166B0072; Mon, 10 May 2021 06:34:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93A896B0073; Mon, 10 May 2021 06:34:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 76F9A6B0071 for ; Mon, 10 May 2021 06:34:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2F3622470 for ; Mon, 10 May 2021 10:34:18 +0000 (UTC) X-FDA: 78124961796.17.479EDD2 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf11.hostedemail.com (Postfix) with ESMTP id 6B42C2000262 for ; Mon, 10 May 2021 10:33:58 +0000 (UTC) Received: by mail-pf1-f170.google.com with SMTP id 10so13447988pfl.1 for ; Mon, 10 May 2021 03:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GbEg5B1XI9iNST/E/f70TSfKy/dyLBSsJanb6FiDxic=; b=f59ner0D/1qo5HyqTZPlnjeQGdv7ehb8TdlVTo883tA/MXBcSAIscvH2kflRetliLC 2ldbA4AOnMUr/99l1qryK6AOVgMBHunKzEHL/8Dh1NDK9SueoJw/qeG8RdHl2Op/gzox L5wdoQkSdijVZGPr49AJgJ7z3J1DewJWUEkdLff0xSkZZwvITSznBNxdWJFuwOygvU5Y J2dLOxY4NbqekqowGzzndqj7IrRuz4/t+O3heK9u1Xzeb2rJBWbSG9sTkueoQ+GzrKWl dN7rmghZQrBAgGrUeDTAIEJ1MJjXNtmUAmttQKTKQH1rrqCmJdnTbJGYurasAK/zkqwo ykIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GbEg5B1XI9iNST/E/f70TSfKy/dyLBSsJanb6FiDxic=; b=RnFjcafWJZRspd2NNh1hrwhjZZcEnPmgzzGmdiw0pGOsuRhV596Zju0w2hSpbkF+98 fZ975mIosSKO3iZJfayb1FRO9GsSkpqPkCReldHXk5+0y1adL+9+VjVyOwi+COEZPybq A/iSGI/QqRQ+nJZeQ3YjP6DBftSuXAn+Cs5q1pMLwCgw+CW1TLPjAJz5n/ezeQ2mSoKf epC94YUEdokPphGG2hk6auJkzdPfr2gixgBiBlJf9GCKgDlBEGO3EKccOYSAfpGCcy82 yEcrQpKR6f4BDTUDfn1kCLKF0bvdW3unbH4K1JnszRN4T0uRgQGSvsb2zX2rj5rLOUn3 h7LQ== X-Gm-Message-State: AOAM53036kaIDQtIGrZkQBOZbCG1XJymyxPmUjAfYAQMV4f4y5aOO9uZ i/pw5rZQ37qjRCKB8pQDN/dGFV4CmOKyJZ5co4gPMg== X-Google-Smtp-Source: ABdhPJyHUEien5qCpH7v1ah8orxYfkawudbsyoFQsZ5IuBkIgJ3pV0ZZhlDNcBUrx9QSpxHHGhQ+bS4LMxBGt3jpl1s= X-Received: by 2002:a63:b206:: with SMTP id x6mr11623323pge.341.1620642855648; Mon, 10 May 2021 03:34:15 -0700 (PDT) MIME-Version: 1.0 References: <20210510030027.56044-1-songmuchun@bytedance.com> <20210510030027.56044-9-songmuchun@bytedance.com> <20210510100809.GA22664@linux> In-Reply-To: <20210510100809.GA22664@linux> From: Muchun Song Date: Mon, 10 May 2021 18:33:38 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v23 8/9] mm: memory_hotplug: disable memmap_on_memory when hugetlb_free_vmemmap enabled To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , Ingo Molnar , bp@alien8.de, X86 ML , hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , Alexander Viro , Andrew Morton , paulmck@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Joao Martins , Xiongchun duan , fam.zheng@bytedance.com, zhengqi.arch@bytedance.com, linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=f59ner0D; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: 46dwknna43hraa97ykyb1w516yfjb4t4 X-Rspamd-Queue-Id: 6B42C2000262 X-Rspamd-Server: rspam05 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-pf1-f170.google.com; client-ip=209.85.210.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620642838-182588 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 10, 2021 at 6:08 PM Oscar Salvador wrote: > > On Mon, May 10, 2021 at 11:00:26AM +0800, Muchun Song wrote: > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > > index 8cc195c4c861..0d7f595ee441 100644 > > --- a/drivers/acpi/acpi_memhotplug.c > > +++ b/drivers/acpi/acpi_memhotplug.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "internal.h" > > Uhm, I am confused. > Why do we need this here? AFAICS, we do not. > > The function is in memory_hotplug.c, and that alrady has that include. > What am I missing? You are right. That include is redundant. I will remove it from acpi_memhotplug.c. Thanks Oscar. > > > -- > Oscar Salvador > SUSE L3