From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E813C4361B for ; Thu, 10 Dec 2020 15:58:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A752A23D50 for ; Thu, 10 Dec 2020 15:58:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A752A23D50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 00BD66B005D; Thu, 10 Dec 2020 10:58:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFE366B0068; Thu, 10 Dec 2020 10:58:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E12EF6B006C; Thu, 10 Dec 2020 10:58:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id CBFE96B005D for ; Thu, 10 Dec 2020 10:58:40 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 960FC3629 for ; Thu, 10 Dec 2020 15:58:40 +0000 (UTC) X-FDA: 77577830400.26.plate45_5e0fe39273f9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 562D31804B676 for ; Thu, 10 Dec 2020 15:58:40 +0000 (UTC) X-HE-Tag: plate45_5e0fe39273f9 X-Filterd-Recvd-Size: 4968 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 15:58:39 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id b26so4493272pfi.3 for ; Thu, 10 Dec 2020 07:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3JsItjQhJTNChGLKWrMzXdOtHhMmJn68zyS+vNfChmc=; b=YR54goM9BduaqkUSFsN45e6lbCS6jKd0VIuO8EoEZV4bRzXfT2OMkZL9t4rycCznXW 3L+nB8URIDdu6cufleBaMugwkzBJ0bAmqF0tASnrYsCLhXE90t4kb9Fpi+J+fG4bsJly 4UPW1v4jSERSN9+jdEjsc4NfOwDb9a/RIIiYugb5FFWv0opti3lRjgSvAZwG60ZblLwL 8Q5zDENNJsMDc29AnGad8P8sF2aH8qAHCa1+ETX/nWCzL4DxswvNSMVczwx2143XKobK EZFF46MuoFXi2yZCvCbpV2lqjbGdRnJ4/Es9gUtDj8ArJRCqhb32n36XVO4LRVNfilvI 3syw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3JsItjQhJTNChGLKWrMzXdOtHhMmJn68zyS+vNfChmc=; b=R5lCD/3s9m4fqGRjldx0GyWgnmubGRFgZlMtgsRmtyrj+SDpU0I08uUmt4YqR2mPRX s/XL7WE979SNnwib6nQQ+ljESRjNy3fRnKku4cAmxB2bNn4QByfoWO69QZHyNsM70SVY Ei1A41fB0tRrBHiL1+3DShodwFAmwIDrHM/OmUY9WeJxJxxgRRxwzs7sZjoEUkKIi1+H FPZJnQLoDyq6PuLLwY2DcSy1AEFBvJdIJbUlBxYXI0ncEa+WZft5zQXS1KU6E1QF+UGX 0rfoeBTGkJAGEK9FPb8tZDBakXTrvt71GFWL4iaV4BkqFK7+1QjhZSSEEk4JNp1zqQ0X 2yLg== X-Gm-Message-State: AOAM531Xcuy7XAQWp2d92YZ0Lpg1EKcEzDJan2CP/oSN+vAzGQZchXwG oqkvefgzvLbkW178Xsk3B90DVbahJf8w487H/XN1cQ== X-Google-Smtp-Source: ABdhPJxsRJTEViV1kHZNE7S/lb4xqQOiuBcWI/nuOSkpUU7hFgwqcfKWK3LPuNueNSM77fjVgLOMwdLciypLZQHT8Os= X-Received: by 2002:a63:c15:: with SMTP id b21mr7123599pgl.341.1607615918579; Thu, 10 Dec 2020 07:58:38 -0800 (PST) MIME-Version: 1.0 References: <20201210035526.38938-1-songmuchun@bytedance.com> <20201210035526.38938-5-songmuchun@bytedance.com> <20201210144256.GB8538@localhost.localdomain> <20201210144419.GC8538@localhost.localdomain> In-Reply-To: <20201210144419.GC8538@localhost.localdomain> From: Muchun Song Date: Thu, 10 Dec 2020 23:58:02 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v8 04/12] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 10, 2020 at 10:44 PM Oscar Salvador wrote: > > On Thu, Dec 10, 2020 at 03:42:56PM +0100, Oscar Salvador wrote: > > On Thu, Dec 10, 2020 at 11:55:18AM +0800, Muchun Song wrote: > > > The free_vmemmap_pages_per_hpage() which indicate that how many vmemmap > > > pages associated with a HugeTLB page that can be freed to the buddy > > > allocator just returns zero now, because all infrastructure is not > > > ready. Once all the infrastructure is ready, we will rework this > > > function to support the feature. > > > > I would reword the above to: > > > > "free_vmemmap_pages_per_hpage(), which indicates how many vmemmap > > pages associated with a HugeTLB page can be freed, returns zero for > > now, which means the feature is disabled. > > We will enable it once all the infrastructure is there." > > > > Or something along those lines. > > > > > Signed-off-by: Muchun Song > > > > Overall this looks good to me, and it has seen a considerable > > simplification, which is good. > > Some nits/questions below: > > And as I said, I would merge patch#3 with this one. Will do. Thanks. > > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun