From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71418C433F5 for ; Fri, 4 Mar 2022 12:21:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E79618D0002; Fri, 4 Mar 2022 07:21:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E286E8D0001; Fri, 4 Mar 2022 07:21:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF0DB8D0002; Fri, 4 Mar 2022 07:21:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id BD5968D0001 for ; Fri, 4 Mar 2022 07:21:36 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7453499EAA for ; Fri, 4 Mar 2022 12:21:36 +0000 (UTC) X-FDA: 79206614592.26.BF038F9 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf03.hostedemail.com (Postfix) with ESMTP id CF71420019 for ; Fri, 4 Mar 2022 12:21:35 +0000 (UTC) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-2d07ae0b1c4so89111397b3.11 for ; Fri, 04 Mar 2022 04:21:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Va7pm6YfkZeAbrpNqakjmUYEWCDrVBcf2Tch6HcV5QU=; b=a6tmluHUdF4MvXjWaVWyG8XU8E/xgviObiZjdI56I7Nf6V9/94iQLqae+1MK6cZo/v KAQhYhOOBzMhszXbPBM43MyDSegi+YnyM34ZNhGQ8Z+Ya+dMoSbmKW3eG6daKhg4ZOXr mdV26fYFNXHFOKaeypZPbdU+Hhc/oBaiSjolXfEgwlh9f9zp1Xe7KkIRxf0mkzbz2yaG mk3p/PDNBzhLKN0lgKMH626+fuftiP00EEKiDZsY9ohDKDW85JMV2HM+S/lJQJLQNFai /RHA9tByZfoGN3u66XVLwLz7/COxxo1BW0CzdwkuIni2fTsG0AqQX4hYr3bkVzDFIhjV 8Iuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Va7pm6YfkZeAbrpNqakjmUYEWCDrVBcf2Tch6HcV5QU=; b=IrIlymIeYm/fj2vNeM+c1a3/3jr2dXujxwst0PLyZVnPT+ykVOAsEty2e+HTuSUGo+ yRpUS0+sxdOtyIXyq3420Iktm1Cv0CCo0nAOCDGcotEP0+dAG2xpHohgqp6IE572Z3qF SSDWeNRqTeDa8H0Pv/kMlMxEV8ZwaDWNDudJ8IuAAaZi3bHsRdumEndsnJLwFwln3Uoj N46YOK5THlDuklP5ypnX1lVZAhgV5fSYHjEnA+c/sNmZP7J6C+73Tlle+sxMnvOh+tjU P6ptBa4BcQrLrDMFmIA16Das9ApctwTFpZzj5GIe29Rz8yLU58KFTphDBSCBP0XOwmq0 TByg== X-Gm-Message-State: AOAM530p0ENaxYo11KCVnlV9H8rkllF0Ry4EGLs+i0jXgOSlhOiwlS8K zxHNGn3SsEZ+BDvMB2RZNfaneWpPq3y5JWfT6Zy3YA== X-Google-Smtp-Source: ABdhPJyHvKka/8zMcjAtJ/XCTgTutSyz0KT1yEf538GK3/3f0c3A3QcjwBZA7xpOYJmjeYtm/U2YsACZaTS9No71OFI= X-Received: by 2002:a81:6344:0:b0:2d5:e25c:3ceb with SMTP id x65-20020a816344000000b002d5e25c3cebmr39290031ywb.418.1646396495195; Fri, 04 Mar 2022 04:21:35 -0800 (PST) MIME-Version: 1.0 References: <20220304093409.25829-1-linmiaohe@huawei.com> <20220304093409.25829-6-linmiaohe@huawei.com> In-Reply-To: <20220304093409.25829-6-linmiaohe@huawei.com> From: Muchun Song Date: Fri, 4 Mar 2022 20:20:47 +0800 Message-ID: Subject: Re: [PATCH 05/16] mm/migration: fix the confusing PageTransHuge check To: Miaohe Lin Cc: Andrew Morton , Mike Kravetz , Yang Shi , Matthew Wilcox , Huang Ying , Zi Yan , Minchan Kim , Alistair Popple , ave.hansen@linux.intel.com, o451686892@gmail.com, Mina Almasry , John Hubbard , Ralph Campbell , Peter Xu , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Michal Hocko , riel@redhat.com, Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CF71420019 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=a6tmluHU; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: wm1w4iqqoxojf4zdiyo58b96o56xq1w1 X-HE-Tag: 1646396495-478750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 4, 2022 at 5:35 PM Miaohe Lin wrote: > > prep_transhuge_page should be called when PageTransHuge(page) is true. > The newly allocated new_page is not yet PageTransHuge though it could > pass the check as PageTransHuge only checks PageHead now. > > Signed-off-by: Miaohe Lin At least I agree with you. Reviewed-by: Muchun Song