From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E137C433E6 for ; Thu, 7 Jan 2021 08:54:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B8D222313B for ; Thu, 7 Jan 2021 08:54:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8D222313B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2970A8D012A; Thu, 7 Jan 2021 03:53:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 247668D011F; Thu, 7 Jan 2021 03:53:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10F0F8D012A; Thu, 7 Jan 2021 03:53:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id EFA198D011F for ; Thu, 7 Jan 2021 03:53:57 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 24893181AEF2A for ; Thu, 7 Jan 2021 08:53:56 +0000 (UTC) X-FDA: 77678366472.11.scent01_3f00170274e8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id EB704180F8B80 for ; Thu, 7 Jan 2021 08:53:55 +0000 (UTC) X-HE-Tag: scent01_3f00170274e8 X-Filterd-Recvd-Size: 5689 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 08:53:55 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id iq13so1074582pjb.3 for ; Thu, 07 Jan 2021 00:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uUCvsHvCUDgIJnzQ3S6T2paSQVZlNmh4rqaC1Y4MszQ=; b=yNIh/Ok5ue6gPDm5vWv/jp/tjwfZKGL5SV96er+kfs6/JS2hV7CxK4SsZHKNWG1jaL a9A4pvLLjJFL7Sz7h0rIoVicHedckkCPXTOBWbJv+IRVvrReXmy+s46Uab3sxrrnj1dq UXul4RrtScmbTNoKRpLQ/SdDmUxKCeg1b6pJEHefHgEasULvdIYLqe2GDBuva1fUDbwD XcJiPQP7KXg5cIEPlLyV9hdT7NukB3gFocliMczwihPUyUMafZ30xqazgCWOemVk09Af Y+fMIFAz3dErvRT7tVMC+R4lOc/ZmAaZbQNqtfXZwRnKkWkPSkI1RnIH1r94aROoWydJ He2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uUCvsHvCUDgIJnzQ3S6T2paSQVZlNmh4rqaC1Y4MszQ=; b=ct4I3pBenRQN1hT8JO+hEUFXWzC/oDKted8qLR2imXERrd+AW/DbKEjkwvkhqPvAg7 8L/tTgZQqSDal8fxtKJuFR70pLaTXZaKNi266fsZ3hlHPj4nJ+9r8v8Yo69CiXNyjaWa JeklmwXROycM/3bMYfpd5BUJrovDh9sf//fIzrObvARMWYnhjTA4NRxFkuzqmTt3/tyr DkxfYsuytcydlT8Dv5Nd6IeXhcOGVx+gnYv2IER3uoRSa+SRT8HV1oam/PSwugbXst1v 8aDNbV1HpuZf80Cxcw6WC7No3emNB/zu9OoITc0Cuutd8pEtvOeOL+nqs6JG2ANVc/hn tTrQ== X-Gm-Message-State: AOAM5312jGmikMjTfPZEP4+/0iMOJtRfMQgzu2G3ntNlVjM1zXt28HLU vZ6henPTjElITabdhiMDSYq/ZkFNwFym+DouqlwUFw== X-Google-Smtp-Source: ABdhPJy8RktMU98/NVk12c9r+frjlXuodNpdbQALRDB07zw1u882XAAf3iLkeGT5hpdgpaRDdF3a6a4XdODq8+D+tdE= X-Received: by 2002:a17:902:b416:b029:dc:3657:9265 with SMTP id x22-20020a170902b416b02900dc36579265mr8232183plr.24.1610009633963; Thu, 07 Jan 2021 00:53:53 -0800 (PST) MIME-Version: 1.0 References: <20210106084739.63318-1-songmuchun@bytedance.com> <20210106084739.63318-4-songmuchun@bytedance.com> <20210106165632.GT13207@dhcp22.suse.cz> <20210107084146.GD13207@dhcp22.suse.cz> In-Reply-To: <20210107084146.GD13207@dhcp22.suse.cz> From: Muchun Song Date: Thu, 7 Jan 2021 16:53:13 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2 3/6] mm: hugetlb: fix a race between freeing and dissolving the page To: Michal Hocko Cc: Mike Kravetz , Andrew Morton , Naoya Horiguchi , Andi Kleen , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 7, 2021 at 4:41 PM Michal Hocko wrote: > > On Thu 07-01-21 13:39:38, Muchun Song wrote: > > On Thu, Jan 7, 2021 at 12:56 AM Michal Hocko wrote: > > > > > > On Wed 06-01-21 16:47:36, Muchun Song wrote: > > > > There is a race condition between __free_huge_page() > > > > and dissolve_free_huge_page(). > > > > > > > > CPU0: CPU1: > > > > > > > > // page_count(page) == 1 > > > > put_page(page) > > > > __free_huge_page(page) > > > > dissolve_free_huge_page(page) > > > > spin_lock(&hugetlb_lock) > > > > // PageHuge(page) && !page_count(page) > > > > update_and_free_page(page) > > > > // page is freed to the buddy > > > > spin_unlock(&hugetlb_lock) > > > > spin_lock(&hugetlb_lock) > > > > clear_page_huge_active(page) > > > > enqueue_huge_page(page) > > > > // It is wrong, the page is already freed > > > > spin_unlock(&hugetlb_lock) > > > > > > > > The race windows is between put_page() and spin_lock() which > > > > is in the __free_huge_page(). > > > > > > The race window reall is between put_page and dissolve_free_huge_page. > > > And the result is that the put_page path would clobber an unrelated page > > > (either free or already reused page) which is quite serious. > > > Fortunatelly pages are dissolved very rarely. I believe that user would > > > require to be privileged to hit this by intention. > > > > > > > We should make sure that the page is already on the free list > > > > when it is dissolved. > > > > > > Another option would be to check for PageHuge in __free_huge_page. Have > > > you considered that rather than add yet another state? The scope of the > > > spinlock would have to be extended. If that sounds more tricky then can > > > we check the page->lru in the dissolve path? If the page is still > > > PageHuge and reference count 0 then there shouldn't be many options > > > where it can be queued, right? > > > > Did you mean that we iterate over the free list to check whether > > the page is on the free list? > > No I meant to check that the page is enqueued which along with ref count > = 0 should mean it has been released to the pool unless I am missing > something. The page can be on the free list or active list or empty when it is freed to the pool. How to check whether it is on the free list? > -- > Michal Hocko > SUSE Labs