From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763C2C4361B for ; Thu, 10 Dec 2020 16:56:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C274A221E3 for ; Thu, 10 Dec 2020 16:56:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C274A221E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C84E16B006E; Thu, 10 Dec 2020 11:56:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C35E36B0070; Thu, 10 Dec 2020 11:56:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4D556B0071; Thu, 10 Dec 2020 11:56:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 9EC956B006E for ; Thu, 10 Dec 2020 11:56:38 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6515F362E for ; Thu, 10 Dec 2020 16:56:38 +0000 (UTC) X-FDA: 77577976476.13.meal18_29156ee273f9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 3E71B18140B74 for ; Thu, 10 Dec 2020 16:56:38 +0000 (UTC) X-HE-Tag: meal18_29156ee273f9 X-Filterd-Recvd-Size: 4088 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 16:56:37 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id b26so4664019pfi.3 for ; Thu, 10 Dec 2020 08:56:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WNgKN7a4ded1LeBkq8RoIInVbovzz2QvQreFxC7eifA=; b=ngrw6r3STU/Y2YvnJY7eQsNYC2nhNp7w0fatD7eeX09k8h47QOCikE0TwWuSgtp318 UpbWRrRKJw+AxR0sEi/HWSxsLXfRq8h5A6rL3xl/+vhPCJLuOKcE6PHAYgcX6CVcj96r ozPHOIebKkCQ2dasDIPUEULrRnSmQmY7edbwfV7AnRzgnQAd7Z4tGMVR+s+uNSdVjwoa 3Ybb4So9apwKgYFpDY0Va15eDsYUnFOYSOA9122EdxeG8SAekN3QckiVt4NIIQ2p8ogh +LzA6FY+N50reiNcOrc0ywGp3fholP1Vxp1Lk6qEGtbrgH58W+2Rm7GEB7Pt5Mfs0l5R Ud6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WNgKN7a4ded1LeBkq8RoIInVbovzz2QvQreFxC7eifA=; b=skrlvQZhS6q+/GrnAqCqMIlUIftif2qDRR6Qt+OmNz2k3qWpkNVnNB+bqcCIRhm6Ud Ei7PGqDV2pghxMKOGlQCex1NP4oHstVYH6/B8sa1NPTmN37a5SLnfK1jH/YR06WChy2P tnCZQ0tLyFl+QmJ+6PKD6xQNI5UgjY76f6vSl1Hi+tAOVHfTAkBELnM/neF+wpb3uecA juNWm/BcWSbHEjT4KnHaEbJr+bhhmK/J4FPLO+7xBBSAqF4wpo0ww9TB+0DFJGhpZBqu m/j+CZKj5GBJBUA9kI/AXRWuMCBI8SdSAqsZt/A6F8yAqXadOAneqUYBUh3taIm5L+vo RZlw== X-Gm-Message-State: AOAM5310mdL3LwQoVn6duZQfWgD1W4qGvsVizVp9to0cCXcgdF1l6bLL rMJ2t84pZkXJvczcQvucUhenRkdcJswP1JMPmtQBAw== X-Google-Smtp-Source: ABdhPJy9pD/1lJ2qDgAePSWfoMb1GSMyq/JYmVxrm4dOjUbd/QptTorDHdnT6QbcEBnOyfTp+iPIECjZd6VjWW8O9JQ= X-Received: by 2002:a63:c15:: with SMTP id b21mr7349998pgl.341.1607619396305; Thu, 10 Dec 2020 08:56:36 -0800 (PST) MIME-Version: 1.0 References: <20201206101451.14706-1-songmuchun@bytedance.com> <20201206101451.14706-2-songmuchun@bytedance.com> <20201210160413.GH264602@cmpxchg.org> In-Reply-To: <20201210160413.GH264602@cmpxchg.org> From: Muchun Song Date: Fri, 11 Dec 2020 00:56:00 +0800 Message-ID: Subject: Re: [External] Re: [RESEND PATCH v2 01/12] mm: memcontrol: fix NR_ANON_THPS account To: Johannes Weiner Cc: Greg KH , "Rafael J. Wysocki" , Alexey Dobriyan , Andrew Morton , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 11, 2020 at 12:06 AM Johannes Weiner wrote: > > On Sun, Dec 06, 2020 at 06:14:40PM +0800, Muchun Song wrote: > > The unit of NR_ANON_THPS is HPAGE_PMD_NR already. So it should inc/dec > > by one rather than nr_pages. > > > > Fixes: 468c398233da ("mm: memcontrol: switch to native NR_ANON_THPS counter") > > Signed-off-by: Muchun Song > > Acked-by: Johannes Weiner > > But please change the subject to > > 'mm: memcontrol: fix NR_ANON_THPS accounting in charge moving' OK. Will do that. Thanks. -- Yours, Muchun