From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A52C00140 for ; Mon, 15 Aug 2022 06:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E58F76B0073; Mon, 15 Aug 2022 02:53:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E087E6B0074; Mon, 15 Aug 2022 02:53:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCFCC8D0001; Mon, 15 Aug 2022 02:53:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BD3DE6B0073 for ; Mon, 15 Aug 2022 02:53:34 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8FF6E80D7D for ; Mon, 15 Aug 2022 06:53:34 +0000 (UTC) X-FDA: 79800911148.10.2A52CC2 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf18.hostedemail.com (Postfix) with ESMTP id 52E941C0016 for ; Mon, 15 Aug 2022 06:53:33 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id 11so3132092ybu.0 for ; Sun, 14 Aug 2022 23:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=sT4Rmwp/q5F6bitQkSvyQ2IGtxsYD4gW1e3lvIrc3So=; b=PVJGB1kcTWLqtneoLcup/71OtYkgR6MTfpwPXChMx16SRUlh5drf3L+XQBVfhjiuhU ifoO/2Vx5JHkemKtOE+ubS2DzUUOol+0GczZXNhXIr/DQG63Z9YfqgL9Sx/rMqyNuduS 6UlgvfmzRAqjqU1t0k8lTka3QS743t3FmMdgO4fgTHBSZtBG4Z95Zr6tu4TU24+lH7pY RKTtyfFcJMR3GzuC1N5LgJMKyqp6rcsk23rIMe2l91ptRsZU+ERpVo+jh3DaWygkyzoP qUSlE/N7wSFGgKtKWQKex/PWfIegJ3u4SCSMju5+9S8vF6cjHLkaZGzXjVNIVgfOdBGk BfRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=sT4Rmwp/q5F6bitQkSvyQ2IGtxsYD4gW1e3lvIrc3So=; b=YKddt8m85evIxB24wA4ZTNJ8h0aYcSU2JhtjD/MEfYf4JLxqM6lkidmnw6+vA/jaES CAwrZqWxHiEp/pa9JDxK3mR2ilX4RdzMVIgp0aKc3Wk99dNV/Z2qwNc5fOPbncIAvvd0 RrgG/CO8w08UL2XzAYXaXLNqrIY78zaxSFjmTqPFR8BAjmMQdtuwI0b8je90Y5YXuezf raAQ/zh3VVYvL3vGtRXiEqOanY9kZ9NxssZEnMkJuNfGrCkNgGwEce8+XsZvfwEut7Yg fkddT+MuLSgDvM66evgenzdxzj9c54bhI0EoHTz2v0WAtCUmx6PS5iT6aaoU1HSutT1P xeDA== X-Gm-Message-State: ACgBeo0uGYSrvgZg9saMZww0AAGWBj7yNvsgqjj+ZMxQ2q0ndLElRQcP S22OCLCKJ81T18TidnyuJBQ6BoW91d9N1vFLLHbpWg== X-Google-Smtp-Source: AA6agR52HmNM/t4HOkP9haOpcbcHC2M4sJ/Rx0X7wWhxzsNFERuWHgZ9SKAqn511srRD8c3TL+if5O/4y6cT+H39M7c= X-Received: by 2002:a05:6902:1007:b0:677:84d:61d5 with SMTP id w7-20020a056902100700b00677084d61d5mr10638354ybt.46.1660546412362; Sun, 14 Aug 2022 23:53:32 -0700 (PDT) MIME-Version: 1.0 References: <20220811081913.102770-1-liliguang@baidu.com> In-Reply-To: <20220811081913.102770-1-liliguang@baidu.com> From: Muchun Song Date: Mon, 15 Aug 2022 14:52:56 +0800 Message-ID: Subject: Re: [PATCH] mm: correctly charge compressed memory to its memcg To: liliguang Cc: Cgroups , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660546414; a=rsa-sha256; cv=none; b=csyhwLujVY+5OyHKOUT+WMzrVp1YKRG+pevyxn6K1JiCT4G+6fvhtCG5hMxWlhbUTKZUCz OeJlgs60q2uwVHdyY2ZA7BPQPe5JjioZjRl+MBkJXl2mr6q9XUULbmZBF++Ph2TcZFLeuj KL1ovPivpUPJjQ39JJKl2AegT8QLo0U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=PVJGB1kc; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660546414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sT4Rmwp/q5F6bitQkSvyQ2IGtxsYD4gW1e3lvIrc3So=; b=fVcFnzfmbXNtSPDBdezDSlPMDyVISPhuXvMes3K9u1EwHnerIiXb74lOBDpR0rawS2rpE8 o3TlP0gAJh9btKeAZeXPv8b46uHc1GtN77h5WhQOa1qrrbiOXBFcwtSzhX1Hypq7ITc3AQ jHHV6nPxM3r2DLeczOC/aPJFl6cOoeU= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 52E941C0016 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=PVJGB1kc; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: ydmkup617hsibimwawop5wghmm66r8c8 X-Rspam-User: X-HE-Tag: 1660546413-490166 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 11, 2022 at 4:19 PM liliguang wrote: > > From: Li Liguang > > Kswapd will reclaim memory when memory pressure is high, the > annonymous memory will be compressed and stored in the zpool > if zswap is enabled. The memcg_kmem_bypass() in > get_obj_cgroup_from_page() will bypass the kernel thread and > cause the compressed memory not charged to its memory cgroup. > > Remove the memcg_kmem_bypass() and properly charge compressed > memory to its corresponding memory cgroup. > > Signed-off-by: Li Liguang Reviewed-by: Muchun Song Thanks.