From: Muchun Song <songmuchun@bytedance.com>
To: liliguang <liliguang@baidu.com>
Cc: Cgroups <cgroups@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: correctly charge compressed memory to its memcg
Date: Mon, 15 Aug 2022 14:52:56 +0800 [thread overview]
Message-ID: <CAMZfGtViCehvPoADMZs-ceo3fnGU=_3vNu2i6tywGq0Cpt2meg@mail.gmail.com> (raw)
In-Reply-To: <20220811081913.102770-1-liliguang@baidu.com>
On Thu, Aug 11, 2022 at 4:19 PM liliguang <liliguang@baidu.com> wrote:
>
> From: Li Liguang <liliguang@baidu.com>
>
> Kswapd will reclaim memory when memory pressure is high, the
> annonymous memory will be compressed and stored in the zpool
> if zswap is enabled. The memcg_kmem_bypass() in
> get_obj_cgroup_from_page() will bypass the kernel thread and
> cause the compressed memory not charged to its memory cgroup.
>
> Remove the memcg_kmem_bypass() and properly charge compressed
> memory to its corresponding memory cgroup.
>
> Signed-off-by: Li Liguang <liliguang@baidu.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
next prev parent reply other threads:[~2022-08-15 6:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220811081913.102770-1-liliguang@baidu.com>
[not found] ` <YvWa9MOQWBICInjO@P9FQF9L96D.corp.robot.car>
2022-08-12 21:56 ` Shakeel Butt
2022-08-13 0:43 ` Yosry Ahmed
2022-08-15 2:52 ` Li,Liguang
2022-08-15 8:09 ` Yosry Ahmed
2022-08-15 11:48 ` Li,Liguang
2022-08-15 13:46 ` Yosry Ahmed
2022-08-15 15:31 ` Johannes Weiner
2022-08-15 15:42 ` Yosry Ahmed
2022-08-15 16:16 ` Yosry Ahmed
2022-08-15 17:47 ` Johannes Weiner
2022-08-15 17:55 ` Yosry Ahmed
2022-08-16 22:19 ` Shakeel Butt
2022-08-15 6:52 ` Muchun Song [this message]
2022-08-15 15:20 ` Johannes Weiner
2022-08-17 17:17 ` Andrew Morton
2022-11-14 19:48 Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZfGtViCehvPoADMZs-ceo3fnGU=_3vNu2i6tywGq0Cpt2meg@mail.gmail.com' \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=liliguang@baidu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox