From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 320F6C433EF for ; Wed, 16 Mar 2022 08:50:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9DB08D0002; Wed, 16 Mar 2022 04:50:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4D248D0001; Wed, 16 Mar 2022 04:50:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EF348D0002; Wed, 16 Mar 2022 04:50:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 902CE8D0001 for ; Wed, 16 Mar 2022 04:50:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 48BC8A30A2 for ; Wed, 16 Mar 2022 08:50:43 +0000 (UTC) X-FDA: 79249628766.22.074B904 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf15.hostedemail.com (Postfix) with ESMTP id 2FDE5A0011 for ; Wed, 16 Mar 2022 08:50:42 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id y142so3106415ybe.11 for ; Wed, 16 Mar 2022 01:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bg/byEWlTWIwifYckEgQwSgSeHn+FEnQHWnGn7POTSs=; b=KfoJ64Qqg382BsKMbnA/sTahOKPrspF5pI84AyTYRRs+Defudw6y1KfA+aloBCFx3Q aLYxCaA64PlAMKcVvhL0vAi38YRho9oahm15F31M51Kbug6TRYtp/mTueY8xertFLrHY IzRWzhVbvhosIv0oaayfcrbYhzmo0VCvURHtNXvdbzWyEuKre4yCsF4FxKe2hFNwDr88 bMADaAjIKaQ6Ge4zfHuNf4KdgDeSRD5+2P644B+W95jWl5R3OPGkGXqAkfs4KS1KOlX9 eOE80pZBJpa82+6AG1pJoFktg4wZiEzyxZ1b4D528N3ZaXEc2lU3ZQqj8hVyRgmQVoRj JqnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bg/byEWlTWIwifYckEgQwSgSeHn+FEnQHWnGn7POTSs=; b=pwduSklbEGu4IRZ41qe7LFWVFNQlbfcpWSOVXzdkIVVU114KtpVNTpr+BvoGfbh6Dt T+EOel3LOBXv9FbitVZ7afEodmKvBVJDO5PepCwBgbN7GpI3ka5dPsre6VDTosJHW7+e FqxXNVpBNDx3mvNducd19yVEdsUncb6yVyMKgVkLz2Rie6MBdG35ANqBKMnlz38TuJfn FuqjFGII/CnPI0TPAwlZ8fNad44JsthWeD+icOPz2CYYbVEkquuXPvWc4pAwZJWuqVA9 mqgZstSvnm+v7HICRnYsnvOdAc8whsCWZVrnqeTJ52iwX87kfvDmlAMwrN28k3VL5i/a yW4Q== X-Gm-Message-State: AOAM530FJdVo6WlBwgpLURwF6v1PbqXImkoM0nT4WJD4jYX268MqeIUT jmcg2PP8XxhMbLOR9kDGqKVCS6WyrMVSC1TqB6ELq42SezpS+Q== X-Google-Smtp-Source: ABdhPJzQXBkBdb0q5ntMDsNA/5LETFJLW66NOMZ828aO4vfYyl/rSAPR7nDThocO00eKUQ5R8NI3oXwVIOf7j4K6dl0= X-Received: by 2002:a25:dc4:0:b0:629:2337:f9ea with SMTP id 187-20020a250dc4000000b006292337f9eamr27008652ybn.6.1647420641261; Wed, 16 Mar 2022 01:50:41 -0700 (PDT) MIME-Version: 1.0 References: <20220316031602.377452-1-luofei@unicloud.com> In-Reply-To: <20220316031602.377452-1-luofei@unicloud.com> From: Muchun Song Date: Wed, 16 Mar 2022 16:48:51 +0800 Message-ID: Subject: Re: [PATCH v2] hugetlb: Fix comments about avoiding atomic allocation of vmemmap pages To: luofei Cc: Mike Kravetz , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2FDE5A0011 X-Stat-Signature: p8e1xmj5r4bx7bsmd97ru6ohxruw17uj Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=KfoJ64Qq; spf=pass (imf15.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-HE-Tag: 1647420642-957241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 16, 2022 at 11:16 AM luofei wrote: > > Since there is no longer an atomic allocation of vmemmap pages, > but a fixed flag(GFP_KERNEL | __GFP_NORETRY | __GFP_THISNODE) is > used. The description of atomicity here is some what inappropriate. > > And the atomic parameter naming of update_and_free_page() may > be misleading, add a comment here. > > Signed-off-by: luofei Reviewed-by: Muchun Song Thanks.