From: Muchun Song <songmuchun@bytedance.com>
To: luofei <luofei@unicloud.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] hugetlb: Fix comments about avoiding atomic allocation of vmemmap pages
Date: Wed, 16 Mar 2022 16:48:51 +0800 [thread overview]
Message-ID: <CAMZfGtVi7zOM7pdj1rv1OY2VyOpKQU45YFjM4KqMEQn=KGHq3w@mail.gmail.com> (raw)
In-Reply-To: <20220316031602.377452-1-luofei@unicloud.com>
On Wed, Mar 16, 2022 at 11:16 AM luofei <luofei@unicloud.com> wrote:
>
> Since there is no longer an atomic allocation of vmemmap pages,
> but a fixed flag(GFP_KERNEL | __GFP_NORETRY | __GFP_THISNODE) is
> used. The description of atomicity here is some what inappropriate.
>
> And the atomic parameter naming of update_and_free_page() may
> be misleading, add a comment here.
>
> Signed-off-by: luofei <luofei@unicloud.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
prev parent reply other threads:[~2022-03-16 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 3:16 luofei
2022-03-16 8:48 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZfGtVi7zOM7pdj1rv1OY2VyOpKQU45YFjM4KqMEQn=KGHq3w@mail.gmail.com' \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luofei@unicloud.com \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox