From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BAA2C433EF for ; Fri, 1 Apr 2022 08:52:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5988F8D0002; Fri, 1 Apr 2022 04:51:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 547C38D0001; Fri, 1 Apr 2022 04:51:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40F368D0002; Fri, 1 Apr 2022 04:51:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 313C28D0001 for ; Fri, 1 Apr 2022 04:51:52 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0BB3C2154 for ; Fri, 1 Apr 2022 08:51:42 +0000 (UTC) X-FDA: 79307692044.09.0CEBAF2 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf11.hostedemail.com (Postfix) with ESMTP id 3217740017 for ; Fri, 1 Apr 2022 08:51:41 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-2e6650cde1bso24590667b3.12 for ; Fri, 01 Apr 2022 01:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RjJ1bjnY3yC7gcQ9YS5qaiBX2qOX1uixT7iNAUTqu/s=; b=Qwke0j5cNSfW+QLAH417fkXqqvprzeTvgfWCezbyZYAcEuhBvPf4dIQLDqUxYy5r4r 8k1qcZc9m5ZitSY2JR/87JiB+hc3YH9NocaAR8HGVFi6mZ31IEuADhnGdefDZw+t6DWm 4p90eKLtxVyL7ziemcb3oedo3B4CbgR2XdUZ2LQnlDDGjiHfK57zvc4QwEcXqpPADubr fQ/axZWhJGrGzckbvq9C2XznH1yhsnZvSw/vt59JucefYVYR6Bl4ENmgVL5WqR45XGR7 XGX8adUN/4eMm91t8lzcv1sdzdZhW2BeSaddPisTG+exrR9XJtMrBWdqRB6Qs4Djz7n5 kTJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RjJ1bjnY3yC7gcQ9YS5qaiBX2qOX1uixT7iNAUTqu/s=; b=zAEX1XAwDSdPA4L9r63SnBBiebWOvvbHUwE4V9Id/zsjFfku/MiaRnSGQl0KAapI22 zkmRzKgosruzxZ1jrKXTmS5Jm/dlZFmxmaWv9KIScU8xW+ycR/9vL3OBW8bXcbpCjZFi sbR8D4/iwD2Se9w5di8rGsD3r44VDUe6OvHAX2NZWlGYkRISys3T6qbI1xylqgUs9hZy QWwFTxMYut/7CsnmTzDwEoQnJxnjIOAOcKy3T/eCJtm8u5oxOYhc7OPg6w0jTIn/p36H K+ssXIaA3WZ7wftLxpA9MsnzL/9Mk7iP2AmPV0MN79lucKKnyAhkPMMiaBEWkLlZLxpD 9jog== X-Gm-Message-State: AOAM531Rx/6W7DKF9CgqlOxj6y7xC8YArtojOAn+C5O2fQb5GUavrgkn 5bGeP9Y3PpurA+VjlaLCnmWt7OARuIq2MUhHMPFUrg== X-Google-Smtp-Source: ABdhPJwRAy6acFWGBZwFV4R+u5WXDyOLbWjYHwNmm2IBUhuVbI5bly0fqy3QmyeXvU6TE53jQncAnjgNcMES58pgicE= X-Received: by 2002:a81:5dd6:0:b0:2d6:3041:12e0 with SMTP id r205-20020a815dd6000000b002d6304112e0mr8972109ywb.331.1648803100207; Fri, 01 Apr 2022 01:51:40 -0700 (PDT) MIME-Version: 1.0 References: <20220318074529.5261-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 1 Apr 2022 16:50:59 +0800 Message-ID: Subject: Re: [PATCH v5 0/6] Fix some bugs related to ramp and dax To: Qian Cai Cc: Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Andrew Morton , Alistair Popple , Yang Shi , Ralph Campbell , Hugh Dickins , Xiyu Yang , "Kirill A. Shutemov" , Ross Zwisler , Christoph Hellwig , linux-fsdevel , Linux NVDIMM , LKML , Linux Memory Management List , Xiongchun duan , Muchun Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: r39r9unyskhjaqgt5pmi3rp1j3y81w45 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Qwke0j5c; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Queue-Id: 3217740017 X-HE-Tag: 1648803101-832205 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 1, 2022 at 11:44 AM Muchun Song wrot= e: > > On Thu, Mar 31, 2022 at 11:55 PM Qian Cai wrot= e: > > > > On Fri, Mar 18, 2022 at 03:45:23PM +0800, Muchun Song wrote: > > > This series is based on next-20220225. > > > > > > Patch 1-2 fix a cache flush bug, because subsequent patches depend on > > > those on those changes, there are placed in this series. Patch 3-4 > > > are preparation for fixing a dax bug in patch 5. Patch 6 is code cle= anup > > > since the previous patch remove the usage of follow_invalidate_pte(). > > > > Reverting this series fixed boot crashes. > > > > KASAN: null-ptr-deref in range [0x0000000000000018-0x000000000000001f] > > Mem abort info: > > ESR =3D 0x96000004 > > EC =3D 0x25: DABT (current EL), IL =3D 32 bits > > SET =3D 0, FnV =3D 0 > > EA =3D 0, S1PTW =3D 0 > > FSC =3D 0x04: level 0 translation fault > > Data abort info: > > ISV =3D 0, ISS =3D 0x00000004 > > CM =3D 0, WnR =3D 0 > > [dfff800000000003] address between user and kernel address ranges > > Internal error: Oops: 96000004 [#1] PREEMPT SMP > > Modules linked in: cdc_ether usbnet ipmi_devintf ipmi_msghandler cppc_= cpufreq fuse ip_tables x_tables ipv6 btrfs blake2b_generic libcrc32c xor xo= r_neon raid6_pq zstd_compress dm_mod nouveau crct10dif_ce drm_ttm_helper ml= x5_core ttm drm_dp_helper drm_kms_helper nvme mpt3sas nvme_core xhci_pci ra= id_class drm xhci_pci_renesas > > CPU: 3 PID: 1707 Comm: systemd-udevd Not tainted 5.17.0-next-20220331-= 00004-g2d550916a6b9 #51 > > pstate: 104000c9 (nzcV daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) > > pc : __lock_acquire > > lr : lock_acquire.part.0 > > sp : ffff800030a16fd0 > > x29: ffff800030a16fd0 x28: ffffdd876c4e9f90 x27: 0000000000000018 > > x26: 0000000000000000 x25: 0000000000000018 x24: 0000000000000000 > > x23: ffff08022beacf00 x22: ffffdd8772507660 x21: 0000000000000000 > > x20: 0000000000000000 x19: 0000000000000000 x18: ffffdd8772417d2c > > x17: ffffdd876c5bc2e0 x16: 1fffe100457d5b06 x15: 0000000000000094 > > x14: 000000000000f1f1 x13: 00000000f3f3f3f3 x12: ffff08022beacf08 > > x11: 1ffffbb0ee482fa5 x10: ffffdd8772417d28 x9 : 0000000000000000 > > x8 : 0000000000000003 x7 : ffffdd876c4e9f90 x6 : 0000000000000000 > > x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > > x2 : 0000000000000000 x1 : 0000000000000003 x0 : dfff800000000000 > > Call trace: > > __lock_acquire > > lock_acquire.part.0 > > lock_acquire > > _raw_spin_lock > > page_vma_mapped_walk > > try_to_migrate_one > > rmap_walk_anon > > try_to_migrate > > __unmap_and_move > > unmap_and_move > > migrate_pages > > migrate_misplaced_page > > do_huge_pmd_numa_page > > __handle_mm_fault > > handle_mm_fault > > do_translation_fault > > do_mem_abort > > el0_da > > el0t_64_sync_handler > > el0t_64_sync > > Code: d65f03c0 d343ff61 d2d00000 f2fbffe0 (38e06820) > > ---[ end trace 0000000000000000 ]--- > > Kernel panic - not syncing: Oops: Fatal exception > > SMP: stopping secondary CPUs > > Kernel Offset: 0x5d8763da0000 from 0xffff800008000000 > > PHYS_OFFSET: 0x80000000 > > CPU features: 0x000,00085c0d,19801c82 > > Memory Limit: none > > ---[ end Kernel panic - not syncing: Oops: Fatal exception ]--- > > Thanks for your report. Would you mind providing the .config? Hi Qian Cai, Would you mind helping me test if the following patch works properly? Thanks. diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c index b3bf802a6435..3da82bf65de8 100644 --- a/mm/page_vma_mapped.c +++ b/mm/page_vma_mapped.c @@ -210,7 +210,8 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *= pvmw) */ pmde =3D READ_ONCE(*pvmw->pmd); - if (pmd_leaf(pmde) || is_pmd_migration_entry(pmde)) { + if (pmd_trans_huge(pmde) || is_pmd_migration_entry(pmde) || + (pmd_present(pmde) && pmd_devmap(pmde))) { pvmw->ptl =3D pmd_lock(mm, pvmw->pmd); pmde =3D *pvmw->pmd; if (!pmd_present(pmde)) {