From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E858CC2B9F7 for ; Wed, 26 May 2021 04:05:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D26461437 for ; Wed, 26 May 2021 04:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D26461437 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BD7D6B0036; Wed, 26 May 2021 00:05:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8793D6B006E; Wed, 26 May 2021 00:05:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70DCD6B0070; Wed, 26 May 2021 00:05:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 3D0C46B0036 for ; Wed, 26 May 2021 00:05:28 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C32B68152 for ; Wed, 26 May 2021 04:05:27 +0000 (UTC) X-FDA: 78182042694.40.F405336 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf18.hostedemail.com (Postfix) with ESMTP id B8B5C20007FE for ; Wed, 26 May 2021 04:05:20 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id o17-20020a17090a9f91b029015cef5b3c50so14465041pjp.4 for ; Tue, 25 May 2021 21:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3BSUH4FuVxkufE1DOQYaSypRB1C5PlZHQOf7I5N4qm0=; b=aJQNDouTB3w+wgh3Hd+Jk4J0GaQw1qwLDAhO40TzZVJvWseeC3o617s3lWDg6cLs+c HLn/anb5XFSekt11I9BhnpJEBGkso3sUd03oVLiB4DP0AkcmC2TOIH/hnpluvpkhKvYm 4pjIUu3hm+ZT/KLw0xOePxUETZUPD9Ysj2SmNuyMPI36aVCRFmJPlqq2R5LrjgaUYyu6 LLs6xl/0z0T1HUWK80sHV3PsEbh50pvIDQ8Oif5dRNqWPgXAXyQoLWew7dhh2U5Ahgg7 2g0FWVjs2CKIhPZbfjQkIixOcljDlQJcfnv9mJ2y09IT/Nvp7mJPvORHqAgg68xVNuxc czqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3BSUH4FuVxkufE1DOQYaSypRB1C5PlZHQOf7I5N4qm0=; b=QyxzwNSq0kycKp2QBC4MDHDpobwOrF2XaZKz2zBiQPDZif0i2NninH0Jumj6TIqlbi qrX3JNnObQAnnGPCR7B4hluui9UyHzSEPsX3bhEPoyUgertJ8ThcJpKM9AUWpTduCgqo efPOdE59bx8dsNOFUe8/drXpPjTCdq1f6bC80qcrIIZUIyS29OYqYQaNylHI2Wajr/NC Q1jMWL0eLBRKI7bTmbUyWh2gxdKJtpjyiXNfMLrvyznghQfwb5G5HZa+TWU5JiCl5++R PqEsolIFXQxxlTf2BYxr0axRf6m+8aWewcZbC4VSQ2+9lQYwTSVosauNB8/8hl1w/joK NwSQ== X-Gm-Message-State: AOAM5332TlN3vZoVoFXDSCIfFRWEJLwPa3VVahKAoaQond6xrsNyHbGX vgucKzv4QybNivz/UC1rvQOTb2DFp6ItKJPUqzw3Vg== X-Google-Smtp-Source: ABdhPJwbh22bNdc31Uwfexj6GfFDlu+AgjcqrwJ82u9T8hZyfZrPtsBU8WI6o+cOar12wlXYaJS6KTgfi9jbUz84ZZ8= X-Received: by 2002:a17:90a:bd05:: with SMTP id y5mr33782211pjr.229.1622001925808; Tue, 25 May 2021 21:05:25 -0700 (PDT) MIME-Version: 1.0 References: <20210526025625.601023-1-swboyd@chromium.org> <20210526025625.601023-2-swboyd@chromium.org> In-Reply-To: <20210526025625.601023-2-swboyd@chromium.org> From: Muchun Song Date: Wed, 26 May 2021 12:04:49 +0800 Message-ID: Subject: Re: [External] [PATCH v2 1/4] slub: Restore slub_debug=- behavior To: Stephen Boyd Cc: Andrew Morton , LKML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Linux Memory Management List , Petr Mladek , Joe Perches Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B8B5C20007FE Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=aJQNDouT; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam03 X-Stat-Signature: h3pfe4ka3egmwe85gqnjeb5mdqk5dzdk X-HE-Tag: 1622001920-662651 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 26, 2021 at 10:56 AM Stephen Boyd wrote: > > Passing slub_debug=- on the kernel commandline is supposed to disable > slub debugging. This is especially useful with CONFIG_SLUB_DEBUG_ON > where the default is to have slub debugging enabled in the build. Due to > some code reorganization this behavior was dropped, but the code to make > it work mostly stuck around. Restore the previous behavior by disabling > the static key when we parse the commandline and see that we're trying > to disable slub debugging. > > Cc: Vlastimil Babka > Fixes: e17f1dfba37b ("mm, slub: extend slub_debug syntax for multiple blocks") Is it caused by the commit ca0cab65ea2b ("mm, slub: introduce static key for slub_debug()")? > Signed-off-by: Stephen Boyd > --- > mm/slub.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/slub.c b/mm/slub.c > index 438fa8d4c970..2f53e8a9c28e 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1396,6 +1396,8 @@ static int __init setup_slub_debug(char *str) > out: > if (slub_debug != 0 || slub_debug_string) > static_branch_enable(&slub_debug_enabled); > + else > + static_branch_disable(&slub_debug_enabled); > if ((static_branch_unlikely(&init_on_alloc) || > static_branch_unlikely(&init_on_free)) && > (slub_debug & SLAB_POISON)) > -- > https://chromeos.dev >