From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD51C433E0 for ; Thu, 7 Jan 2021 11:38:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A67B2333C for ; Thu, 7 Jan 2021 11:38:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A67B2333C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5140E8D0136; Thu, 7 Jan 2021 06:38:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49BD88D011F; Thu, 7 Jan 2021 06:38:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 363C78D0136; Thu, 7 Jan 2021 06:38:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 1D0C08D011F for ; Thu, 7 Jan 2021 06:38:43 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D94901EE6 for ; Thu, 7 Jan 2021 11:38:42 +0000 (UTC) X-FDA: 77678781684.12.club30_2913afc274e9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id B3ABD18012B46 for ; Thu, 7 Jan 2021 11:38:42 +0000 (UTC) X-HE-Tag: club30_2913afc274e9 X-Filterd-Recvd-Size: 6591 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 11:38:41 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id x12so3333253plr.10 for ; Thu, 07 Jan 2021 03:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oSIDm95nmFNLU0RfgmsDhpelBGAdD7UZISvgZRUQxDA=; b=CexN865DftZyxIRECrgQK9qHf4ouW+/d/KCO+1McQOZPjIypqm7uDPNQikrJDXPZYk r3hoSREJyEr1CQqG6OVok7rQs56Tc0FYZsEWfwTiACI/5dkw52PLpD1jLFkzQ+UwunXo cSWNFTl1PUbdbB1IbGi/fETmPJfPO9AvntL0DemzDgORYY54rYKrAmHbzkaOA4fj0nK8 Yqzo3YHSFeaMceltvUtLKBiT9TAJvKAPGHwH/ddgjrWGE8Np6cQ8nuTsTtDFonpJt3Gr u/l1UO1DYWBaJ4+noGGYOSwSoEVnY1lqOJf9Wx7O/GZe+/qh9arqNiP8ibJeyA1Q/+nK 20xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oSIDm95nmFNLU0RfgmsDhpelBGAdD7UZISvgZRUQxDA=; b=KCZt2YrBE5zQRlpswZgHu/39AQdbVc8kznXNmQ5DlMNsQ3S1QRoxhTqKUo05cybKvB y1NZIr+KiH/OJK1H9opJQIiyqLTG/OfB+ZzpxvMuBNd7XzmBL3FmKyPfhr9XZCTVyqcj 89nflUQWkGH9V+rmFd64Y8oL2Bl2rQjExeD3PPK9X3OIrsgJs24o2SIWks8+3qyFCbwu dNPHYfSvlS1DPcIpLmxmhMItGJI3lMFU26wOBxlJR70/vSCURQwbpBIKCFmZAQqbUIst R7SEtL0kxUjnnylJ7X1TMxMv30qBJIIpthTPw8Mo6pE/rMdQwxzip2oQEONZitpxavv/ /3Kg== X-Gm-Message-State: AOAM533FtKrTtaoEoC1+ptKgNXTUukuOTG2/GENVrd+Rqn0oo8QMsd+W n7sQK2yxpilqxWU4Kb8eQDLd3zSL9xtTP60sl359hri1D0P6NHrtUFc= X-Google-Smtp-Source: ABdhPJxPYevznrszZ8GNHJjcEGFaIq9f8IvfrsbX2N9xLULjb/nfyVjKe9RE/B36Ww0j7vKCzbdH8+rhDJrMn8M9kr4= X-Received: by 2002:a17:902:b416:b029:dc:3657:9265 with SMTP id x22-20020a170902b416b02900dc36579265mr8732224plr.24.1610019520708; Thu, 07 Jan 2021 03:38:40 -0800 (PST) MIME-Version: 1.0 References: <20210106084739.63318-1-songmuchun@bytedance.com> <20210106084739.63318-4-songmuchun@bytedance.com> <20210106165632.GT13207@dhcp22.suse.cz> <20210107084146.GD13207@dhcp22.suse.cz> <20210107111827.GG13207@dhcp22.suse.cz> In-Reply-To: <20210107111827.GG13207@dhcp22.suse.cz> From: Muchun Song Date: Thu, 7 Jan 2021 19:38:00 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2 3/6] mm: hugetlb: fix a race between freeing and dissolving the page To: Michal Hocko Cc: Mike Kravetz , Andrew Morton , Naoya Horiguchi , Andi Kleen , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 7, 2021 at 7:18 PM Michal Hocko wrote: > > On Thu 07-01-21 16:53:13, Muchun Song wrote: > > On Thu, Jan 7, 2021 at 4:41 PM Michal Hocko wrote: > > > > > > On Thu 07-01-21 13:39:38, Muchun Song wrote: > > > > On Thu, Jan 7, 2021 at 12:56 AM Michal Hocko wrote: > > > > > > > > > > On Wed 06-01-21 16:47:36, Muchun Song wrote: > > > > > > There is a race condition between __free_huge_page() > > > > > > and dissolve_free_huge_page(). > > > > > > > > > > > > CPU0: CPU1: > > > > > > > > > > > > // page_count(page) == 1 > > > > > > put_page(page) > > > > > > __free_huge_page(page) > > > > > > dissolve_free_huge_page(page) > > > > > > spin_lock(&hugetlb_lock) > > > > > > // PageHuge(page) && !page_count(page) > > > > > > update_and_free_page(page) > > > > > > // page is freed to the buddy > > > > > > spin_unlock(&hugetlb_lock) > > > > > > spin_lock(&hugetlb_lock) > > > > > > clear_page_huge_active(page) > > > > > > enqueue_huge_page(page) > > > > > > // It is wrong, the page is already freed > > > > > > spin_unlock(&hugetlb_lock) > > > > > > > > > > > > The race windows is between put_page() and spin_lock() which > > > > > > is in the __free_huge_page(). > > > > > > > > > > The race window reall is between put_page and dissolve_free_huge_page. > > > > > And the result is that the put_page path would clobber an unrelated page > > > > > (either free or already reused page) which is quite serious. > > > > > Fortunatelly pages are dissolved very rarely. I believe that user would > > > > > require to be privileged to hit this by intention. > > > > > > > > > > > We should make sure that the page is already on the free list > > > > > > when it is dissolved. > > > > > > > > > > Another option would be to check for PageHuge in __free_huge_page. Have > > > > > you considered that rather than add yet another state? The scope of the > > > > > spinlock would have to be extended. If that sounds more tricky then can > > > > > we check the page->lru in the dissolve path? If the page is still > > > > > PageHuge and reference count 0 then there shouldn't be many options > > > > > where it can be queued, right? > > > > > > > > Did you mean that we iterate over the free list to check whether > > > > the page is on the free list? > > > > > > No I meant to check that the page is enqueued which along with ref count > > > = 0 should mean it has been released to the pool unless I am missing > > > something. > > > > The page can be on the free list or active list or empty when it > > is freed to the pool. How to check whether it is on the free list? > > As I've said, I might be missing something here. But if the page is > freed why does it matter whether it is on a active list or free list > from the dissolve operation POV? As you said "check the page->lru". I have a question. How to check the page->lru in the dissolve path? BTW, dissolve_free_huge_page aims to free the page to buddy allocator. put_page (for HugeTLB page) aims to free the page to the hugepage pool. > -- > Michal Hocko > SUSE Labs