From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACF0C4361B for ; Fri, 11 Dec 2020 15:13:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F205C22AAD for ; Fri, 11 Dec 2020 15:13:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F205C22AAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8E1336B006E; Fri, 11 Dec 2020 09:15:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 891C76B0070; Fri, 11 Dec 2020 09:15:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A7756B0071; Fri, 11 Dec 2020 09:15:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 6264D6B006E for ; Fri, 11 Dec 2020 09:15:01 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 255E0181AEF3F for ; Fri, 11 Dec 2020 14:15:01 +0000 (UTC) X-FDA: 77581198002.06.laugh60_021308327401 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 023CD1003C07B for ; Fri, 11 Dec 2020 14:15:00 +0000 (UTC) X-HE-Tag: laugh60_021308327401 X-Filterd-Recvd-Size: 4835 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Dec 2020 14:15:00 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id z12so2256516pjn.1 for ; Fri, 11 Dec 2020 06:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5f1oHmcol2mHx6bC5gFH8ezh95GR9pifCliLgoZXiHI=; b=Bzgx3oPWqgw2n1k0AK1q+w30PZWgSi1dqKV5jw4NTUlxXSt/Em/bVVrqnzOIlv2DBr fjVuO3tsgvvmQZXK8pbVfZGMi5nU1uZGf1M1er6k2a0orAK6Q5bUSNTN7OkFM7LX8abp qcAPpTeDQaBnKIIg7RisfNNKMSBGR05hlFYUQeX4Lrrzo7olSSxraRJiRhPjAlTwwle6 GkPMDER0cf/tv5691W+YJs5CjQVWbTBgYzNJTYFqgH0KFlQro1pPQAw1eB47CptCcgsn 5zvRtWb/qbSs9IZWA4zUdMkPOK9ReXwzcO6X9zb51a0t10AV6YQYrW+R5nCR/WVstc2O ixuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5f1oHmcol2mHx6bC5gFH8ezh95GR9pifCliLgoZXiHI=; b=SLo56xiwsFSp7kZaKfILn6ggyxg2mad8WrsIeRueysSNPRAFzgDT2zPS3g7SrPKCzM wi7t9+tV/MtaU8KrIP7+5t6Ztq7oV50C3mdY2ujXMM78qh6m1kZoq/u2trSZctq61Fp3 2NCYpk5hh3AbKOJymEuDKvOSt2nHdLSzR7A13REcUrpINTXqWN6ttfQZP6LuethQHR+l YhwAx3P8Qdhd/11KjYkJWvrACu/JdqZl4R5avbIo/0agrUUsg5SCeMVOfW6euByXnF4D MQPki7kCFliPyPD8y+qEyKEkUb6vy9VaTI/Y16wFSWYuyfjkq+utbLegW36tUQK4MhQ9 0MXw== X-Gm-Message-State: AOAM5316cScAVuRoNlWaHzkI7xoOs+juKw+wIGdNwDqlyfFDLPoTzIv1 hI+gBtdRMc+iRt5n5JC61EfoUYPj9Iy8dVlCbvoKvA== X-Google-Smtp-Source: ABdhPJzFtHnSD7yguh0R/UPqyIWabyj8rwu4adQbmM5SUJFG7UlQpVcwg63WOndZqN2uDqjudVC4YaWLzSNwdIGIi84= X-Received: by 2002:a17:902:bb92:b029:d9:e9bf:b775 with SMTP id m18-20020a170902bb92b02900d9e9bfb775mr11319858pls.24.1607696099031; Fri, 11 Dec 2020 06:14:59 -0800 (PST) MIME-Version: 1.0 References: <20201211041954.79543-1-songmuchun@bytedance.com> <20201211041954.79543-4-songmuchun@bytedance.com> <20201211135737.GA2443@casper.infradead.org> In-Reply-To: <20201211135737.GA2443@casper.infradead.org> From: Muchun Song Date: Fri, 11 Dec 2020 22:14:22 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v4 3/7] mm: memcontrol: convert NR_FILE_THPS account to pages To: Matthew Wilcox Cc: Greg KH , "Rafael J. Wysocki" , Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Shakeel Butt , Roman Gushchin , Sami Tolvanen , Feng Tang , Neil Brown , Joonsoo Kim , Randy Dunlap , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 11, 2020 at 9:57 PM Matthew Wilcox wrote: > > On Fri, Dec 11, 2020 at 12:19:50PM +0800, Muchun Song wrote: > > +++ b/mm/filemap.c > > @@ -207,7 +207,7 @@ static void unaccount_page_cache_page(struct address_space *mapping, > > if (PageTransHuge(page)) > > __dec_lruvec_page_state(page, NR_SHMEM_THPS); > > } else if (PageTransHuge(page)) { > > - __dec_lruvec_page_state(page, NR_FILE_THPS); > > + __mod_lruvec_page_state(page, NR_FILE_THPS, -HPAGE_PMD_NR); > > + __mod_lruvec_page_state(page, NR_FILE_THPS, -nr); Thank you. > > > +++ b/mm/huge_memory.c > > @@ -2748,7 +2748,8 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) > > if (PageSwapBacked(head)) > > __dec_lruvec_page_state(head, NR_SHMEM_THPS); > > else > > - __dec_lruvec_page_state(head, NR_FILE_THPS); > > + __mod_lruvec_page_state(head, NR_FILE_THPS, > > + -HPAGE_PMD_NR); > > + __mod_lruvec_page_state(head, NR_FILE_THPS, > + -thp_nr_pages(head)); > Thanks. -- Yours, Muchun