From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5BCC433F5 for ; Sun, 27 Mar 2022 05:43:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 011DA8D0002; Sun, 27 Mar 2022 01:43:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F03E38D0001; Sun, 27 Mar 2022 01:43:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA4DC8D0002; Sun, 27 Mar 2022 01:43:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id C7E518D0001 for ; Sun, 27 Mar 2022 01:43:41 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 76FA6182534D6 for ; Sun, 27 Mar 2022 05:43:41 +0000 (UTC) X-FDA: 79289074242.25.659066E Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf10.hostedemail.com (Postfix) with ESMTP id 7F30CC003C for ; Sun, 27 Mar 2022 05:43:40 +0000 (UTC) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-2ea1b9b3813so13846067b3.2 for ; Sat, 26 Mar 2022 22:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kp+n7MjmnLTJ4vOAA537LLcCjh6KRC0etIIuCa/wcqQ=; b=icDZzCAPN5GzbIs+eeeY5TNGBRG9fV3oU6z+g0Dshz7qXNcvNe25C09q2gQBxiVQKm BPvx9nsC8xFm+raqnG0tK6LL4xi/wSZ69riv36QGC9YvgpI2rEq9CqUsz7JhVmBn2gYR W3zAr1bQe+0ML/qTY18DiE8AK1LRW6NMRf6CXu/8ujOCOAg3851aNlzvCSF+ORKoq8Kh ty696EWA9jVAe8eGmqO5/uMA7L6CsQY/8BYppV4yD3ILqroCSC8AriglDCA2PuQ3Kt2k XCWm6/8wntsx4G9rdOE0LuUcoookkpQKFIlP+JA5xl1vcIsLErdvCsQ4ndWV7dWYwgCx kLzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kp+n7MjmnLTJ4vOAA537LLcCjh6KRC0etIIuCa/wcqQ=; b=Ihn8uIoSxYcRDILqcuNGXroda6ddyQjZDt/P3DY8nsj2r51GyRto9XntdxsP+nXj4C wp9i2F7I2sEigh/k2Mep8gSjxupZ07wLzPbny6sCWPP6j3RvHlsiUv4dJHT8HOOphEw3 HZLr5UYtKKf6VLLYWm4G7hTfnAGXuJi4XHoGiMGC/sMZJfDhukpm05Q8+W+pKGOSrjz7 HPC6Md6/gjceWwwMkMv8+X5ttnRPHDQBfF45M+Sq0xoKBX14AOiiy6+Q067i5nBLpbMF Edj264d9CkuSyMLYi3abKUuoy4Jk+b9Mk0gdFsbGjbEm63qYr2wV2T3ANVo2gYGjwNUo Anhw== X-Gm-Message-State: AOAM5312h+c56G1KH/ICS9j9tjopj1z940wAyI2VNPHOpJTNj4H+dsDF 3LN6QH+Kwv4eYr+xJsVjxPBwJ7Y82jDCSi+l9Yr7Dg== X-Google-Smtp-Source: ABdhPJwIvL78p8zBSpKdXW3OcMDN5VYLW8WBGkkTHwZ1qqfNPoxw6rEtsQ28DJ6Hi85h7xXmRkfj7I3ZUMylE9TN7io= X-Received: by 2002:a81:5dd6:0:b0:2d6:3041:12e0 with SMTP id r205-20020a815dd6000000b002d6304112e0mr19479093ywb.331.1648359819570; Sat, 26 Mar 2022 22:43:39 -0700 (PDT) MIME-Version: 1.0 References: <20220327051853.57647-1-songmuchun@bytedance.com> <20220327051853.57647-2-songmuchun@bytedance.com> In-Reply-To: <20220327051853.57647-2-songmuchun@bytedance.com> From: Muchun Song Date: Sun, 27 Mar 2022 13:43:03 +0800 Message-ID: Subject: Re: [PATCH 2/2] mm: kfence: fix objcgs vector allocation To: Linus Torvalds , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin Cc: kasan-dev@googlegroups.com, Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7F30CC003C X-Stat-Signature: 4sjo3mz9a5bf5wjdupctj8m411aesdcz X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=icDZzCAP; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf10.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1648359820-111063 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 27, 2022 at 1:19 PM Muchun Song wrote: > > If the kfence object is allocated to be used for objects vector, then > this slot of the pool eventually being occupied permanently since > the vector is never freed. The solutions could be 1) freeing vector > when the kfence object is freed or 2) allocating all vectors statically. > Since the memory consumption of object vectors is low, it is better to > chose 2) to fix the issue and it is also can reduce overhead of vectors > allocating in the future. > > Fixes: d3fb45f370d9 ("mm, kfence: insert KFENCE hooks for SLAB") > Signed-off-by: Muchun Song Since it cannot be compiled successfully when !CONFIG_MEMCG (The following patch should be applied), I'll update this in the next version if anyone agrees with this change. Thanks. diff --git a/mm/kfence/core.c b/mm/kfence/core.c index 9976b3f0d097..b5c4b62b5d2c 100644 --- a/mm/kfence/core.c +++ b/mm/kfence/core.c @@ -583,7 +583,9 @@ static bool __init kfence_init_pool(void) struct kfence_metadata *meta = &kfence_metadata[i]; /* Initialize metadata. */ +#ifdef CONFIG_MEMCG slab->memcg_data = (unsigned long)&meta->objcg | MEMCG_DATA_OBJCGS; +#endif INIT_LIST_HEAD(&meta->list); raw_spin_lock_init(&meta->lock); meta->state = KFENCE_OBJECT_UNUSED; @@ -940,7 +942,9 @@ void __kfence_free(void *addr) { struct kfence_metadata *meta = addr_to_metadata((unsigned long)addr); +#ifdef CONFIG_MEMCG KFENCE_WARN_ON(meta->objcg); +#endif /* * If the objects of the cache are SLAB_TYPESAFE_BY_RCU, defer freeing * the object, as the object page may be recycled for other-typed diff --git a/mm/kfence/kfence.h b/mm/kfence/kfence.h index 6f0e1aece3f8..9a6c4b1b12a8 100644 --- a/mm/kfence/kfence.h +++ b/mm/kfence/kfence.h @@ -89,7 +89,9 @@ struct kfence_metadata { struct kfence_track free_track; /* For updating alloc_covered on frees. */ u32 alloc_stack_hash; +#ifdef CONFIG_MEMCG struct obj_cgroup *objcg; +#endif };