From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91667C433F5 for ; Sat, 5 Mar 2022 02:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90F468D0002; Fri, 4 Mar 2022 21:24:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BEC38D0001; Fri, 4 Mar 2022 21:24:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 787008D0002; Fri, 4 Mar 2022 21:24:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 69BE38D0001 for ; Fri, 4 Mar 2022 21:24:31 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 208598249980 for ; Sat, 5 Mar 2022 02:24:31 +0000 (UTC) X-FDA: 79208738742.16.BD48969 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf17.hostedemail.com (Postfix) with ESMTP id 4678840002 for ; Sat, 5 Mar 2022 02:24:30 +0000 (UTC) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-2db2add4516so110943687b3.1 for ; Fri, 04 Mar 2022 18:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KaK+5lr9aY7CpYlBgNyNImsYowzjeltr1NfPXrT3b98=; b=7PN9fzdnBufyXzQWwLnjRIeqdwUtSVnJkYYxHxZPbPZaH9pK62brJRXw3moWiQiLb8 AAIac5IuyU8zx5xi259n2dEZVsq5+4ktFWr8DF43aDndpmKgwzcFgqzLMPiHbE0CEVD6 paW6fGl6iZkLNzTOG0GMwlAPI52v5IS5wPy4ONXU7Rbv5PWPlkLP8uE7df0r1t0U2oUP Ykx+b2H2f63683oeQw1sLFVO1V1UEff1wwfDvmXrO0Y4enBPOEN3qn6UOzhGjOqGeBA7 r54gkaVpIKkAl6h2aj+aVlWg/bNQ8E3HAeecNSFbVY6YVZLOvQ25kr2kel2qT8slYBZG muNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KaK+5lr9aY7CpYlBgNyNImsYowzjeltr1NfPXrT3b98=; b=YOqXJHhk9ooOOQDGjiS4MzBKSmLCpctqX9k6PaYHKxwJGgE5JSI4pDZzgNAV7shqrw g7EhuqgYxuFofZztjesiCKxNE4y3elNKSBgaILzp1H4xmFvrUBB1M4mA+HABJzrBMtt9 Hs7B15Uqpx5UPcDZX5xPsbCmmeH1d6CPHnZTfvP21rYtxBn1pX+UtN3wB+7RD53qiIYe J24YLP16M6DuqmqjRHAdlc8J54m8hqbc0h9zYS5lrjAgDqoKCiiDi3H0/kyPzjkiNbOD wz3GmgPXJfETOX2d5ELQxQbZixKw3dd9bSk//N6F1hU24AUMA6zKup8W+3A4XIs+UW3S 3nCA== X-Gm-Message-State: AOAM532wBFajmOCWjKuSKn3o/PSLl7gy5bZvHpF0yF5i/kRkbS8XP/jD GhfHIPGizYrlsU3TToJ2M9WJPidQtXR4cXSXwyqGkA== X-Google-Smtp-Source: ABdhPJz19QFFrEH/T57gadMoGCEYBqeMptriXEVyGcVX8UohdnQftIBGzpm6ObUyfiJtMUaucss38XklGgW3v1BJSRU= X-Received: by 2002:a0d:dfd4:0:b0:2dc:572e:10c2 with SMTP id i203-20020a0ddfd4000000b002dc572e10c2mr1245960ywe.319.1646447069558; Fri, 04 Mar 2022 18:24:29 -0800 (PST) MIME-Version: 1.0 References: <20220304093409.25829-1-linmiaohe@huawei.com> <20220304093409.25829-14-linmiaohe@huawei.com> In-Reply-To: <20220304093409.25829-14-linmiaohe@huawei.com> From: Muchun Song Date: Sat, 5 Mar 2022 10:23:17 +0800 Message-ID: Subject: Re: [PATCH 13/16] mm/migration: return errno when isolate_huge_page failed To: Miaohe Lin Cc: Andrew Morton , Mike Kravetz , Yang Shi , Matthew Wilcox , Huang Ying , Zi Yan , Minchan Kim , Alistair Popple , ave.hansen@linux.intel.com, o451686892@gmail.com, Mina Almasry , John Hubbard , Ralph Campbell , Peter Xu , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Michal Hocko , riel@redhat.com, Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4678840002 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=7PN9fzdn; spf=pass (imf17.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: rs7fywbe5xnjw3fmmorwoifxaxts5dzr X-HE-Tag: 1646447070-102100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 4, 2022 at 5:36 PM Miaohe Lin wrote: > > We should return errno (-EBUSY here) when failed to isolate the huge page > rather than always return 1 which could confuse the user. > > Signed-off-by: Miaohe Lin IIUC, this should be a bug fix since the status reported to the user is wrong. A Fixes tag may be needed. But anyway: Reviewed-by: Muchun Song Thanks.