From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE98C433F5 for ; Wed, 15 Dec 2021 12:35:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48A5D6B0071; Wed, 15 Dec 2021 07:35:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 413C76B0073; Wed, 15 Dec 2021 07:35:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28CD76B0074; Wed, 15 Dec 2021 07:35:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 14D8D6B0071 for ; Wed, 15 Dec 2021 07:35:34 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C7196181AEF09 for ; Wed, 15 Dec 2021 12:35:23 +0000 (UTC) X-FDA: 78919974126.26.1697801 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf07.hostedemail.com (Postfix) with ESMTP id E41CD40019 for ; Wed, 15 Dec 2021 12:35:21 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id j2so54622505ybg.9 for ; Wed, 15 Dec 2021 04:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/PPAsdJy1fvI4IOk7fwhrZPqTZxBHd9OaF3oRGCQhSE=; b=W044lgVz7oRByJHiznLwmwuOhHSsIr9WupRS5mvk2WZ9VbtiG5EK3x8N6zldAG079F SkUvnhF2zswp6UvcJZEDGkw5ZzrBd8tPuevXvcjR8WZGRP0Vek4u6zRY/B78EnA/w9fl vaUDkKJ3IED9TBzE4j+Cm1JI8UHqEUKxfDIc11VzejXBcZlmwf28OLn3zljG5QT29JUq c5l/9c8WEz+Btspj0KgGAln22fEFaBV3WhjcDEHAb98qIlJyFPxSoawx5vWbhvY98CLr tM3/p0ZROCe+YBgg4vEAL5AmEH0kV4Rr94PT63I9CBl/M4IuUeWl+ZrdpNS4QyK/0/6V B0jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/PPAsdJy1fvI4IOk7fwhrZPqTZxBHd9OaF3oRGCQhSE=; b=GiTic1JZYE5hsBDrc/+KdWIFLgPxSlySYZmcLLs5NcowHrohaDKreKivuQAYlEm0ik HMuNevzgvB2y/v362cSKZXGd8Z6NxtEtE20pEV8SOKwL5lr8diu3W/V2XmMky76XDaRB xZikypPbhFKbpfPguRHvrLzlEJTFbYt0NzzGyDEgiB+ufN07yLqbx+vwrAqsHWBdiJT6 1cXmYwmkX7eJTpMzM2lGWmC3zD2dR8uSPtsj8lovP4x5a7eWtrsOSXdvo9MuNK1BPjGo MSU/RrWfHIncuLKUDvhJriTqAUSaJOPJ13BcLGVxUzvcxY3zXtRPb6t1Qetq/fgGU6WC YjhA== X-Gm-Message-State: AOAM533GOTtnSENF/0Q1UqtXMlCAYIH00YV7wtZigaXd4DJjIcA6KWSn N9M25cNuuxKBefFYSGtTkY8GGFmdbNbl/Lc/hNo+fA== X-Google-Smtp-Source: ABdhPJyxflIhvpUmrJZ5mUXlnXimvj20RtQWT1adLFErhhGflKCG4cbZFFkiqSaQvpBKD6qVNrEcGYUKSk146eY/mL8= X-Received: by 2002:a25:d157:: with SMTP id i84mr5541033ybg.703.1639571720913; Wed, 15 Dec 2021 04:35:20 -0800 (PST) MIME-Version: 1.0 References: <20211213165342.74704-1-songmuchun@bytedance.com> <20211213165342.74704-3-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Wed, 15 Dec 2021 20:34:45 +0800 Message-ID: Subject: Re: [PATCH v4 02/17] mm: introduce kmem_cache_alloc_lru To: Johannes Weiner Cc: Matthew Wilcox , Andrew Morton , Michal Hocko , Vladimir Davydov , Shakeel Butt , Roman Gushchin , Yang Shi , Alex Shi , Wei Yang , Dave Chinner , trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, jaegeuk@kernel.org, chao@kernel.org, Kari Argillander , linux-fsdevel , LKML , Linux Memory Management List , linux-nfs@vger.kernel.org, Qi Zheng , Xiongchun duan , fam.zheng@bytedance.com, Muchun Song Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E41CD40019 X-Stat-Signature: 9muuekb6mx1nyeytwc7tx7fpfittwpb7 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=W044lgVz; spf=pass (imf07.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1639571721-309612 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 14, 2021 at 9:50 PM Johannes Weiner wrote: > > On Tue, Dec 14, 2021 at 12:53:27AM +0800, Muchun Song wrote: > > +/* > > + * The allocated list lru pointers array is not accounted directly. > > + * Moreover, it should not come from DMA buffer and is not readily > > + * reclaimable. So those GFP bits should be masked off. > > + */ > > +#define LRUS_CLEAR_MASK (__GFP_DMA | __GFP_RECLAIMABLE | __GFP_ACCOUNT | __GFP_ZERO) > > There is already GFP_RECLAIM_MASK for this purpose, you can use that. Cool. Thanks. > > > +int memcg_list_lru_alloc(struct mem_cgroup *memcg, struct list_lru *lru, > > + gfp_t gfp) > > +{ > > + int i; > > + unsigned long flags; > > + struct list_lru_memcg *mlrus; > > + struct list_lru_memcg_table { > > + struct list_lru_per_memcg *mlru; > > + struct mem_cgroup *memcg; > > + } *table; > > + > > + if (!list_lru_memcg_aware(lru) || memcg_list_lru_allocated(memcg, lru)) > > + return 0; > > + > > + gfp &= ~LRUS_CLEAR_MASK; > > gfp &= GFP_RECLAIM_MASK;