From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 175B2C2B9F7 for ; Wed, 26 May 2021 03:30:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 730AD6138C for ; Wed, 26 May 2021 03:30:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 730AD6138C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E3D6E6B0036; Tue, 25 May 2021 23:30:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEBA46B006E; Tue, 25 May 2021 23:30:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8BDE6B0070; Tue, 25 May 2021 23:30:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 8E3886B0036 for ; Tue, 25 May 2021 23:30:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 324E9A2B6 for ; Wed, 26 May 2021 03:30:29 +0000 (UTC) X-FDA: 78181954578.05.CB8E59C Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf14.hostedemail.com (Postfix) with ESMTP id 247AAC0007C0 for ; Wed, 26 May 2021 03:30:20 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id u7so8857979plq.4 for ; Tue, 25 May 2021 20:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y5w76b7HEyp3T0g1tHDuWx3/iumM0HDwwVPmTmEiu+I=; b=vU3F2Ae2W3UovSzLt2rEnrcQI0TTq6l+vpJPd/eE66SlsYLF07zVs7/tgyvFU4eMKg d5j8K2+LnMw8nw4CvJlPxyvfKmvWNPqzfUrhG51LOTVf9FYLO5cqf1tgcsjOSsx47rAt lG0LrG8o9clUiB+TmTeouOvd0Syv/itJcAvRo/ZjF5AeznlkRwVgiR92X42x9++nj1wB WuNyMzyQlsI6Mx09n2mAUz9RsU53eCHa5+MAti7fPciOp+HLj00wArWqIpdIKcL7WSdF 8tNa+aLEnX+5xc1Wcq0InOf3s2wGNKNYHXK5djvwRfdpfmoZ2VpjYoeOTvPBT3SksI7k jIxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y5w76b7HEyp3T0g1tHDuWx3/iumM0HDwwVPmTmEiu+I=; b=HkJsFcxqRQvtgSeNGBsluq4auA3C2hife6MSpFwIz3O0nWSMGCBCt5H6tCeboZvAE5 KG1awyXwQXwUSJfjNXFHYflw//YeJAXCLEAK7AodyNCKFrwMVVQwxyfCLWCPfj58cU8k tW39IKVCB+QS/djIAWhJVAXQNtRp19Rjv3ZpVcGEvGqb8QtOUEYyYs2O+mTzMaKtj8S2 ov1zQWjnCTkoG2ID8BGee7CfV/9VOm3xeEnHewU+b95HOMKJiblOJDGQYxqyLWcV6T+5 YC5GqUey6n/CmW1K80gIBDFpNuxeacJM1SEc7w8BjMjlN1ivOQxDKsqpf2+mVlgexzI8 DEYQ== X-Gm-Message-State: AOAM533U8Mry5ozfpn1vvYoQGilQwIT2ba3gsjOzyc47sUIb89ESwDME Rmxog/SdT575JW0VXXT11nr1Qk17/55AYfkVphmx/A== X-Google-Smtp-Source: ABdhPJzHsfM9Lqly6YtQzpJc1P8G796gXX5S/HnxbZlUaIH0Oo+ng7hq9t3dVAasZrnNNNC4yaVAGs58PoW7DXpyt6I= X-Received: by 2002:a17:902:d711:b029:f0:b127:8105 with SMTP id w17-20020a170902d711b02900f0b1278105mr34087065ply.20.1621999827170; Tue, 25 May 2021 20:30:27 -0700 (PDT) MIME-Version: 1.0 References: <20210526025625.601023-1-swboyd@chromium.org> <20210526025625.601023-3-swboyd@chromium.org> In-Reply-To: <20210526025625.601023-3-swboyd@chromium.org> From: Muchun Song Date: Wed, 26 May 2021 11:29:50 +0800 Message-ID: Subject: Re: [External] [PATCH v2 2/4] slub: Actually use 'message' in restore_bytes() To: Stephen Boyd Cc: Andrew Morton , LKML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Linux Memory Management List , Petr Mladek , Joe Perches Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 247AAC0007C0 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=vU3F2Ae2; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf14.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam03 X-Stat-Signature: xuyp7iotrwwgxhwp39rmce47yhnf6ho9 X-HE-Tag: 1621999820-548597 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 26, 2021 at 10:56 AM Stephen Boyd wrote: > > The message argument isn't used here. Let's pass the string to the > printk message so that the developer can figure out what's happening, > instead of guessing that a redzone is being restored, etc. > > Reviewed-by: Vlastimil Babka > Acked-by: David Rientjes > Signed-off-by: Stephen Boyd > More convenient. LGTM. Reviewed-by: Muchun Song