From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52ADBC433F5 for ; Mon, 6 Sep 2021 03:54:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9BEC60EFD for ; Mon, 6 Sep 2021 03:54:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D9BEC60EFD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 690AF6B0071; Sun, 5 Sep 2021 23:54:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63FD66B0072; Sun, 5 Sep 2021 23:54:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52F036B0073; Sun, 5 Sep 2021 23:54:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 4349B6B0071 for ; Sun, 5 Sep 2021 23:54:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F3C1C181AF5D7 for ; Mon, 6 Sep 2021 03:54:05 +0000 (UTC) X-FDA: 78555780492.23.C3F48EB Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf05.hostedemail.com (Postfix) with ESMTP id 7D69B5049932 for ; Mon, 6 Sep 2021 03:54:05 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id z24-20020a17090acb1800b0018e87a24300so3667101pjt.0 for ; Sun, 05 Sep 2021 20:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c3csY8HsjlX5rCTMJueC2/d6U+TPTjCxZBWfcTbP1RI=; b=F5ZLl4Dr5TZ3vyhofbocW1JELtOGWQN4r6nzBdSx3iAqjG6KnT27Nzjc3k7eGqDuXz XehGCvUDaBW4iSV5VZlMzYSDXuE8fmU8Izi5Ndyqfaky5QmhXY0QKhq0cqVfSgG76I6b 3jkxrI9ssfo5GvgSw8UpoklHWSyG7hA8N9dLPq/C5p4vZDUTafewXVWIJZELnMzYsyIX D62DggX5vCI4pLHIYRIU83TnOvqRqN6mwNbv2TUJfNh3VBO7d+9tIeNKglY7SFoRo/0H L3KxN92Xf2EOKP12+x8nKxzPFmbdj+5go/Q13uxHaaRU0WlaXQ8tHuWESw85W0AKBCw5 M3KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c3csY8HsjlX5rCTMJueC2/d6U+TPTjCxZBWfcTbP1RI=; b=glaMMIVJErGNAZNEbEQhgT38T24XYRL5QhuzSUd16/kaXQk7qy0ZeB7BrfjW02jb12 /3pEa9qikiPMzn1DFKbm7ukEGCMMPB6C3deJdbExBKebvlua1JHSU0jIxErrjNeY7wwQ xFVitOCcGy6bljhl0xFJ/4g7RhKhrXwtAWbuocyTkeVN0Efqfy9Z+Laa42UHznDPCoxu LBZXAIs2jHppe/GGkzqYk085mj2xpsmRaUEGQnzrwbebX29lioHjY+V2e77suiMFtqTG 9wdxAZUmbYx9h9EEpTUGTdTOT5Y6Y+xLrUsaAD50pSwV4SxEXIyoMze7zYtmh0eAwTUW eI1A== X-Gm-Message-State: AOAM532UkdPf+eN08NJ4+k73prje2aX9GuMio5iM1Igw1OqNDsGsqCuw JlQeQU096/7ZYfkyH5xPTUjUceQHF1MaiJu2ibreTg== X-Google-Smtp-Source: ABdhPJxfby5NlM9BC9k1pPFwOiidLw2rgCkhKqLByvHN5mQB7wxXzCpypbZrvJkzV5Gk8pLlYGAbJzrot7Hx37MXhOQ= X-Received: by 2002:a17:902:ab8c:b0:13a:22d1:88d with SMTP id f12-20020a170902ab8c00b0013a22d1088dmr2424417plr.33.1630900444340; Sun, 05 Sep 2021 20:54:04 -0700 (PDT) MIME-Version: 1.0 References: <20210906034658.48721-1-yanghui.def@bytedance.com> In-Reply-To: <20210906034658.48721-1-yanghui.def@bytedance.com> From: Muchun Song Date: Mon, 6 Sep 2021 11:53:27 +0800 Message-ID: Subject: Re: [RESEND PATCH v3] mm/mempolicy: fix a race between offset_il_node and mpol_rebind_task To: yanghui Cc: Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=F5ZLl4Dr; spf=pass (imf05.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7D69B5049932 X-Stat-Signature: mond94abaewcqhc6w5cwsdgtqxqppgho X-HE-Tag: 1630900445-42820 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 6, 2021 at 11:47 AM yanghui wrote: > > Servers happened below panic: > Kernel version:5.4.56 > BUG: unable to handle page fault for address: 0000000000002c48 > RIP: 0010:__next_zones_zonelist+0x1d/0x40 > [264003.977696] RAX: 0000000000002c40 RBX: 0000000000100dca RCX: 0000000000000014 > [264003.977872] Call Trace: > [264003.977888] __alloc_pages_nodemask+0x277/0x310 > [264003.977908] alloc_page_interleave+0x13/0x70 > [264003.977926] handle_mm_fault+0xf99/0x1390 > [264003.977951] __do_page_fault+0x288/0x500 > [264003.977979] ? schedule+0x39/0xa0 > [264003.977994] do_page_fault+0x30/0x110 > [264003.978010] page_fault+0x3e/0x50 > > The reason of panic is that MAX_NUMNODES is passd in the third parameter > in function __alloc_pages_nodemask(preferred_nid). So if to access > zonelist->zoneref->zone_idx in __next_zones_zonelist the panic will happen. > > In offset_il_node(), first_node() return nid from pol->v.nodes, after > this other threads may changed pol->v.nodes before next_node(). > This race condition will let next_node return MAX_NUMNODES.So put > pol->nodes in a local variable. > > The race condition is between offset_il_node and cpuset_change_task_nodemask: > CPU0: CPU1: > alloc_pages_vma() > interleave_nid(pol,) > offset_il_node(pol,) > first_node(pol->v.nodes) cpuset_change_task_nodemask > //nodes==0xc mpol_rebind_task > mpol_rebind_policy > mpol_rebind_nodemask(pol,nodes) > //nodes==0x3 > next_node(nid, pol->v.nodes)//return MAX_NUMNODES > > Signed-off-by: yanghui LGTM. Reviewed-by: Muchun Song