From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6004EC433FE for ; Thu, 24 Feb 2022 03:11:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABD678D0003; Wed, 23 Feb 2022 22:11:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A47A98D0001; Wed, 23 Feb 2022 22:11:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C04D8D0003; Wed, 23 Feb 2022 22:11:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 64CAD8D0001 for ; Wed, 23 Feb 2022 22:11:16 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E8F49181CB2C2 for ; Thu, 24 Feb 2022 03:11:15 +0000 (UTC) X-FDA: 79176197310.24.E3C1AE5 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf10.hostedemail.com (Postfix) with ESMTP id 56F92C0008 for ; Thu, 24 Feb 2022 03:11:15 +0000 (UTC) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-2d68d519a33so10824827b3.7 for ; Wed, 23 Feb 2022 19:11:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8mtpPZAP/jAYJJyMzEonaOx2sTOc5n28GBAe2uH3WEY=; b=S0K6WvP3CBpaQxxCYEvAn89gSciPZblXBrv71erMz95cLnLNtW2zkatg+yAJAgTj00 POqnWFPbhQghMwFFx4v0DLLnGg6ylky5WSvhfyRD8R2eEZySUm2zKBAQfCDyV+amNQ0Q TVAW63GcunhlDC39D3QlNDI8r/9sC5Bbzjc4XQ1p58f3ABxBmWb8lzxiEl8uszqR+lCr XIFntqbOgE/2zcf3Ybjetlfvc2GBpyLZOEQkS+4ZXpZivDuMHD60zcPjdLQs6+eJvp36 1f+jnfdZInSE2h7dz9KTvRD7mJS3lbOeq37L+eQA0DDbC6tqWpcZ1s/HzkcwP1uEJbya Hmfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8mtpPZAP/jAYJJyMzEonaOx2sTOc5n28GBAe2uH3WEY=; b=2V4TOX58cJ5LRzLNxC9PgHaYmo444yvgaQJSKg8G6Xc1JBWMQvatGThduZHrEFdi1U k8MBq4hutKuSY7V1Z+AKXgANEc3TN3KeRZwSD9QCPs1KBh5/DcMXKenAw3aq0Suaw7bZ g5sHXKPo1IteZFjX9e3bMkMHdO8CdL6Qtk5D5+bi3gONIhiL+m+06xINdo8RmzAoK8tY 3UpqJvEnDfyi4c/3skcnP3Wdy7U3sVAqv7ZssWEp5C0UsgQ52za2WFc7CzJ+q7a/N3Dm z0c5YzmVnMzzwiUNGMQr5/NcrHlLX/FbZE+07ywYrTOkY28DpGwuPJumJ/VCaNtjoGAq 1ZCw== X-Gm-Message-State: AOAM530iKmJPaZMTQvqvAgIwvJmerthpYknNqU0J8EbREueb2vTRtZyd b9TisJRiLDjdNtRzTNl+niiwzGNNTXbMSaw403+/DA== X-Google-Smtp-Source: ABdhPJwptZfPYhJvyu9jxfgMax6JVNrA4Pjt/3kifQRRjekLcRYO6pKkn+QzAd2aHb3P73wOLHCN4Da3bM9b+36fi5g= X-Received: by 2002:a0d:f347:0:b0:2d6:916b:eb3f with SMTP id c68-20020a0df347000000b002d6916beb3fmr596585ywf.141.1645672274498; Wed, 23 Feb 2022 19:11:14 -0800 (PST) MIME-Version: 1.0 References: <20220223194807.12070-1-joao.m.martins@oracle.com> <20220223194807.12070-3-joao.m.martins@oracle.com> In-Reply-To: <20220223194807.12070-3-joao.m.martins@oracle.com> From: Muchun Song Date: Thu, 24 Feb 2022 11:10:37 +0800 Message-ID: Subject: Re: [PATCH v6 2/5] mm/sparse-vmemmap: refactor core of vmemmap_populate_basepages() to helper To: Joao Martins Cc: Linux Memory Management List , Dan Williams , Vishal Verma , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Mike Kravetz , Andrew Morton , Jonathan Corbet , Christoph Hellwig , nvdimm@lists.linux.dev, Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 56F92C0008 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=S0K6WvP3; spf=pass (imf10.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: kuurcbphg3qn8doagsj4mp5wsjrnhrpn X-HE-Tag: 1645672275-663986 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 24, 2022 at 3:48 AM Joao Martins wrote: > > In preparation for describing a memmap with compound pages, move the > actual pte population logic into a separate function > vmemmap_populate_address() and have vmemmap_populate_basepages() walk > through all base pages it needs to populate. > > While doing that, change the helper to use a pte_t* as return value, > rather than an hardcoded errno of 0 or -ENOMEM. > > Signed-off-by: Joao Martins Reviewed-by: Muchun Song Thanks.