From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75797C433F5 for ; Tue, 22 Mar 2022 08:48:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB5726B0072; Tue, 22 Mar 2022 04:48:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3E996B0073; Tue, 22 Mar 2022 04:48:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDF6B6B0074; Tue, 22 Mar 2022 04:48:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id B89676B0072 for ; Tue, 22 Mar 2022 04:48:56 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8EEFF6184C for ; Tue, 22 Mar 2022 08:48:56 +0000 (UTC) X-FDA: 79271397072.02.69EFE05 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf27.hostedemail.com (Postfix) with ESMTP id 60DFA4002D for ; Tue, 22 Mar 2022 08:48:55 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id m67so32422247ybm.4 for ; Tue, 22 Mar 2022 01:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QUKbEll3B3MyYDyon4P+rDcqkN3F18MECGrGkqKUuno=; b=rm2us6OKRLqK7uRSyjF58yCfkJFOuUQJ9OiT0aRPlGY+hdgxdLxevBebqmkYxi7Kvp dYYnA0yznikOIfcp94kmvCoHwd3eBaIBjlxJ5Ao8gBTwrcNcKI6+UrEemVYlvx+6/UVx xQVQLCPAuf2wJfSSvaL+r0brkUh5rLAurDIX9UxgFBAzX35pIb/O7NdcUgsovcWiJygc +F4Hmk9ymVELB1ruVF0OKDyHW3I9h6mok5rpFm1I/Rmx2oeIeTvKOXwH/USeLye/E6CX mVxSVtQpis0R05ccolu21RU+dA8oYht1hQDmNtryYzocmi033mHBJGcf8CtqqD9ukgUX BV2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QUKbEll3B3MyYDyon4P+rDcqkN3F18MECGrGkqKUuno=; b=CK5a6l9bNOf+nwvbjggoJ0nB9MwthK3vi4B1utSyjGUUarQrCNfFSaUaBXVNGmdBrC Yjxtz5kF/yN6fnyasYstZ5XY+g/KjRFmPQTbDHzbjrB4tr9laK7AL5dWC6CzOc6/VsqQ iY0fc6K9I/+4q+zrD8Bu531XwCn2dRW1xSfCAbZ16a7N4lJmm0Neh1dNPJMZhmqQzqxW 9RnrEosRElHc1RVc6xeZaW1BWK7DwaJ+3s3T5RglUxiwFdd+5HnPeGwWHsk9V27dDV2O 1Ur0DxxPClpExRmd8wom6fqYWkrAKFALnyv0m2ODrlSLKK2zl/SdqVntBgbiM2i2ZQGU 3LvA== X-Gm-Message-State: AOAM530pOQ1wupbylQPdAdV/4QdwbiB5N05VtkconRnr2w3yKY66qfMh 2JZOgyyRKZ6gAtdj7spflZwWsoQTAIx9EBfDJKgdhg== X-Google-Smtp-Source: ABdhPJwub/NwJPB45j1iuLmm89NuZIw9wFdhV28CEQ33EGCiwtZ2hoVGFhhKU2aj/mWUCkmcesq4ImawnosiJZEkcZo= X-Received: by 2002:a25:8390:0:b0:629:2839:9269 with SMTP id t16-20020a258390000000b0062928399269mr25658972ybk.246.1647938934543; Tue, 22 Mar 2022 01:48:54 -0700 (PDT) MIME-Version: 1.0 References: <20220318074529.5261-1-songmuchun@bytedance.com> <20220318074529.5261-6-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Tue, 22 Mar 2022 16:46:59 +0800 Message-ID: Subject: Re: [PATCH v5 5/6] dax: fix missing writeprotect the pte entry To: Christoph Hellwig Cc: Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Andrew Morton , Alistair Popple , Yang Shi , Ralph Campbell , Hugh Dickins , Xiyu Yang , "Kirill A. Shutemov" , Ross Zwisler , linux-fsdevel , Linux NVDIMM , LKML , Linux Memory Management List , Xiongchun duan , Muchun Song Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 60DFA4002D X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=rm2us6OK; spf=pass (imf27.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: z3k1u6qzys95stpcx8if8z5p5x7fw371 X-HE-Tag: 1647938935-57492 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 22, 2022 at 4:37 PM Christoph Hellwig wrote: > > > +static void dax_entry_mkclean(struct address_space *mapping, unsigned long pfn, > > + unsigned long npfn, pgoff_t start) > > { > > struct vm_area_struct *vma; > > + pgoff_t end = start + npfn - 1; > > > > i_mmap_lock_read(mapping); > > + vma_interval_tree_foreach(vma, &mapping->i_mmap, start, end) { > > + pfn_mkclean_range(pfn, npfn, start, vma); > > cond_resched(); > > } > > i_mmap_unlock_read(mapping); > > > Is there any point in even keeping this helper vs just open coding it > in the only caller below? Good point. I'll fold dax_entry_mkclean() into the caller. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig Thanks.