From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DFCC43461 for ; Mon, 14 Sep 2020 03:11:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E72B020715 for ; Mon, 14 Sep 2020 03:11:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="uWCczg2z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E72B020715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1B10E6B0003; Sun, 13 Sep 2020 23:11:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13BC96B0037; Sun, 13 Sep 2020 23:11:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0028D6B0055; Sun, 13 Sep 2020 23:11:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id DAC8C6B0003 for ; Sun, 13 Sep 2020 23:11:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8EE96180AD801 for ; Mon, 14 Sep 2020 03:11:02 +0000 (UTC) X-FDA: 77260190364.25.man56_4d03c5527105 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 5FE2218047632 for ; Mon, 14 Sep 2020 03:11:02 +0000 (UTC) X-HE-Tag: man56_4d03c5527105 X-Filterd-Recvd-Size: 4052 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 03:11:01 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id k15so11347880pfc.12 for ; Sun, 13 Sep 2020 20:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NOjlPnEGfverOe/NjTfHJ965zGyyw9hgsDwthm8fBO8=; b=uWCczg2zelk3J2BSLQ0zws70nqO2Qrj0gvnO2vtQuHmsmUewjkzP6BOyKhWOf7bsi8 UxCD19k7Z758PpS4M50tNgLTQwxa9bOY8iPkIfDyrjLrEFk4nSL8nUc3ffp6wzJc6nsb E03dGwR/aCB100q8leNRNfS4ITrdZTJe/8y1gqWskcEYHWYUhYK8GHzuPEWBD7TsiZyg kt40GXGfTlyabPEXkpvLvGwXQ3qPFXMzZ/uipyK3nqbnpikV+i+cl3SF6sBhLbbMLdyH 7wQVgvUgWfQqg7oH4zJ5tY3mT6tIDnAqP4SAPXwI1/t1YyF1qL/qRE9vxh1J8fzllJG9 vmmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NOjlPnEGfverOe/NjTfHJ965zGyyw9hgsDwthm8fBO8=; b=i/SyQGy3sx9yL9mCDUTGbBukM2f11rqE4SZj2Ko9mJtqzU62B6JbyvFAKlpCn6cu9Q fRwnBMNGyr/UA7OOnaitShWfluhbHVSIlJ151/EH06IZDUYh4r8cFM+4Um2NCayMgW5m jcEgjaetEgmhiEk+7oD3MoooOjy60Zcg+1P/rHKn6QapopryIEP8ga633ybG8UwOpDpt fvzOhTVOyACjnQjc6mj5U/t4zqzMsFWac8bDTSgsT0wVh0SO7ga9VS2rZDCRXU5e0Gii RT8AggtJZx/iRho3EeqJrOhlXm2WNHX1AoejyQfxMokhM75QDXIY35W6MV/opV3/6kSV BSYQ== X-Gm-Message-State: AOAM530/zNSpQefT1o52zrxiW9frNd9IAH/FpEg2y6B748xTOzfCTg6I pUGavDMUv675liGIZfCaPPhy4i2z3wd2CL4GOL5jQg== X-Google-Smtp-Source: ABdhPJx4FxwJQZgfVBSb1/npUEzqRxM2ff4oVtXhlJsuhFTOCVKCUma7soUXDoNfMVUVcCe0LgqVZ4ylVmc3fCaZL+0= X-Received: by 2002:a17:902:a605:b029:d0:cbe1:e714 with SMTP id u5-20020a170902a605b02900d0cbe1e714mr12582624plq.34.1600053060539; Sun, 13 Sep 2020 20:11:00 -0700 (PDT) MIME-Version: 1.0 References: <20200913070010.44053-1-songmuchun@bytedance.com> <20200913170913.GB2239582@chrisdown.name> In-Reply-To: <20200913170913.GB2239582@chrisdown.name> From: Muchun Song Date: Mon, 14 Sep 2020 11:10:24 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 To: Chris Down Cc: tj@kernel.org, lizefan@huawei.com, Johannes Weiner , corbet@lwn.net, Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Cgroups , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5FE2218047632 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 14, 2020 at 1:09 AM Chris Down wrote: > > Muchun Song writes: > >In the cgroup v1, we have a numa_stat interface. This is useful for > >providing visibility into the numa locality information within an > >memcg since the pages are allowed to be allocated from any physical > >node. One of the use cases is evaluating application performance by > >combining this information with the application's CPU allocation. > >But the cgroup v2 does not. So this patch adds the missing information. > > > >Signed-off-by: Muchun Song > >Suggested-by: Shakeel Butt > >Reported-by: kernel test robot > > This is a feature patch, why does this have LKP's Reported-by? In the v2 version, the kernel test robot reported a compiler error on the powerpc architecture. So I added that. Thanks. -- Yours, Muchun