From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26AD6C07E9C for ; Tue, 6 Jul 2021 06:50:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 90D1F6197E for ; Tue, 6 Jul 2021 06:50:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90D1F6197E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 28E426B005D; Tue, 6 Jul 2021 02:50:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 217FD6B006C; Tue, 6 Jul 2021 02:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 069696B0070; Tue, 6 Jul 2021 02:50:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id CF5646B005D for ; Tue, 6 Jul 2021 02:50:44 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4D4F2824999B for ; Tue, 6 Jul 2021 06:50:44 +0000 (UTC) X-FDA: 78331240008.24.E565283 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf29.hostedemail.com (Postfix) with ESMTP id 5A39B9000094 for ; Tue, 6 Jul 2021 06:50:42 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id g6-20020a17090adac6b029015d1a9a6f1aso1121130pjx.1 for ; Mon, 05 Jul 2021 23:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WxRxvbvPJKtE9j1haCeD3JgDCpQu9adJA5ZIJGxvPe4=; b=Ul2aED+i54aC8bXAxZYg5syxf8716TFdPxxYI6RbeRglt+HKwfDCrpHO+wTGXaRPin e2DMz8bcNaYJQf1s7ZlVg8AX9S1iIyIA2L4BszwoCMjHKjiVifQZHT+W8MBxPRdoVyZd U/o7pR6YzonABNKJ/ZBhCGeuIF15GU7A0EqNeP4I4x0GJd5/jqVNbxycyj4VY56zG1e+ U3vgnxoYIml67EkVzM8aS7ENEV9jdcWtDOzJCVQWXc1j2GZ595QgBFWZJ5MW3WqYclRE VK0WNB1IjS2TmAEjVR5dJ5FLvoRkMe7Bw3J4AHyx4zxGx6VsOt432wc90O16uIOsNoQv JVRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WxRxvbvPJKtE9j1haCeD3JgDCpQu9adJA5ZIJGxvPe4=; b=r5vwAKDkJrSDaxMiCd5rUULvEYRVfWVpcVH5728TfndOxqyh5UDVYxv8ZM+2PTT3+u KcjtWfpkJBCOF3x9MSTDcUw32dnfJNqG54a/9AQh+r/JLiGuBkQi0F+dsOoUlbCD1u1m NbTSTO6GivGh7lGdPwY4y11J3IVyUyDIdUsxxu19/SWfVw1txd+waXTJLJcmCZBm1bp1 LESpCoPMagrJ2bMFGjhfn6D0AG+bCusA+s59eUf+B13E1bXybE/+PK45sTQ/pOp3c/Fu q+l/NeNe2LO6LU9uCP5GXnVwAvOPbg3D9mfpCI7/Gs5Xvcnu5zaupZWOd6b9VmnsW13H hVjA== X-Gm-Message-State: AOAM530ECQF7jWxONj1s7eFlquAGIDhecMS3TzTHKG/TR7d73J56rVJw yH+7cwWiIMyVUMOK625U8xAZHal+FytZIsYIpKQEnA== X-Google-Smtp-Source: ABdhPJwPgLex1MgFrzlym+XQVZMzXx2/SdHK+j5HfduDsARtC1KBVtO22hDeA8cEHw2KJUni+uX2VE5b+8+59JJnGPk= X-Received: by 2002:a17:90a:14a4:: with SMTP id k33mr19609735pja.13.1625554241252; Mon, 05 Jul 2021 23:50:41 -0700 (PDT) MIME-Version: 1.0 References: <20210706032907.1276-1-qiang.zhang@windriver.com> In-Reply-To: <20210706032907.1276-1-qiang.zhang@windriver.com> From: Muchun Song Date: Tue, 6 Jul 2021 14:50:04 +0800 Message-ID: Subject: Re: [External] [PATCH] mm/page_alloc: Fix sleeping function called in case of irqsdisable. To: qiang.zhang@windriver.com Cc: mgorman@techsingularity.net, Andrew Morton , alobakin@pm.me, wangqing@vivo.com, Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5A39B9000094 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=Ul2aED+i; spf=pass (imf29.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: 6yb4dho6aet5c7z3ganqrppgotaxzt38 X-HE-Tag: 1625554242-65096 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 6, 2021 at 11:29 AM wrote: > > From: Zqiang > > BUG: sleeping function called from invalid context at mm/page_alloc.c:5179 > in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 1, name: swapper/0 > ..... > __dump_stack lib/dump_stack.c:79 [inline] > dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:96 > ___might_sleep.cold+0x1f1/0x237 kernel/sched/core.c:9153 > prepare_alloc_pages+0x3da/0x580 mm/page_alloc.c:5179 > __alloc_pages+0x12f/0x500 mm/page_alloc.c:5375 > alloc_page_interleave+0x1e/0x200 mm/mempolicy.c:2147 > alloc_pages+0x238/0x2a0 mm/mempolicy.c:2270 > stack_depot_save+0x39d/0x4e0 lib/stackdepot.c:303 > save_stack+0x15e/0x1e0 mm/page_owner.c:120 > __set_page_owner+0x50/0x290 mm/page_owner.c:181 > prep_new_page mm/page_alloc.c:2445 [inline] > __alloc_pages_bulk+0x8b9/0x1870 mm/page_alloc.c:5313 > alloc_pages_bulk_array_node include/linux/gfp.h:557 [inline] > vm_area_alloc_pages mm/vmalloc.c:2775 [inline] > __vmalloc_area_node mm/vmalloc.c:2845 [inline] > __vmalloc_node_range+0x39d/0x960 mm/vmalloc.c:2947 > __vmalloc_node mm/vmalloc.c:2996 [inline] > vzalloc+0x67/0x80 mm/vmalloc.c:3066 > > If the PAGE_OWNER is enabled, in __set_page_owner(), the pages will be > allocated to save calltrace info, due to the allocated action is executed > under irq disable(pagesets.lock be held), if the gfp variable contains > the flag that causes sleep, will trigger above information. the > prep_new_page() is not need to disable irq for protection, fix it through > enable irq before call prep_new_page(). > > Fixes: 0f87d9d30f21 ("mm/page_alloc: add an array-based interface to the bulk page allocator") > Reported-by: syzbot+0123a2b8f9e623d5b443@syzkaller.appspotmail.com > Signed-off-by: Zqiang > --- > mm/page_alloc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index d6e94cc8066c..8d7f0f5ce891 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5309,12 +5309,14 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int preferred_nid, > } > nr_account++; > > + local_unlock_irqrestore(&pagesets.lock, flags); > prep_new_page(page, 0, gfp, 0); > if (page_list) > list_add(&page->lru, page_list); > else > page_array[nr_populated] = page; > nr_populated++; > + local_lock_irqsave(&pagesets.lock, flags); Because pagesets.lock is relocked here, the current thread can be scheduled to another CPU. The @pcp and @pcp_list need to be reloaded. Otherwise, it is broken in the next loop. Thanks. > } > > local_unlock_irqrestore(&pagesets.lock, flags); > -- > 2.17.1 >