From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 263E3C43334 for ; Sun, 12 Jun 2022 14:45:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A34B6B00C4; Sun, 12 Jun 2022 10:45:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 353296B00C5; Sun, 12 Jun 2022 10:45:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21A6C8D011D; Sun, 12 Jun 2022 10:45:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 122D26B00C4 for ; Sun, 12 Jun 2022 10:45:13 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DD26433CC3 for ; Sun, 12 Jun 2022 14:45:12 +0000 (UTC) X-FDA: 79569856464.28.293F6B7 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf16.hostedemail.com (Postfix) with ESMTP id B3A91180078 for ; Sun, 12 Jun 2022 14:45:11 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id l204so6121626ybf.10 for ; Sun, 12 Jun 2022 07:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nEdR+JbeZcNXqk7Oize93k4cETioRbi+nld4A68DmHI=; b=HDA1tKvKCLx8xGKrKJIHKZH6CszMl5x397hw2tMs5e0A++sOMsZ818nKfFqwQsALO5 DNWqZy2w1iJpSmKxoriAD+OOx/RRRrQ7n4krIhcuyIW9Mav80M1OlqOxup8pd52elUDP Vg9++E6KfiJAxIBgLfO4ZcChlEfjCCalCPUQCpJq05H9av94LvnoD/4l0SV/V2Coisk2 r13NvbVAb/qEBerdtWuAo/IRW5Pr0CAO7VDiWZId72k0avbBZrxO4k2maGqWYoYmWbrW IKI+kmhLIGkWSzDS6012dED/nKIyGRF1WWoEw+orASaSmly+18xjmIdEXA4YjLrAJACq TgxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nEdR+JbeZcNXqk7Oize93k4cETioRbi+nld4A68DmHI=; b=hiVdk3CPP/o/sUaMR2F+6gUkaH9llxRSVb/sLQ0noUesLkXg5Kd7C68k1iLBZbFkIB 1O2jCSnEkxj+wtpBtJGS0E+z5/b7cCtypFxtQR95p47r9MKz6VZaexkAsTbwDkkvB4of oW1EOt2JweWizhxHW7RGoBUGIxP15Cj1KbpJqBxOFXtbiiDY9SzDEvm6+Bx7MDT6k6tk wLHOnn/fTJ4AC5cBulBguVLaIkHiq2UiwEhYCOzWAybPT0+B2MffgP89pHIbTxd7OB58 TkNl8eN9mY2/9c6rSSR5aLKsY8YFvikG3odv92JObiwB7FXnkd/C/QUE4by5jHKYj3Yh BNYQ== X-Gm-Message-State: AOAM530u5bL/CuiEa3Y+FG1ljBYI+H9e9i/LtC87U8FJXmzG9tvHEN9d ZYoxg06gkgNDmcxZxvL/iet4hh6VlLTB0uDOzCDGrw== X-Google-Smtp-Source: ABdhPJyfdCfKcUXduNxctDUAwhfLi+QiaFlKyTIqzGi5M8U04rsK2Risq7tlWOaOA8yMzPUTlIsHF9ipmTILj0S4WbI= X-Received: by 2002:a25:d7d3:0:b0:664:d4d4:43e8 with SMTP id o202-20020a25d7d3000000b00664d4d443e8mr1118381ybg.427.1655045110755; Sun, 12 Jun 2022 07:45:10 -0700 (PDT) MIME-Version: 1.0 References: <20220610180310.1725111-1-roman.gushchin@linux.dev> In-Reply-To: <20220610180310.1725111-1-roman.gushchin@linux.dev> From: Muchun Song Date: Sun, 12 Jun 2022 22:44:34 +0800 Message-ID: Subject: Re: [PATCH] mm: kmem: make mem_cgroup_from_obj() vmalloc()-safe To: Roman Gushchin Cc: Andrew Morton , Linux Memory Management List , LKML , Naresh Kamboju , Vasily Averin , Qian Cai , Kefeng Wang , Linux Kernel Functional Testing , Shakeel Butt Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655045112; a=rsa-sha256; cv=none; b=3xqWSBmvoWIb/gtgMK7hSVbMnDgjbo4nI9B6hptUtXlXQgOqVC1HXGHEqN3RnPbKtx58pb OHf7kh7b3hokHOIGY79PoteFOWtIn8Y9+59e7BF6lNidOHpUpw0Mup279xkP5CogJjR3HF gVB9Tt6fPeGomJ+MbV76eCyZTh4WF1s= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=HDA1tKvK; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655045112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nEdR+JbeZcNXqk7Oize93k4cETioRbi+nld4A68DmHI=; b=fFXBB8tyjDB0mmiLcX9abHCFMWpGu3eNGEpH7PbSNj+zA0HcxBLgelbt30yNOfOGkv/M/T puIrFKrojJjc5YKXF+g9f52o8ApszMQkSLcrzm2d3aYNdRVOsOu4KJdosXZjczq9Jg/VcQ Ed7ofNkGqT3Chy20esBT9wwegbsua5U= X-Rspamd-Queue-Id: B3A91180078 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=HDA1tKvK; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: dp9558rjg6x1fz1uej5hi71qfpynyih3 X-Rspamd-Server: rspam02 X-HE-Tag: 1655045111-715225 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 11, 2022 at 2:04 AM Roman Gushchin wrote: > > Currently mem_cgroup_from_obj() is not working properly with objects > allocated using vmalloc(). It creates problems in some cases, when > it's called for static objects belonging to modules or generally > allocated using vmalloc(). > > This patch makes mem_cgroup_from_obj() safe to be called on objects > allocated using vmalloc(). > > It also introduces mem_cgroup_from_slab_obj(), which is a faster > version to use in places when we know the object is either a slab > object or a generic slab page (e.g. when adding an object to a lru > list). > > Suggested-by: Kefeng Wang > Signed-off-by: Roman Gushchin > Tested-by: Linux Kernel Functional Testing > Acked-by: Shakeel Butt Acked-by: Muchun Song Thanks.