From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE78BC433F5 for ; Tue, 30 Nov 2021 02:34:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 115C56B0071; Mon, 29 Nov 2021 21:34:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C6206B0072; Mon, 29 Nov 2021 21:34:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECE7B6B0073; Mon, 29 Nov 2021 21:34:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id DD7C26B0071 for ; Mon, 29 Nov 2021 21:34:24 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9DCAB8FD13 for ; Tue, 30 Nov 2021 02:34:14 +0000 (UTC) X-FDA: 78864027228.04.5A320C4 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf08.hostedemail.com (Postfix) with ESMTP id 4F90D30000B7 for ; Tue, 30 Nov 2021 02:34:06 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id d10so48102677ybe.3 for ; Mon, 29 Nov 2021 18:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TfYJSxsbLxhJzDiPj/duqxgB5VLSDdQGpN98L3/Vhrc=; b=UEEaYp1rLqFfBNJuI4XBpjEIV4blhdNGa6OpmQA7R2W1kKP7XcaCntTLjpKwR6K3RQ VMYKrD0/Q8VC1qN+WJy8o9OZ6RwTPQlGJlikqV9dbnwip85PFuOYqiNs3Nu0GrcaZliF 5va9RGfS7KHnurWlFafNaoSyoaDCmZchlPpkkesDPamLLCs+mn/8+PgygwYZoHr9M+C7 KxYr8k5QoaUWzztDqs5dC8/TbDmGNUBepo+9/C8r45UWk48EeSqMA8zRuC/z/5exwkbs Ne1H8t3DhBECAZzDC877WHZQjGwqFSUArJ40GOQ8GBS/Eb7zZIcBPaJtl/XUPbbAG+7V BqzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TfYJSxsbLxhJzDiPj/duqxgB5VLSDdQGpN98L3/Vhrc=; b=QKZnje4g+0N9IqsY1he0Aw7F36DsPkA9Z3Ug/+9tHA9l4R0gshQwh+IVBk0IoOWVwq zs1U6hLqlpFM5cmco1Nky7M/t6HwAVldv4nbwwescJLk/ADi2U09zLx8cp4M/xv1Zaa3 RO/voSLb6Luxf4+GbQSk3Onor3OnJ+/dnwMrapOxS4PNYdhpyJfCIp9fRQeF1by287mh 8w+Ys7MdqXAfxgyrLglw+JcKhySBEFdDWH2LSOeifkNrhhswZ1pa159LIEUFWByr5Nu+ mOesSKsTIuNmtH7zVMFqzPnTrFwTRB2Lifn574NI3gzzctjMtLlLyAep/dIIQwdP3JpQ hkJA== X-Gm-Message-State: AOAM530mYgpKG1J5QkekQTSlTOeos4PK4eH0L3PCTPUun/hJ2NqWcZPg S8xWLPd/ZkLovz/eTN7yIpJuUGiv6chhyBAr9kw1MQ== X-Google-Smtp-Source: ABdhPJwyWy1rg8/bds7VX4f9iqBpEkOuLqZ+jy8TvkRIqTYzZLwheruQmkgxkuWRm1xOf0FttRg1G4Cr4TorKlduAnE= X-Received: by 2002:a25:b285:: with SMTP id k5mr39430450ybj.132.1638239652378; Mon, 29 Nov 2021 18:34:12 -0800 (PST) MIME-Version: 1.0 References: <20211129133803.15653-1-yaozhenguo1@gmail.com> In-Reply-To: <20211129133803.15653-1-yaozhenguo1@gmail.com> From: Muchun Song Date: Tue, 30 Nov 2021 10:33:35 +0800 Message-ID: Subject: Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages can't work To: Zhenguo Yao Cc: Mike Kravetz , Andrew Morton , mlevitsk@redhat.com, LKML , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4F90D30000B7 X-Stat-Signature: gtuow7cayrcxw3bu6cutgf8j66r6cjmc Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=UEEaYp1r; spf=pass (imf08.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1638239646-242008 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 29, 2021 at 11:27 PM Zhenguo Yao wrote: > > Preallocation of gigantic pages can't work bacause of commit:b5389086ad7b > (hugetlbfs: extend the definition of hugepages parameter to support node > allocation). When nid is NUMA_NO_NODE(-1), alloc_bootmem_huge_page will > always return without doing allocation. Fix this by adding more check. > > Signed-off-by: Zhenguo Yao Reviewed-by: Muchun Song Thanks.